Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Feb 2021 00:14:11 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     David Laight <David.Laight@aculab.com>
Cc:     Jason Gunthorpe <jgg@ziepe.ca>,
        Lino Sanfilippo <LinoSanfilippo@gmx.de>,
        "peterhuewe@gmx.de" <peterhuewe@gmx.de>,
        "stefanb@linux.vnet.ibm.com" <stefanb@linux.vnet.ibm.com>,
        "James.Bottomley@hansenpartnership.com" 
        <James.Bottomley@hansenpartnership.com>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip
Message-ID: <YC2VM1JI0tECPs7g@kernel.org>
References: <1613435460-4377-1-git-send-email-LinoSanfilippo@gmx.de>
 <1613435460-4377-2-git-send-email-LinoSanfilippo@gmx.de>
 <20210216125342.GU4718@ziepe.ca>
 <YCvtF4qfG35tHM5e@kernel.org>
 <74bbc76260594a8a8f7993ab66cca104@AcuMS.aculab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <74bbc76260594a8a8f7993ab66cca104@AcuMS.aculab.com>
Precedence: bulk

On Tue, Feb 16, 2021 at 04:31:26PM +0000, David Laight wrote:
> ...
> > > > +	get_device(&chip->dev);
> > > > +	chip->devs.release = tpm_devs_release;
> > > > +	chip->devs.devt =
> > > > +		MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES);
> > 
> > Isn't this less than 100 chars?
> 
> Still best kept under 80 if 'reasonable'?
> 
> Really it is just split in the wrong place:
> 	chip->devs.devt = MKDEV(MAJOR(tpm_devt),
> 					chip->dev_num + TPM_NUM_DEVICES);


Well it looks crap IMHO. Would be more reasonable to have it in a single 
like. And it is legit too, since it is accepted by checkpatch.

You might break the lines within 80 chars if it is somehow "logically"
consistent.

> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
> 
> 

/Jarkko