Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1613604031-27798-1-git-send-email-khsieh@codeaurora.org>
References: <1613604031-27798-1-git-send-email-khsieh@codeaurora.org>
Subject: Re: [PATCH 1/2] phy/qualcomm: add hbr3_hbr2 voltage and premphasis swing table
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     tanmay@codeaurora.org, abhinavk@codeaurora.org,
        aravindh@codeaurora.org, khsieh@codeaurora.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Kuogee Hsieh <khsieh@codeaurora.org>, agross@kernel.org,
        bjorn.andersson@linaro.org, robdclark@gmail.com, sean@poorly.run,
        vkoul@kernel.org
Date:   Wed, 17 Feb 2021 15:43:55 -0800
Message-ID: <161360543514.1254594.14314447256582277276@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Kuogee Hsieh (2021-02-17 15:20:31)
> Add hbr3_hbr2 voltage and premphasis swing table to support
> HBR3 link rate.
>=20
> Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
> ---
>  drivers/phy/qualcomm/phy-qcom-qmp.c | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/p=
hy-qcom-qmp.c
> index 0939a9e..c920143 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -2965,6 +2965,20 @@ static void qcom_qmp_phy_dp_aux_init(struct qmp_ph=
y *qphy)
>                qphy->pcs + QSERDES_V3_DP_PHY_AUX_INTERRUPT_MASK);
>  }
> =20
> +static const u8 qmp_dp_v3_pre_emphasis_hbr3_hbr2[4][4] =3D {
> +        { 0x00, 0x0C, 0x15, 0x1A },
> +        { 0x02, 0x0E, 0x16, 0xFF },
> +        { 0x02, 0x11, 0xFF, 0xFF },
> +        { 0x04, 0xFF, 0xFF, 0xFF }

Lowercase hex please.

> +};
> +
> +static const u8 qmp_dp_v3_voltage_swing_hbr3_hbr2[4][4] =3D {
> +        { 0x02, 0x12, 0x16, 0x1A },
> +        { 0x09, 0x19, 0x1F, 0xFF },
> +        { 0x10, 0x1F, 0xFF, 0xFF },
> +        { 0x1F, 0xFF, 0xFF, 0xFF }
> +};

Lowercase hex please.

> +
>  static const u8 qmp_dp_v3_pre_emphasis_hbr_rbr[4][4] =3D {
>         { 0x00, 0x0c, 0x14, 0x19 },
>         { 0x00, 0x0b, 0x12, 0xff },
> @@ -3000,8 +3014,13 @@ static void qcom_qmp_phy_configure_dp_tx(struct qm=
p_phy *qphy)
>                 drvr_en =3D 0x10;
>         }
> =20
> -       voltage_swing_cfg =3D qmp_dp_v3_voltage_swing_hbr_rbr[v_level][p_=
level];
> -       pre_emphasis_cfg =3D qmp_dp_v3_pre_emphasis_hbr_rbr[v_level][p_le=
vel];
> +       if (dp_opts->link_rate <=3D 2700) {
> +               voltage_swing_cfg =3D qmp_dp_v3_voltage_swing_hbr_rbr[v_l=
evel][p_level];
> +               pre_emphasis_cfg =3D qmp_dp_v3_pre_emphasis_hbr_rbr[v_lev=
el][p_level];
> +       } else {
> +               voltage_swing_cfg =3D qmp_dp_v3_voltage_swing_hbr3_hbr2[v=
_level][p_level];
> +               pre_emphasis_cfg =3D qmp_dp_v3_pre_emphasis_hbr3_hbr2[v_l=
evel][p_level];
> +       }
>