Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: CyLoedjzDE/lX/xYgfMg6P0LKSxDxciDQ+xqtNzGYrn2Z+odyswtUPjPf0UVwlQPCtbQ4ZR0C3
 LaXeY3r2D9bw==
IronPort-SDR: sn366c49e7ftdmEMSpCxEYtyEdNH2roaTs5/wSWTiK0eedRxMwHo+xG2W4WxsUfYbRvoZcWemg
 hhXgp1PGv9bQ==
Date:   Wed, 17 Feb 2021 15:29:39 -0800
From:   mark gross <mgross@linux.intel.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     mgross@linux.intel.com, markgross@kernel.org, arnd@arndb.de,
        bp@suse.de, damien.lemoal@wdc.com, dragan.cvetic@xilinx.com,
        gregkh@linuxfoundation.org, corbet@lwn.net,
        palmerdabbelt@google.com, paul.walmsley@sifive.com,
        peng.fan@nxp.com, robh+dt@kernel.org, shawnguo@kernel.org,
        jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org,
        Seamus Kelly <seamus.kelly@intel.com>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 20/34] xlink-core: Add xlink core driver xLink
Message-ID: <20210217232939.GD154917@linux.intel.com>
Reply-To: mgross@linux.intel.com
References: <20210212222304.110194-1-mgross@linux.intel.com>
 <20210212222304.110194-21-mgross@linux.intel.com>
 <ddacd2e2-b491-5443-4006-c8c5d90d583f@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ddacd2e2-b491-5443-4006-c8c5d90d583f@infradead.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sun, Feb 14, 2021 at 09:52:51AM -0800, Randy Dunlap wrote:
> On 2/12/21 2:22 PM, mgross@linux.intel.com wrote:
> > diff --git a/drivers/misc/xlink-core/Kconfig b/drivers/misc/xlink-core/Kconfig
> > new file mode 100644
> > index 000000000000..a0ceb0b48219
> > --- /dev/null
> > +++ b/drivers/misc/xlink-core/Kconfig
> > @@ -0,0 +1,33 @@
> > +config XLINK_CORE
> > +	tristate "Support for XLINK CORE"
> > +	depends on ((XLINK_PCIE_RH_DRIVER || XBAY_XLINK_PCIE_RH_DRIVER) || (XLINK_LOCAL_HOST && (XLINK_PCIE_LH_DRIVER || XBAY_XLINK_PCIE_RH_DRIVER)))
> 
> -ELINETOOLONG. Use '\' for line continuation in Kconfig files.
fixed

> 
> > +	help
> > +	  XLINK CORE enables the communication/control subsystem.
> > +
> > +	  If unsure, say N.
> > +
> > +	  To compile this driver as a module, choose M here: the
> > +	  module will be called xlink.ko.
> > +
> > +config XLINK_LOCAL_HOST
> > +	tristate "Support for XLINK LOCAL HOST"
> > +	depends on XLINK_IPC
> > +	help
> > +	  XLINK LOCAL HOST enables local host functionality for
> > +	  the communication/control Sub-System.
> > +
> > +	  Enable this config when building the kernel for the Intel Vision
> > +	  Processing Unit (VPU) Local Host core.
> > +
> > +	  If building for a Remote Host kernel, say N.
> > +
> > +config XLINK_PSS
> > +	tristate "Support for XLINK PSS (Pre-Silicon Solution)"
> > +	depends on XLINK_LOCAL_HOST
> > +	help
> > +	  XLINK PSS enables the communication/control subsystem on a PSS platform.
> > +
> > +	  Enable this config when building the kernel for the Intel Vision
> > +	  Processing Unit (VPU) in a simulated env.
> 
> Please s/env/environment/.
fixed

I have the update qued up and I'll post v7 rebased when the merge window closes

--mark

> 
> > +
> > +	  If building for a VPU silicon, say N.
> 
> 
> -- 
> ~Randy
>