Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm/hugetlb: remove redundant reservation check condition
 in alloc_huge_page()
To:     Mike Kravetz <mike.kravetz@oracle.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20210210075443.26238-1-linmiaohe@huawei.com>
 <32f628d5-fa0c-2a81-2de4-d0a76d1c3e45@oracle.com>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <9cd0da77-65c3-5ba2-f882-b54a1950bf39@huawei.com>
Date:   Thu, 18 Feb 2021 10:27:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <32f628d5-fa0c-2a81-2de4-d0a76d1c3e45@oracle.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi:
On 2021/2/13 9:15, Mike Kravetz wrote:
> On 2/9/21 11:54 PM, Miaohe Lin wrote:
>> If there is no reservation corresponding to a vma, map_chg is always != 0,
>> i.e. we can not meet the condition where a vma does not have reservation
>> while map_chg = 0.
> 
> This commit message might be easier to understand?
> 
> vma_resv_map(vma) checks if a reserve map is associated with the vma.  The
> routine vma_needs_reservation() will check vma_resv_map(vma) and return 1
> if no reserv map is present.  map_chg is set to the return value of
> vma_needs_reservation().  Therefore, !vma_resv_map(vma) is redundant in the
> expression:
> 	map_chg || avoid_reserve || !vma_resv_map(vma);
> Remove the redundant check.
> 

Sorry for late respond! I will use this wonderful commit message. Many thanks! :)