Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <28cb279081ef09216de91bddaafe5be339a9601e.camel@nxp.com>
Subject: Re: [PATCH v3 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to
 DPI support
From:   Liu Ying <victor.liu@nxp.com>
To:     Rob Herring <robh@kernel.org>
Cc:     dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org,
        a.hajda@samsung.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@siol.net, kishon@ti.com, vkoul@kernel.org
Date:   Thu, 18 Feb 2021 10:56:08 +0800
In-Reply-To: <20210209181510.GA4045547@robh.at.kernel.org>
References: <1611737488-2791-1-git-send-email-victor.liu@nxp.com>
         <1611737488-2791-10-git-send-email-victor.liu@nxp.com>
         <20210209181510.GA4045547@robh.at.kernel.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from blueberry.ap.freescale.net (119.31.174.66) by SG2PR0601CA0018.apcprd06.prod.outlook.com (2603:1096:3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27 via Frontend Transport; Thu, 18 Feb 2021 02:57:36 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 3a7eeb18-a887-427d-eb98-08d8d3b8f5b2
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3405:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB340540895F8514E36C1FC78498859@VI1PR0402MB3405.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: f8ahYERRcq/ubdRf3CFXmVLVG1vsvhLD3wg8z8hnQ5QbVnP0g2xRVwNuzm5muDEydMtpxGeNU+FMNsRf/Bmc2vyA/vue5zO0696qOlIjOBTXsJx4e3V/HktcUo7xLzARDsPaJscAqU/aAjVbSJA99yUR2B8Jh4Mb9isUlXn2xtcqv9ubLvb22NdsVM+89UQEYY6bBq4dQ6QosCfq+3ezI0kCEDLS9R0AgyMO9eB4l/KVQd37+CoGDZVKGpIIFQBYLJrH6xzmtZG+DGFj36fmzjQ6a2odxx3JCYGPalsSOmSbk9fc+DKTZ9HMjptndBEQuuJfj/FY2S1W8uhjUCrkKPw9MC0kZ6gHFCpanw3IIuKezrXYaCFSRZZeNN/FlWtLuqMaGE6tyIHJnb00CHUMxGOgLMAgL6N2mKknleqqboVEOEcwhwdqmkndL6QE0DjB6wyOtu+2/qrgHp5fcd3XG2PiMu16458I8wIb+I4csoJtJUGeF4EKXYJDygbUMbzsTAqKAdna4ctumtfwvbqMcw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB3983.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(376002)(136003)(346002)(396003)(366004)(16526019)(52116002)(6486002)(26005)(186003)(4326008)(8936002)(2616005)(956004)(6916009)(66946007)(7416002)(8676002)(36756003)(2906002)(86362001)(66476007)(66556008)(316002)(6512007)(478600001)(5660300002)(6506007)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bEFscHdwaHVucmxmMVBhZDJSNkxqQ0NjMTFTeXZ6R1RnUG9KVEpHZFJ5QTR3?=
 =?utf-8?B?S3d1UWJxQndkTXVwSGRBbXB2UDlabVhWTUI4dVNZTHJaSVVGZ0RXQzNTM0kw?=
 =?utf-8?B?RHVuWjIzYk0rTmx2K3QvTkkxME56RHovcDZVVEFWNk9TeW53YURvLzRQTVh1?=
 =?utf-8?B?d280SndsekY5STNYdHlmWXZmZStxTGU5WjdvRUVTY1hkc1NhaGZyTFRQbnVO?=
 =?utf-8?B?Tm0rTWMvbDRDU2VxZUJXdER2OU1zV3lNNXk0SUFZQWdYcjJpVVlSRzJianhO?=
 =?utf-8?B?elNFWGF5cWFvOXAwRUdac3dYUXFNcjBYaWNiOFhrdEZWZmdXRC9tODJKYUV5?=
 =?utf-8?B?NlMvVFd2Um1udFdISHA2dHNxbHNtVm5vdUR4K280NDBKMXpQbG55VXkybmtm?=
 =?utf-8?B?amJnSGRCbXRwSHNrZXZrU3hnZmRWQ3k2c3Eyak0xdEkrUVB2eUE5enh4bXBY?=
 =?utf-8?B?RVVoeDRnSjlpY0RIZVBDWjhSL2IwbnNOKyswNzhseERndTJrcVJWcU5abDVL?=
 =?utf-8?B?YkFXNnZ6MnIwY1BXNW5CTnpRZUpGcG0zUXRQY1dHamZxM0pxQTNVamIzRkl1?=
 =?utf-8?B?L05hdGVSWU9NNmk2V2pzVXBTZDNCcWFBb3dzWEkxeDJFZG5RSFI2VTJ5OHVm?=
 =?utf-8?B?bFZkYlcxL1BsK1p2bTZ1N3J0bnJYSWsvZ2lzMlhWcWZtSUdJQkd6dFUyL1VX?=
 =?utf-8?B?SDlxam4wM0gwaGFOZ3pORlJPb1RqcFg1M2VPVG5Qdkd4NXg1YlpWc3RFTTVq?=
 =?utf-8?B?dTJ5WmdyRjRDMjdwckREKytzWnM0Z0IzZENjbS82emdhL005M1FkNHhXdHo0?=
 =?utf-8?B?M3VVeHFFN3BlT1g2TCtlWVJuTHl3YVhEdmhFWk4yb0l1dHFsbkd1UjdrNG5k?=
 =?utf-8?B?L2ozTkJ5Qm4xN015MWFDMllCODQwdE9vM2tTRUZGRzVobXRsZ3RZUTRUdWxV?=
 =?utf-8?B?aldpVFkveEhDaVBJN0txQmc0NHZCdy9yRk0ycVlWczJGWklHK1RRT25xMDI0?=
 =?utf-8?B?N0JUa042V1BlRlhCQ05iV0JnSDZmR3JFR1FGbHpHSW9iVEZwN2p1cDRjbno3?=
 =?utf-8?B?dGY0czZTOWRvY1h2eE4rMmlDWGc1R0dnNWFObXBKVFZpV0tVS1VvYW02UURv?=
 =?utf-8?B?eXpSN1R0MGxQVlJjdHQva2JRcGlLK3dOQ0tEaldXSWFSRmw3Q3pwRDNKVklM?=
 =?utf-8?B?K0k4aExMckxDdHIvQnUrQXRqTlN5dHJxL2hzcVBqTnBkSEE1UGRPNm1od2l0?=
 =?utf-8?B?WjV6aU1WbUFjWVBBeDRuYmRIVmVJU3k3VURyNk1xallUQUZXT2xxV1A3MytD?=
 =?utf-8?B?b3Y5VEtoOTFaaEZPZFNIczJCRUdRbDhPUGxRRlVWK0ZWRm9kbHNwZmRFN1o3?=
 =?utf-8?B?SktpL3FpR3M3RFUzb3JxdU5MaUNkVit3NU04WDJhb2pyTW52cWh3K2cvR212?=
 =?utf-8?B?OWZLb1c5QlFPd3EzSzQzRjY4eDA2ZVlCd00yekRWUzFUQnZnWllxeE9ScVVN?=
 =?utf-8?B?eGQxaGU2c2RlcmNiWVk3QmlJcFMzV25vNFBPYjdRTmZhT1NCNjNRcU9IdS96?=
 =?utf-8?B?cVlCSDFlNlM5eWpjYmNFK3FIYTF1dTkyNEF5M0EwZTlSTXpyVm1GZ2FiT1Vw?=
 =?utf-8?B?UFczeUdHd3ROaDl5eUhUak1ZZXl3aWNOQU1LMjBQQ1RqdHpNeDNaMmwyY1dt?=
 =?utf-8?B?L21Ba1NPZytMWGhXeTBFNSsyRkVpVDBSUDI5cFdTQUozM0xVODUycngxU09w?=
 =?utf-8?Q?Aw98JPEoEvx8n9tr3T0RkAlAO5wZ94QXPvmxMPn?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a7eeb18-a887-427d-eb98-08d8d3b8f5b2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3983.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2021 02:57:43.0477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iQ76ftJWXK+a4//nYh6CKhOdGgblP4D57peu1bsZ4lQCh7aIpMS8mLIC8IXS5mgLVPhR+FgxwmJUPebyn/8jmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3405
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2021-02-09 at 12:15 -0600, Rob Herring wrote:
> On Wed, Jan 27, 2021 at 04:51:23PM +0800, Liu Ying wrote:
> > This patch adds a drm bridge driver for i.MX8qxp pixel link to display
> > pixel interface(PXL2DPI).  The PXL2DPI interfaces the pixel link 36-bit
> > data output and the DSI controller’s MIPI-DPI 24-bit data input, and
> > inputs of LVDS Display Bridge(LDB) module used in LVDS mode, to remap
> > the pixel color codings between those modules. The PXL2DPI is purely
> > combinatorial.
> > 
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v2->v3:
> > * Call syscon_node_to_regmap() to get regmap instead of
> >   syscon_regmap_lookup_by_phandle().
> > 
> > v1->v2:
> > * Drop unnecessary port availability check.
> > 
> >  drivers/gpu/drm/bridge/imx/Kconfig           |   8 +
> >  drivers/gpu/drm/bridge/imx/Makefile          |   1 +
> >  drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 488 +++++++++++++++++++++++++++
> >  3 files changed, 497 insertions(+)
> >  create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> > +	p2d->regmap = syscon_node_to_regmap(np->parent);
> > +	if (IS_ERR(p2d->regmap)) {
> > +		ret = PTR_ERR(p2d->regmap);
> > +		if (ret != -EPROBE_DEFER)
> > +			DRM_DEV_ERROR(dev, "failed to get regmap: %d\n", ret);
> > +		return ret;
> > +	}
> > +
> > +	p2d->id = of_alias_get_id(np, "pxl2dpi");
> 
> Don't add random aliases. I'd rather see a property in this node as long 
> as it is specific to what this is used for (and not a generic index).

Ok.  I'll use a DT property to get the SCU resource ID associated with
the PXL2DPI instance.  Thanks.

Liu Ying

> 
> Rob