Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7037151pxb; Wed, 17 Feb 2021 22:44:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwaTBvvUU5fIyP9w9kENtn+agqqnuNRFvyXOwX2yCC4W0FeJ6WwF9/RbrekCPP5ZbUPAzDN X-Received: by 2002:a17:906:17d3:: with SMTP id u19mr2682803eje.316.1613630685568; Wed, 17 Feb 2021 22:44:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613630685; cv=none; d=google.com; s=arc-20160816; b=kp2y7FFBTNBrwUG6/7V8gGglACcrSF8iKHUOUw/IBGLL7iZlsDFKe5yd2XT27Khp8z kpOFPa/63N0yXAK3bdM1e701TO7wjDqzL+6K9WhpsTOA4zpp0n9fE/HLPqXVy3aS9XsA L1YXxwLMF7wVgEVQxqIr8+X0azQL2wYhL+M0EP8EwRmCgSD+uxzG9R2RQmD7fSz7IC2x DsxsQbzRSfZNiz9nHENDRXjQY+W0ITIawnsJIuVmoEUXoOarrotdqcYFETTNaBrUgYW+ 2RF4Jfpwf7zN/Fy0qGtUPDDGgpBbJ5jDWzNql/yxneZkNcmNMyra4X85B2h9D6NyBQTk pPGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=yHtGxWfPAIZEvBnGmWjlN6rdZWQnYSnX/GzqtFWIJg0=; b=QJ0tyIh/q3xUTEAF4lmFFd+NOQmZBYVoxknKlnHuj1Q/kdFEWr3EkDG4sQJBvlsTGd 5lhrqRSHs3Y6kjjGq7kmp8SaNoaUqXzhBWsLo/5dc6syPHpiMDXm3uYXSsDqhpwvf7Fm yqjU9NT0VClZxbaD03amJd9dwt1/DWQX631mPKTgZZLlGIXkqZg3rGpwGoPBqez22gk1 AJ34oX/roLz7jlrDYYB51MwMyKx2NULGUdx/xFTsnifQr9aEOgC8rKuNPpNQlOdwbVWh c6ylSm4NrFw3RfwcOSuCkc0mSw0XFF5fSxFgojJqt4uJa4pCVywLYI/L2SHCk5sgVUXi 0vYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TOewui0l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i23si3459799ejj.317.2021.02.17.22.44.22; Wed, 17 Feb 2021 22:44:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TOewui0l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbhBRGlx (ORCPT + 99 others); Thu, 18 Feb 2021 01:41:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbhBRGa1 (ORCPT ); Thu, 18 Feb 2021 01:30:27 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B2CEC0613D6; Wed, 17 Feb 2021 22:29:46 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id w18so605967pfu.9; Wed, 17 Feb 2021 22:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yHtGxWfPAIZEvBnGmWjlN6rdZWQnYSnX/GzqtFWIJg0=; b=TOewui0lXbhSkNw7mI+ljNrV0hf31Mu/TsPD3Fa99a3Vr6Wnm9DSIF/fn+PxPmZ2lm tCnpqmbQxbbYKPyZ2OPqkaj6iPF5hyQ8q2gKRvD3mQhYO7RH1mLUtxn0q/rU7DEZh/Tk 8UXeYOMrr6MU7miSrQLfrsEcrdOWVSbATP8L3D3gyfXYo7wZnYkAhxBTipoRQKbDk3C9 GWgh7s/u/U+rg2KvPgji7XIDuKTEWX5JjU/XkNK/F9/9u/QFi4SWv15o96VYRaiH1GLh PnbZTKe0NUeT9DyLjPVv8Z0CAbWHpNI0B+WwpKg6cj6gGW/F5oeygzONeFkGEguL2F2M n/AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yHtGxWfPAIZEvBnGmWjlN6rdZWQnYSnX/GzqtFWIJg0=; b=QfhDWJzizPCkxYIcxA3Faznt1rnLp0c2VRHwUnfNpqoCphzVSL3uszUDW67jO2d9S6 +bJFmUUYeZ0hxO2TEX9pVOAoQbJD14iTYxoBrPhG/m/GnxhjCwJnbTTXNajyQfx80jUx fksBbLboY1mTXaFB279A+TbUDxNsmX3AU/GEdJYaM1QOhvsWgLffMyBGFIJPmNAXKr3K Mba6n5C36JBErS0iLfwYa2AZn7gRuNXdUvqP/aGeedyxmBptBbh3MRFmpalPRs/IkOtN jsV4Ndkc+40qFuzE5MmEXqaL+DyWZDiyvw7vyRoJBXR2IFRFNMPSwuf8bNfWUQS73KUk 3Vtg== X-Gm-Message-State: AOAM5327N6NMEeT/tBywc48TYyqpMoan+f5LcP70Kvm84bBbm2d51xx9 n8C8HeU5T8H8LOpcdRvsdjHRsFVsdSxC6A== X-Received: by 2002:a63:547:: with SMTP id 68mr2736959pgf.196.1613629786117; Wed, 17 Feb 2021 22:29:46 -0800 (PST) Received: from Asurada-Nvidia (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id l144sm4436954pfd.104.2021.02.17.22.29.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Feb 2021 22:29:45 -0800 (PST) Date: Wed, 17 Feb 2021 22:30:39 -0800 From: Nicolin Chen To: Julia Lawall Cc: Timur Tabi , kernel-janitors@vger.kernel.org, Xiubo Li , Fabio Estevam , Shengjiu Wang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] ASoC: fsl: drop unneeded snd_soc_dai_set_drvdata Message-ID: <20210218063038.GB13668@Asurada-Nvidia> References: <20210213101907.1318496-1-Julia.Lawall@inria.fr> <20210213101907.1318496-5-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210213101907.1318496-5-Julia.Lawall@inria.fr> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 13, 2021 at 11:19:07AM +0100, Julia Lawall wrote: > snd_soc_dai_set_drvdata is not needed when the set data comes from > snd_soc_dai_get_drvdata or dev_get_drvdata. The problem was fixed > usingthe following semantic patch: (http://coccinelle.lip6.fr/) > > // > @@ > expression x,y,e; > @@ > x = dev_get_drvdata(y->dev) > ... when != x = e > - snd_soc_dai_set_drvdata(y,x); > > @@ > expression x,y,e; > @@ > x = snd_soc_dai_get_drvdata(y) > ... when != x = e > - snd_soc_dai_set_drvdata(y,x); > // > > Signed-off-by: Julia Lawall Acked-by: Nicolin Chen