Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Feb 2021 08:10:28 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Atul Gopinathan <atulgopinathan@gmail.com>
Cc:     abbotti@mev.co.uk, hsweeten@visionengravers.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: cast to (void __user *)
Message-ID: <YC4S5Pxw341zw9DL@kroah.com>
References: <20210218062839.32650-1-atulgopinathan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210218062839.32650-1-atulgopinathan@gmail.com>
Precedence: bulk

On Thu, Feb 18, 2021 at 11:58:40AM +0530, Atul Gopinathan wrote:
> Resolve the following sparse warning:
> drivers/staging//comedi/comedi_fops.c:2983:41: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging//comedi/comedi_fops.c:2983:41:    expected void [noderef] <asn:1> *uptr
> drivers/staging//comedi/comedi_fops.c:2983:41:    got unsigned int *chanlist
> 
> cmd->chanlist is of type (unsigned int *) as defined in
> "struct comedi_cmd" in file drivers/staging/comedi/comedi.h
> 
> The function "ptr_to_compat()" expects argument of type
> (void __user *) as defined in include/linux/compat.h
> 
> Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
> ---
>  drivers/staging/comedi/comedi_fops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Is this different from your previous patch:
	https://lore.kernel.org/r/20210217165907.9777-1-atulgopinathan@gmail.com

if so, you might need a better subject line here, and for that one, as
they look alike at a quick glance.

Which one goes first?

Can you resend both of these as a patch series with better subjects as a
v2 patch set?

thanks,

greg k-h