Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Feb 2021 09:08:12 +0000
Message-ID: <87czwxpwub.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org,
        tglx@linutronix.de
Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain
In-Reply-To: <YC4q5TRXWI8KZ8n9@kroah.com>
References: <YCvYV53ZdzQSWY6w@kroah.com>
        <20210217195717.13727-1-michael@walle.cc>
        <4e4d0479b935e60a53f75ef534086476@kernel.org>
        <5c527bfb6f3dfe31b5c25f29418306c6@walle.cc>
        <87czwys6s1.wl-maz@kernel.org>
        <YC4X4iLMCK3tNVsF@kroah.com>
        <8b4de9eae773a43b38f42c8ab6d9d23c@walle.cc>
        <YC4q5TRXWI8KZ8n9@kroah.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 18 Feb 2021 08:52:53 +0000,
Greg KH <gregkh@linuxfoundation.org> wrote:

[...]

> Ok, how about this:
> 
> 
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 2fcf66473436..86c7f0489620 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -297,7 +297,7 @@ struct dentry *debugfs_lookup(const char *name, struct dentry *parent)
>  {
>  	struct dentry *dentry;
>  
> -	if (IS_ERR(parent))
> +	if (!debugfs_initialized() || IS_ERR_OR_NULL(name) || IS_ERR(parent))
>  		return NULL;
>  
>  	if (!parent)
> @@ -318,6 +318,9 @@ static struct dentry *start_creating(const char *name, struct dentry *parent)
>  	if (!(debugfs_allow & DEBUGFS_ALLOW_API))
>  		return ERR_PTR(-EPERM);
>  
> +	if (!debugfs_initialized())
> +		return ERR_PTR(-ENOENT);
> +
>  	pr_debug("creating file '%s'\n", name);
>  
>  	if (IS_ERR(parent))
> 

That one boots correctly in a guest.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.