Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7139160pxb; Thu, 18 Feb 2021 02:26:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhVcva8j6iSAvBf/j0TbT/3vZgkOYaJdYmOkdoh8rbqgrC+HCcaCMts/JvoCFkwNOgQcmy X-Received: by 2002:aa7:ca57:: with SMTP id j23mr3487135edt.293.1613643963098; Thu, 18 Feb 2021 02:26:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613643963; cv=none; d=google.com; s=arc-20160816; b=V6zeJGLR7f/oVtT4SdRSTUdc+Jdcr7G4nywUgOrS6ZDxNrsIOMFIsDas3SVpRvCv/N wB2f9Ow5Wx+0Ipvc82B++f1U3KuuxnAqJBMCNKrJ/NYosMljce697P9NM6xyrgGmabvr DF+Q2mbR3649ALPnNX6j8IN3vRNej3x87t0pHTaxSh+uwMyXKnZKiq2fSg/3BajcO8Aj mGOJ+rF2HHnCFHNA7M2f0OTCCZvHjPLVGyzOycTlDbVkcQoHSRZgGYLPLk00pW19OlE3 au/9gVBXqp/JzT/8NT4CIr0BKsGGZEdgoN0ujWkxkGTVyo6gj8Q5W0PcCkcaI2vXC0q2 XQmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=mQBztfjp/3MStXH0+mDXVbD87NdXIglzoEnDzflrmdo=; b=q9Pqsdozcpui3ZdZWHtevh6L26LMCgb9Yldj0JzDTnuiwi0OBFCnPNdEPQK2W2YNZt 71mDYGlNXTr6VWGrDjhKDid3i85fJbEZTt4/YslTjAVE/drJJkV9/jm91xSJ8Fnq3N/F 03ahMqbsVyB6oPs9bYTvoqlSyDRa8D811Mf128nK6Pulf9477qfTPaZLGzcMLfzJl2uw P6VXM0NqsZSMSo/Q+8yhAssNZUTFh4jh9wr77vfswJqMNn4nrzN5To820ypmS63gU9kl eB5Pa8G/O8/42WSsEHB8ml5XfXYN5yusSdxC0+sEBTMUjuU/4Y5Qy5GdQbYllHDZ+AL5 AQsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=INyf+rS1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm10si3466020ejc.64.2021.02.18.02.25.26; Thu, 18 Feb 2021 02:26:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=INyf+rS1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232695AbhBRKRc (ORCPT + 99 others); Thu, 18 Feb 2021 05:17:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231529AbhBRJL3 (ORCPT ); Thu, 18 Feb 2021 04:11:29 -0500 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 422BBC0613D6; Thu, 18 Feb 2021 01:07:25 -0800 (PST) Received: by mail-pg1-x530.google.com with SMTP id p21so740380pgl.12; Thu, 18 Feb 2021 01:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mQBztfjp/3MStXH0+mDXVbD87NdXIglzoEnDzflrmdo=; b=INyf+rS1a7pOuZUIhaR+wFHLLKpfHZAS7UUgssDvlYB3GEsesmLx/Dwx8MkLzl02Db NoWvuMnGyis3hfOs0LbWrnaYIs4Xu4LibjIJH7P2CTIbFGMCXjPpCvXeuzHXNv6+qkJ0 ffWuVk4MgszZVYs531kCG+T4f7NaLTwB4LUzjPmIHwQwyd9dz+njhS/wBtMQHWDqhav0 61LMCyWdXzpy5WeNP5XVrGo28WqQjN9w6lm+INpPGPZBpTaueOc/JpJ48Db0J1HHjBC4 pmnah0vJHqY9sBUx7V2YUnd804JzEtrKInVgt3B20jRuOWo3xi23R9aQ364tziUDeI8B ftog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mQBztfjp/3MStXH0+mDXVbD87NdXIglzoEnDzflrmdo=; b=O6IpWDtZIV+9rVWqwLVn6qTcRafMTBLxhrmSao742PUzSNSdxaknvWVZ3IB87d0j1Y PFlj1nLIp/CWAcZE4AQ7qfKcRy49aBYy4X3Uy5jqmg+BvQOzM0yJ18pjfRpJQcYIZKWj QbbZ7psAGzKTH8N5FTE+dO2Mhcrm1OFiTsRIvjrGaK+9H/s8wChwuJfS8d1DwWgT7WDS Nu9WZR2UNZ07fVXmdh90zTA9YSWiepGWsg2wEDJ84e9uTTi0P7pNfNWI1YfiVKSWFotp p187nKco7ULhAi+42VMHvb7do2rAK896X5kdO1KEJmewHPm3Ycb4RT6lQQTHSgRAuj+t 8rPw== X-Gm-Message-State: AOAM532Y+jsc7pmgL2PlmmqMNeKTSNm73Ra69xcP1z2aDSA/o0Ad4W9s DYi2Yco4FqcVfcTKhDPSWYYyparLXnQ8xDAXSYAvOTab X-Received: by 2002:a63:7f09:: with SMTP id a9mr3189133pgd.63.1613639244721; Thu, 18 Feb 2021 01:07:24 -0800 (PST) MIME-Version: 1.0 References: <20210216201813.60394-1-xie.he.0141@gmail.com> In-Reply-To: From: Xie He Date: Thu, 18 Feb 2021 01:07:13 -0800 Message-ID: Subject: Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames To: Leon Romanovsky Cc: "David S. Miller" , Jakub Kicinski , Linux X25 , Linux Kernel Network Developers , LKML , Martin Schiller , Krzysztof Halasa , Jonathan Corbet , linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 12:57 AM Leon Romanovsky wrote: > > It is nice that you are resending your patch without the resolution. > However it will be awesome if you don't ignore review comments and fix this "3 - 1" > by writing solid comment above. I thought you already agreed with me? It looks like you didn't? I still don't think there is any problem with my current way. I still don't understand your point. What problem do you think is there? Why is your way better than my way? I've already given multiple reasons about why my way is better than yours. But you didn't explain clearly why yours is better than mine.