Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7173541pxb; Thu, 18 Feb 2021 03:31:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfo/3hcueRo3HXvhqRGhNFeNYOkIr90CB9KpA8OBjY53TQB/e+2TuXSfVz/F1DurEZc48N X-Received: by 2002:a05:6402:d0a:: with SMTP id eb10mr3682612edb.249.1613647885075; Thu, 18 Feb 2021 03:31:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613647885; cv=none; d=google.com; s=arc-20160816; b=S30qHxv0XaYidTpOe4st8ya1AZ463ptm+nN6YEhVA3rsMAJjmSlkyn9ZYb1RjJHUoP sfw5bzbrjo4ts14HeVIiwhihFJ+y3VrDyAnbKU7u8K9fR/MKQ6crCheZBEampDiqYy1p 8MHxJx9fEFbOfyde6R1HX/X121U0LIeohKpuMGOIJqLJl8GIouu8ZHs5Eop63/Hlg0q5 UyaK5+sV/Fw4f+/uOv0X3BrLiSlyLZ7hSPRojRIRJPs1WmdoJeMkN0rUBiYd7omuDIIR PA9cHTHpj+o32PV6nbxhkz7ziOrvWF3DTUsF4HrlwJP38eR6k6hxtrQcRdzgoaMkMQK1 Ogkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=xcXD0EO9Jz+j4gRv0cy1vygMGkbjnt6rzC6B0RJbBuw=; b=HH1b3PpoCgIFCO667R8Z0ZmMaazrLKs0+mTV+3MGOK1f4zfV3UBDZdg65hdFGMyaFn eWHR/BVzOMJhvKY6I63bhw9tzOaQSLCaLX9SHyW/Fm68pM4NBFgYcwwwXcvUIvhHAdYs z0AA1cy3hUwME81zXIqkalm8qI9Tgta+CiNc3uCGffKksn5ZEwRoON7qTBCj5BehoxM/ VFvifubqEprLPZhqZT+/04odF61MCqP2AUFH+orDqWXm42zOxrnnY49q28lvj7O2tQ+0 hWADRqYe3c4rtgybmkZL06g1PfHt78DkJDKRh6jZzmX1cWCfrlvtyX2zSVwjLg7HJeli WNvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p24si3519482ejy.672.2021.02.18.03.30.50; Thu, 18 Feb 2021 03:31:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232002AbhBRL3S (ORCPT + 99 others); Thu, 18 Feb 2021 06:29:18 -0500 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:37560 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232615AbhBRKLA (ORCPT ); Thu, 18 Feb 2021 05:11:00 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R971e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UOtCp5d_1613643012; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UOtCp5d_1613643012) by smtp.aliyun-inc.com(127.0.0.1); Thu, 18 Feb 2021 18:10:16 +0800 From: Jiapeng Chong To: mingo@redhat.com Cc: peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] sched/fair: Use true and false for bool variable Date: Thu, 18 Feb 2021 18:10:11 +0800 Message-Id: <1613643011-114108-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./kernel/sched/fair.c:9504:9-10: WARNING: return of 0/1 in function 'voluntary_active_balance' with return type bool. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- kernel/sched/fair.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 04a3ce2..cf78337 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9501,7 +9501,7 @@ static struct rq *find_busiest_queue(struct lb_env *env, struct sched_domain *sd = env->sd; if (asym_active_balance(env)) - return 1; + return true; /* * The dst_cpu is idle and the src_cpu CPU has only 1 CFS task. @@ -9513,13 +9513,13 @@ static struct rq *find_busiest_queue(struct lb_env *env, (env->src_rq->cfs.h_nr_running == 1)) { if ((check_cpu_capacity(env->src_rq, sd)) && (capacity_of(env->src_cpu)*sd->imbalance_pct < capacity_of(env->dst_cpu)*100)) - return 1; + return true; } if (env->migration_type == migrate_misfit) - return 1; + return true; - return 0; + return false; } static int need_active_balance(struct lb_env *env) -- 1.8.3.1