Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] misc/pvpanic: Export module FDT device table
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
References: <20210218094024.69354-1-shile.zhang@linux.alibaba.com>
 <YC46tZLAesfSNg40@kroah.com>
From:   Shile Zhang <shile.zhang@linux.alibaba.com>
Message-ID: <9dc35ee1-cf67-e434-c641-d2822ad0f6a7@linux.alibaba.com>
Date:   Thu, 18 Feb 2021 18:51:08 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <YC46tZLAesfSNg40@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/2/18 18:00, Greg Kroah-Hartman wrote:
> On Thu, Feb 18, 2021 at 05:40:24PM +0800, Shile Zhang wrote:
>> Export the module FDT device table to ensure the FDT compatible strings
>> are listed in the module alias. This help the pvpanic driver can be
>> loaded on boot automatically not only the ACPI device, but also the FDT
>> device.
>>
>> Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
>> ---
>>   drivers/misc/pvpanic.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
>> index 41cab297d66e..2356d621967e 100644
>> --- a/drivers/misc/pvpanic.c
>> +++ b/drivers/misc/pvpanic.c
>> @@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
>>   	{ .compatible = "qemu,pvpanic-mmio", },
>>   	{}
>>   };
>> +MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
> 
> What caused this to not work properly?  I.e. should there be a "Fixes:"
> tag in the commit changelog as well?

Sorry, I think it should be:

Fixes: 46f934c9a12fc ("misc/pvpanic: add support to get pvpanic device 
info FDT")

Shall I sent v2 with this update?

Thanks!

> 
> thanks,
> 
> greg k-h
>