Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7219350pxb; Thu, 18 Feb 2021 04:52:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzpeBzN0yrqg69OweWCdccAL8PILxe7lf6PBkKT/WeQnah0PszE0Fkh+RlOTd5SL12Vm+fq X-Received: by 2002:a17:906:33db:: with SMTP id w27mr3732088eja.195.1613652768743; Thu, 18 Feb 2021 04:52:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613652768; cv=none; d=google.com; s=arc-20160816; b=OOOfyYd0aUL4FoHuvSevj8l+s8SleTZPG7YRSEpQSx4XCau34ZXScPOp8mzIvRfYg9 i3EXNczPJ9IiCKNbyAhiLRLe0WZNQ38nxBskRuWPUnpQNdIZ15GEBhIy6rzZVJQBDvoX 3qy0wTrt4ZpEZoNyBDPvKpkD7HzrtfG7eYogtaFU0/MAqc/jzz6JF0pLn8AlpMSOeLWO Kcq6r6q+qDr56zpHzMXNrwZv4JYoQ9g6MFspmfeoSAqcZQQiEWMnmSpLAp9kESniMTJG UImeP6CK/LNoXs8uZo0TsjVRzL6sn9ncwMhq2gJRLwoTem704FLQ7Ib9jUIcq2hfpbVa 7c7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=u+EbeWY0kC8yKqPJItRN34NJeUG7sw3ukrKrK2+AkTs=; b=Mc/pOLLp2HCcmeRtI/uWNG7DAzTS7mKdcHBvv7t9cY2D0DcfKD1whHECdOAH79pnfq DOb/jjrGF/bXvQI0DmUXjCSkcBfQpA+87sn1vPh07Oqc5ZpQeJof2aFPJwP+yoc0xCLN CkpGIfOKviPqAdzcZoGXTRU/azbUVJT9nAwXyuwX0Jlg61dSx8GCJJpu9uTQQOXtv7cc JqltsxJzp1eTN1weCekrChKuRPThxW+3WdFi2Dtzup+AcjhicaDgBtdAaJJulP3jOWXc cYN+IFT3Fcg8k2G+dQeZdZrcO5PKNCtIZCfGTXOwSd2wOZ5NjRbrWPIIs8l2Iw+cPfDM OAsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=EgOO2Lbi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g9si3720706ejj.456.2021.02.18.04.52.24; Thu, 18 Feb 2021 04:52:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=EgOO2Lbi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233274AbhBRMuV (ORCPT + 99 others); Thu, 18 Feb 2021 07:50:21 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:37338 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232387AbhBRKze (ORCPT ); Thu, 18 Feb 2021 05:55:34 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11IAosOx086946; Thu, 18 Feb 2021 10:54:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=u+EbeWY0kC8yKqPJItRN34NJeUG7sw3ukrKrK2+AkTs=; b=EgOO2Lbi1r9oydC78SZADWrrncDu6rXN8Sdfy/IAoWF/lig4EHku9CJ0b+PLv0MtowBK J1qNK5QoMf60oUQzRs3q0/zGvexsq8X5mARzjYxmD8H1QHleptKmxy20mSMF/sIcJpN8 PiA7X0042KbGj1/zDRlKKXgMl9JwVYgxAvDz7b9FWLu4Z1E3JFH+AR8IsYEiHMBr/zin Sv7rBWOdvEaMSUKMNObUng7AI3qm7mLUb4Owbj+cNm//xwe2hHNLpNzDxi8jD9U9Vw1C 3C6VHDqb8l0M+dvevSoIujhBXMLs4B2FRh0czxJuyw3ykgJPTYB1CI21a7IoIkV6gWxd jw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 36p49bdpf0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Feb 2021 10:54:14 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11IAkQAJ188535; Thu, 18 Feb 2021 10:54:13 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 36prbqm72c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Feb 2021 10:54:13 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 11IAs9TV015168; Thu, 18 Feb 2021 10:54:09 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 18 Feb 2021 02:54:08 -0800 Date: Thu, 18 Feb 2021 13:53:52 +0300 From: Dan Carpenter To: Benjamin Gaignard Cc: ezequiel@collabora.com, p.zabel@pengutronix.de, mchehab@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@siol.net, krzk@kernel.org, shengjiu.wang@nxp.com, adrian.ratiu@collabora.com, aisheng.dong@nxp.com, peng.fan@nxp.com, Anson.Huang@nxp.com, hverkuil-cisco@xs4all.nl, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH v1 06/18] media: hantro: Make sure that ctx->codex_ops is set Message-ID: <20210218105352.GE2087@kadam> References: <20210217080306.157876-1-benjamin.gaignard@collabora.com> <20210217080306.157876-7-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210217080306.157876-7-benjamin.gaignard@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9898 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102180095 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9898 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 phishscore=0 clxscore=1015 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102180095 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2021 at 09:02:54AM +0100, Benjamin Gaignard wrote: > Do not try to call ctx->codec_ops->done if ctx->codec_ops is not set. > When you're writing a patch like this please say in the commit message if this can happen or not. Option 1: Option 1: sometimes this is NULL in Option 2: this can't be NULL, but we are planning to allow that. Option 3: I don't know if this can be NULL but do it for consistency As we review and packport patches we have to figure out why you are adding NULL checks so it really helps if you just tell us. regards, dan carpenter