Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7226009pxb; Thu, 18 Feb 2021 05:03:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJx9C6z9C7fzxtnoA4/70wjlFUn2L8/01iEaY2Rslh1pDZVg4n5Ofjbahxxl7MexDeRQqpXS X-Received: by 2002:a17:906:564f:: with SMTP id v15mr3927877ejr.31.1613653395536; Thu, 18 Feb 2021 05:03:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613653395; cv=none; d=google.com; s=arc-20160816; b=wmAFTvBS1c0ih2+AiuL6qwPGXo9le+nQNUNAiJhecEpKJ80FtlLQno3cl/YHH6opgV J4LqueH7Z2YbfqpCMcFw/xz9t7Lsf1YyJSA0bh6wcArKG34+bUU8YC/d7F1yemTQlxbX CK95HVj8wjZWPuO5q58Ki7Y16mbvYJWTkCfeKh1gWErPBxicwyG1fB3F0O6ddp0Sd0Um HhSZWjxEvkn27SlmhFbk6tlsxe7N+pAje6SvXNdVwr4KrpDkEKVok9ieaDkF0bT02RaO NATogX0i7l1wChqfunfTfywsuoIKTmfPku8FsxLfFCkGdNhlbYwfC6dwA5bKG4mJwSM5 lnUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sHWzYpmgHKT+8RL/bSuylxH66VLPMwZFU5Pzml9yfAk=; b=yV0IymeOG4bgEZ8zk44QKOOBRwcOlfyTRHePwJILNtYcXjt0pZ6uWjKmsJXlv8MucP 6YZ6qkO905OtqEayeXlugHtI8WiO4xTTG/qP9/EeKn2RrdtMFZJ5aoe894brbP76V4bC iRc4vBqvQ+++lPz4H2T5XRsja7du5mZ9Q1c2M3268Gx3yFfnl5Mp9KCgR3lj0Be+e2nU jP1ypZitAUHYJFA8V1OiKBnV1YSA+czhnGoiCH1koqXGZOwGvkGk9E9ygus4TS4JuOgm ZZ9xhTmFpWqg5eFy7CHJtDZEiMHh8ulbuEliTYoC7mVooqSke76RzIZMeIdo1xZUnTAh XE7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=C2vpF0CA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g19si1057714ejr.741.2021.02.18.05.02.51; Thu, 18 Feb 2021 05:03:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=C2vpF0CA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232410AbhBRM5J (ORCPT + 99 others); Thu, 18 Feb 2021 07:57:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232480AbhBRLOd (ORCPT ); Thu, 18 Feb 2021 06:14:33 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAD03C061756 for ; Thu, 18 Feb 2021 03:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sHWzYpmgHKT+8RL/bSuylxH66VLPMwZFU5Pzml9yfAk=; b=C2vpF0CAJapIgOcErz0BoOW4Wv mZRfuvBmI++LZYBsZZDin/iqbMYeyV4MKtOa1Uuoir+HSSBh8QOKEay6CqYxbzGhBv6C9aC+WiiKq 0UeEF/smsycn1FgnaH/uUo2Q1fP+PSJUoSMdsa7EGYSqHM/5W8GkrO6eVMoxNTvkDcNp9bZojnELl 53s46zlLtYPv/xN44yNOn2BKbr+6lRpD0eTB8j9xa8CM7dpPomFpMHpKsRcVGtkQm/+jmxUYivsvz ZpJJlRp26p3JTKUcsT5jsUjkgkCrQO84oOmtdTbnAYrUCIhh9kEtPqH+OdILBT5qCzdD/xRDl0qwl 9QlY0SjA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1lChEU-0007wk-9W; Thu, 18 Feb 2021 11:12:30 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 522179814E2; Thu, 18 Feb 2021 12:12:28 +0100 (CET) Date: Thu, 18 Feb 2021 12:12:28 +0100 From: Peter Zijlstra To: Nadav Amit Cc: Christoph Hellwig , Thomas Gleixner , LKML , Andy Lutomirski , Dave Hansen , Rik van Riel , Josh Poimboeuf Subject: Re: [PATCH v5 1/8] smp: Run functions concurrently in smp_call_function_many_cond() Message-ID: <20210218111228.GG4348@worktop.programming.kicks-ass.net> References: <20210209221653.614098-1-namit@vmware.com> <20210209221653.614098-2-namit@vmware.com> <20210218080929.GA335524@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 09:36:09AM +0000, Nadav Amit wrote: > I prefer to export on_each_cpu_cond_mask() and instead turn the users > (on_each_cpu(), on_each_cpu_mask() and on_each_cpu_cond()) into inline > functions in smp.h. That makes it impossible (barring LTO) for the compiler to do constant propagation on the cond and mask thingies.