Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7396581pxb; Thu, 18 Feb 2021 09:01:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxaBhWvG2KQxIMjnAKPDC3BMRWgXco9P1qG+umrb5BYvboESsK5xFbEk5kDhyPskw6n2sLs X-Received: by 2002:a17:906:5902:: with SMTP id h2mr4785371ejq.137.1613667712995; Thu, 18 Feb 2021 09:01:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613667712; cv=none; d=google.com; s=arc-20160816; b=yV98LxoHefvrFsIoY1pfWJeMC26Uz0vZL85+l/0CjbdyLLYenZNkmXMGZNg4sxPrUN P0O0SG0kc0cOFg9AfRCoHZv7mb80laM7BjqfuHkWSQx7sdepXPk1RBk/Cfu1NJ0RSm21 UbLRPDWDjDsjsjwEZz3UeCd+f0DmFvJJcte/y2PerYUR6PBFGyJWMoOFcVMiYM+zvfKg Cmd2E0sBz8/BuQX8CyjB/klmOkpwZVhN+/tTG8PV2uS+pJI9LgoQpGPOEu2Cn/aFGXtk srGNu1Y9da+yDZuic9fD1FhZX5bNABH7HY/LKh2iXbdTr+I8QzsmI1vhAFGcYqiMuDjT NNDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/9k5TLG+cSQGO44XklxxRtkxrKg7GM556fliUBGzq6o=; b=Jkf1CwGVToeqIMA5TpSIAmgatBBfhP4IyMvMVS5fqEAI7vIgTUghic7B1otELHXg61 rKQP4RueW5K53hcj3FABd4pW2EY59ncu+ZTFBPrjUhxNCp7px0Nc0LFcb6/9n69nYESO 473QubkLeRdeMYNsFmEJqSAvdF+TC7nDZctoOPtQauXbFriw6m2yadVv1xwxV0Ermgv3 t6yD8F3WwlVoZloxvwJTVMm3ge0YyGC7H+Lvt6RDAGnWPmgPC67mihNgouQF7RobV+2N DU+GjoIfPlK1RWQaEu8Hy9e+DfwiHuBN+ZgLhJT/S5c3Rvwllfp2Kj4SiO+NxqIrNBR2 d5eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CtLo4NL2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k8si4267909ejv.305.2021.02.18.09.01.27; Thu, 18 Feb 2021 09:01:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CtLo4NL2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234144AbhBRQ60 (ORCPT + 99 others); Thu, 18 Feb 2021 11:58:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233571AbhBRONC (ORCPT ); Thu, 18 Feb 2021 09:13:02 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFEF8C061574 for ; Thu, 18 Feb 2021 06:12:21 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id j12so1355658pfj.12 for ; Thu, 18 Feb 2021 06:12:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/9k5TLG+cSQGO44XklxxRtkxrKg7GM556fliUBGzq6o=; b=CtLo4NL2MqVEC59LE/m04PNwUtXe4pxcA5F5xZ3wVpEC3BuHCeHYBfjX7urIcacvAQ gN/APFPgl/JRtm/T7L+viVjD5ifJbNFrAjZfYPMtr/kpTTElXovfD5Gh+B1tjQ6YxeM8 dssckpv2fPSvb7lYDHFmmK2Dq6OvN7w7TrlIbeCRchVhtbGSxYmEgsGbHzYSVNiGBhai W5wdRxxh2oD2VUrytfL2wnwRn11y+YjZ3tjGWAhZPandTw/oxZVkz1HV/gbL9nTHl1SF Dh2zcl7uS9i2Wh7bFkykkmPoW6QHsFbvJqSmi0DLLJuWfJMVr/QXFvlTzs2XaYpcx+CS 8nDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/9k5TLG+cSQGO44XklxxRtkxrKg7GM556fliUBGzq6o=; b=OhZdf0nKquouHKX7y3rZNgEINkpfchbZ9oD/8c5oYI2P0TzU3dS6/w8NaH1dQsksT2 9dEWQZ5lyQNgOxjiAuNGePU97g341wYHb77JvtUe3eEU20MOHx3iMT+l0PUrnSCX2zw8 +DuccDHsmVmMWwgvnthCyKh0Nr9HZsMuox48bJo8HY9SrTGkskwMhagvIuennyVEIIf5 AvdGa2RpXjdSQY3y47ggsPJd0BCNB/Z0dOkMrHe46twWCcFXPuBMNS396RlsrzcZK79P N8D422PS626a3YQ1+3r1lwQ6suz9/pSyPQnIfsCOj/sXFqQ0pdG2zGt6F3VxSuuMFAqa zojA== X-Gm-Message-State: AOAM532AyCeSQSpsPbuJduXONTSnwy9ZzQ5zjCYJUBAvKJiWOwWmPu1n 0xZoQaGROQNsbdY6XT3LEUA= X-Received: by 2002:aa7:8d0d:0:b029:1d7:3c52:e1f6 with SMTP id j13-20020aa78d0d0000b02901d73c52e1f6mr4604555pfe.39.1613657541296; Thu, 18 Feb 2021 06:12:21 -0800 (PST) Received: from atulu-ubuntu ([106.200.12.70]) by smtp.gmail.com with ESMTPSA id q196sm6850635pfc.162.2021.02.18.06.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 06:12:21 -0800 (PST) Date: Thu, 18 Feb 2021 19:42:15 +0530 From: Atul Gopinathan To: Greg KH Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type Message-ID: <20210218141215.GB2022@atulu-ubuntu> References: <20210218084404.16591-1-atulgopinathan@gmail.com> <8f73b7a1-02dd-32ef-8115-ad0f38868692@mev.co.uk> <20210218104755.GA7571@atulu-nitro> <20210218125220.GA19456@atulu-nitro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 02:46:48PM +0100, Greg KH wrote: > On Thu, Feb 18, 2021 at 06:22:20PM +0530, Atul Gopinathan wrote: > > On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote: > > > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote: > > > > On Thu, Feb 18, 2021 at 10:31:15AM +0000, Ian Abbott wrote: > > > > > On 18/02/2021 08:44, Atul Gopinathan wrote: > > > > > > Fix the following warning generated by sparse: > > > > > > > > > > > > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in assignment (different address spaces) > > > > > > drivers/staging//comedi/comedi_fops.c:2956:23: expected unsigned int *chanlist > > > > > > drivers/staging//comedi/comedi_fops.c:2956:23: got void [noderef] * > > > > > > > > > > > > compat_ptr() has a return type of "void __user *" > > > > > > as defined in "include/linux/compat.h" > > > > > > > > > > > > cmd->chanlist is of type "unsigned int *" as defined > > > > > > in drivers/staging/comedi/comedi.h" in struct > > > > > > comedi_cmd. > > > > > > > > > > > > Signed-off-by: Atul Gopinathan > > > > > > --- > > > > > > drivers/staging/comedi/comedi_fops.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > > > > > > index e85a99b68f31..fc4ec38012b4 100644 > > > > > > --- a/drivers/staging/comedi/comedi_fops.c > > > > > > +++ b/drivers/staging/comedi/comedi_fops.c > > > > > > @@ -2953,7 +2953,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd, > > > > > > cmd->scan_end_arg = v32.scan_end_arg; > > > > > > cmd->stop_src = v32.stop_src; > > > > > > cmd->stop_arg = v32.stop_arg; > > > > > > - cmd->chanlist = compat_ptr(v32.chanlist); > > > > > > + cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist); > > > > > > cmd->chanlist_len = v32.chanlist_len; > > > > > > cmd->data = compat_ptr(v32.data); > > > > > > cmd->data_len = v32.data_len; > > > > > > > > > > > > > > > > This patch and the other one in your series clash with commit 9d5d041eebe3 > > > > > ("staging: comedi: comedi_fops.c: added casts to get rid of sparse > > > > > warnings") by B K Karthik. > > > > > > > > Oh I see. Not sure if this is the right place to ask, but which tree and > > > > branch should one work with when messing with the code in staging/ > > > > directory? (wanted to avoid such clashes in future) > > > > > > staging-next is the best one to use from the staging.git tree. But as > > > the above commit was merged in 5.9-rc1, way back in July of last year, I > > > have no idea what tree you are currently using to not hit that... > > > > I'm using the staging tree alright, cloned it yesterday. Except I used the > > --depth parameter. I believe that is the culprit. How bad a mistake is > > that? > > I do not know, I do not use that option, sorry. > > > (Why depth? I'm currently staying in a remote area where internet > > download speeds are less than 100Kbps. I tried a normal git clone of > > the staging tree and it's estimated time was more than half a day. Not > > to mention, it fails due to loss of connection midway every time) > > If you already have a copy of the kernel git tree, there is never a need > to download the whole thing again. Just add another remote banch and do > a pull, the difference should be very tiny now compared to what is in > Linus's tree. > > Or, to seed the whole thing, download a "git bundle" as described here: > https://www.kernel.org/best-way-to-do-linux-clones-for-your-ci.html > which you can use to work off of locally, and should be easier to handle > over slow and flaky download connections. > > hope this helps, Oh this is great! Will definitely help me. Thanks a lot! Regards, Atul