Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7434305pxb; Thu, 18 Feb 2021 09:57:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9V3GuBnThbnohhndyccPoUOaPJzf70AtbWrzt1qdag0bOurW4YTuT/vXb1LR6vHh2Qvlj X-Received: by 2002:aa7:dd4c:: with SMTP id o12mr5131007edw.180.1613671026680; Thu, 18 Feb 2021 09:57:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613671026; cv=none; d=google.com; s=arc-20160816; b=j3FCDSe0UVFZUIC2e+DP1ZB2zDMmlS+sC53Hyozjzoed5TbLuw8hU+w3lVyvg3MUKo a51M7Tqs05b6Ss9w9A4XKNkkboq0LQlQNrjV1nyyzIHnGpIi9IagVsc6j0s1UapcMwEQ YJA5fVM9ze+t5gurIqdo1rHhJ1Ck170pYseWZUPdR04zCg1P7uzy2UgAfCkGcHVAAL/A fz0xuak7KP3ezac3jIbcXm7dMwLxbWui4NBsk+Zb+00UF6URL5g2LUwBssefA2a8R7nf WVmBOIm7Lof5bl23AbXFJs4isFS9XAOmFgydq79gxiPVEa9X3yH9X3L3Bpos7KoK6vBl KKtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=egGZTevWS9XGPb3i0ABiHZIAsAw10Vof+gwW4ybtKxc=; b=HBxPd0KvzxuM770QhDVa66gtybq2apL/2YRQMsZTMIGFyqU8cJ4Ex3BkWCYRPzU8Ea ybBfP2S6ILNsLPikCLKOTtsfkJLUyGKaeBg6WD07ewftYK++ZfGtEr12yJSB+OsVkgpV QBYgZhwqwV883bh5PSxt+lOI2lPD2KfilKAIYZEzVmPm154JP8eZLXGAOqPj5XyMie3R 6/RHVx7NM7Ai9CELHNEkPfey4kVVgPtyZiHBzRVRDuFaX3bsZajuXNJWDn7jsftG4mMS ni7dffUIBylG8v+Ks7ZK2KZ2nGOgmcajs17Jb39lf3sKde1U0zKWgjxDf/3yXrPcFIcs dYJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iyWwNGi8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lb13si3875212ejc.423.2021.02.18.09.56.42; Thu, 18 Feb 2021 09:57:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iyWwNGi8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234846AbhBRRyJ (ORCPT + 99 others); Thu, 18 Feb 2021 12:54:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbhBRPJY (ORCPT ); Thu, 18 Feb 2021 10:09:24 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 756EBC06178C; Thu, 18 Feb 2021 07:08:22 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id z68so1336620pgz.0; Thu, 18 Feb 2021 07:08:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=egGZTevWS9XGPb3i0ABiHZIAsAw10Vof+gwW4ybtKxc=; b=iyWwNGi8FIEgpgnK1hUDSXo6IG2oL2TsczdBEdFtsBa7jDTG1BlBAK2fVaggR4MaX1 JniomodCnubVGqED+0E7iEvBfSo7LPr9JgZidAJRdI7kOUJTZCojyYSU6kFBK1XZDugx xpAflkmZYkAaTXC9CtgxIUza54Cbl0YbmMAdAsHQ2haIqEg4U4rXjFZXuH8VaXJ1WLpS xWVitG1whZ4zqZ/ZOCzN9UoWp8B64a9BKPcREs65kgL6zwvf/Y4avz6c8cXTHkwBRm8u EWWJxq8URmFkDr6zu6C+JbsHW2aUJmJ5jHnvb+kxWf20wqoBzbE1AtkG9kH6Kb0puIdv PSPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=egGZTevWS9XGPb3i0ABiHZIAsAw10Vof+gwW4ybtKxc=; b=OzpauNDZFrjy1BboBg5uwZkZOst3s5dIUjVuJf++8yi9tgJPSpT3tMQxa4IDfOw8Kc Y5XtnaI9t8RC1yL9QUsDezR0qrYIXbt0210fikQrc7LqqwXgCcZRgKaCLUxGa2JEbU/l 7DPvH8NGdallbebFd/qJBpEbrVzvsoeOlbGlrquf+ZiSUcL1szmsFBvArMA4cxqwZ+71 HdL5zDcvX0Sx71dn6Zgvvx36y5uKFKHdTbd+8XPsCYHc7C5IxlMn+KEPOR4AdqEUInae Sj04+VJQScu4MONpi45HKEE6kCPFSfbDNsjSlEpJ7jEwZaDO9ZAy94xPMZwbBGEbYCn6 DJtg== X-Gm-Message-State: AOAM531eQRtp6LGonQw7i7rMaL4hUewbHbysHc8lfJ0g9x2XvGYLWYAS gW1ILa9wsdOKQ1LNcnd98g/afnP9qb1RqekbPRw= X-Received: by 2002:a65:4c08:: with SMTP id u8mr4291801pgq.203.1613660901928; Thu, 18 Feb 2021 07:08:21 -0800 (PST) MIME-Version: 1.0 References: <20210218052654.28995-1-calvin.johnson@oss.nxp.com> <20210218052654.28995-11-calvin.johnson@oss.nxp.com> In-Reply-To: <20210218052654.28995-11-calvin.johnson@oss.nxp.com> From: Andy Shevchenko Date: Thu, 18 Feb 2021 17:08:05 +0200 Message-ID: Subject: Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Linux Kernel Mailing List , netdev , ACPI Devel Maling List , Laurentiu Tudor , Diana Madalina Craciun , linux-arm Mailing List , "linux.cj" , "David S. Miller" , Heiner Kallweit , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson wrote: > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > each ACPI child node. > +#include > +#include Perhaps it's better to provide the headers that this file is direct user of, i.e. bits.h dev_printk.h module.h types.h The rest seems fine because they are guaranteed to be included by acpi.h (IIUC about fwnode API and acpi_mdio includes MDIO PHY APIs). -- With Best Regards, Andy Shevchenko