Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7441835pxb; Thu, 18 Feb 2021 10:07:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxl5WnpZT6uzmrWc7jmmvVZ8EBNw2iWjmUa3ZGLgBnyPooq79w35pBMsYK+5EeH+7+ulrVF X-Received: by 2002:a17:906:780b:: with SMTP id u11mr5174883ejm.492.1613671643135; Thu, 18 Feb 2021 10:07:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613671643; cv=none; d=google.com; s=arc-20160816; b=oahB+Ax5gC3x/PIFCWSemm3Q7PFdKWoG3CE7yVKclrQ1If8uD+XusRctd5dVei0UZJ uESV/CYBm+cDAE/cQO4YL4vSwGuH4ZilhT7Y8iaB3c2Zyd+j5HtwV1TgF6Xyshk7vmbG yLr7SC8aTNT3NlE1QbKhZ4icZ2EVyI+RUwrDGXXCMixWurCF3RlrrM9O8eGuyhuyKiZi NFvyq4a6KC1UQcdk+5H+Q/Ogr1fTAYROdxehHcFG9VK2d84R3sKJoLE7I0W2PlZ0sdBz C2Y6UbulGgTHD7utxu0uLixrBV4NQZ9Q3q5YWwzpn5u+XiROHbb9EvVgk5dVgYLbDAua uIZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=Fx0nvprBWbK3U+pHSTpnn6osS1WlaYhDzGoozfd5Ow8=; b=sEFQh4vSVF7DSINlk0v4nDev2uVokZPfsIir3xs6sV+ECgLke+in1dR0dEMQGdnBVO VYLjGfkfNrLAnghHit8hmKQXSgpjZI3R0zk4YDAIbFHbohBVwbdLcxhZ+J2CO75qIjcm hXNc6oG1tatV29X703USTJsaYP3jcT1NbfpQkDw4hqUbh4rMqSniRMgtA3imckGLhuyu LEzRD3kX+uOpC39dhRGLn/BvMNo7AsGK16+tZI+1W0r86WK9R39aaWKPO3Lxpzo4iXRz sKr/H0z0BUZ6uH/LaYCeB6Ke8ksAofjwtxzU1rucPiL6zE74o9yPxr0WYbCM9P/1qiFb VL7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e29si617925edc.590.2021.02.18.10.06.51; Thu, 18 Feb 2021 10:07:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbhBRSGP (ORCPT + 99 others); Thu, 18 Feb 2021 13:06:15 -0500 Received: from mga18.intel.com ([134.134.136.126]:18621 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232542AbhBRPeA (ORCPT ); Thu, 18 Feb 2021 10:34:00 -0500 IronPort-SDR: TYH1bw/ke9QgGSz/ZoIBv+22EiVWqgEgUDUeHJuNym9V4oOyFg4f3xFq1HDFPmewzfbHJlSQTD pi5gQAw+mdsw== X-IronPort-AV: E=McAfee;i="6000,8403,9898"; a="171205920" X-IronPort-AV: E=Sophos;i="5.81,187,1610438400"; d="scan'208";a="171205920" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2021 07:31:56 -0800 IronPort-SDR: OouBEYarPuLAOdmgvJYlFPhxnKNIZH9nHQGGiQmc7dbK12MVbrWm8kF8ENYlPbTu8HmlXwGg1r AZ2p00thMFwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,187,1610438400"; d="scan'208";a="385998262" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga008.fm.intel.com with SMTP; 18 Feb 2021 07:31:51 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 18 Feb 2021 17:31:51 +0200 Date: Thu, 18 Feb 2021 17:31:51 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: lyude@redhat.com, Rodrigo Vivi , David Airlie , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Lucas De Marchi , open list , dri-devel@lists.freedesktop.org, greg.depoire@gmail.com, Sean Paul , Thomas Zimmermann , Dave Airlie Subject: Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers Message-ID: References: <20210208233902.1289693-1-lyude@redhat.com> <20210208233902.1289693-11-lyude@redhat.com> <20210211041540.GI82362@intel.com> <355ce12ec69a9b5f20b4a856a40c8abf413be5c0.camel@redhat.com> <87mtw1ai4m.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87mtw1ai4m.fsf@intel.com> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 10:35:05AM +0200, Jani Nikula wrote: > On Fri, 12 Feb 2021, Lyude Paul wrote: > > I think it wouldn't be a bad idea to just address this with a followup series > > instead and use the old DRM_DEBUG_* macros in the mean time. > > aux->dev is there, could also use dev_dbg et al. in the mean time. They > handle NULL dev gracefully too if the driver didn't set that. Last I looked aux->dev was random. Some drivers point it at the connector vs. some at the the pci/platform device. -- Ville Syrj?l? Intel