Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Subject: Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag
 BPF_F_ADJ_ROOM_ENCAP_L2_ETH
From:   =?utf-8?B?6buE5a2m5qOu?= <hxseverything@gmail.com>
In-Reply-To: <29b5395f-daff-99f2-4a4b-6d462623a9fe@iogearbox.net>
Date:   Fri, 19 Feb 2021 00:35:44 +0800
Cc:     Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Miller <davem@davemloft.net>, bpf <bpf@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Willem de Bruijn <willemb@google.com>,
        chengzhiyong <chengzhiyong@kuaishou.com>,
        wangli <wangli09@kuaishou.com>,
        Alan Maguire <alan.maguire@oracle.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B016D7B9-A347-4105-AA03-33713FDD2427@gmail.com>
References: <20210210065925.22614-1-hxseverything@gmail.com>
 <CAF=yD-LLzAheej1upLdBOeJc9d0RUXMrL9f9+QVC-4thj1EG5Q@mail.gmail.com>
 <29b5395f-daff-99f2-4a4b-6d462623a9fe@iogearbox.net>
To:     Daniel Borkmann <daniel@iogearbox.net>
Precedence: bulk

Thanks Daniel and Willem!

So sorry to reply to you late for I just took the Chinese Spring =
Festival vacation.

I will resubmit this patch.

Thanks again!

> 2021=E5=B9=B42=E6=9C=8811=E6=97=A5 =E4=B8=8B=E5=8D=8811:26=EF=BC=8CDanie=
l Borkmann <daniel@iogearbox.net> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> On 2/10/21 3:50 PM, Willem de Bruijn wrote:
>> On Wed, Feb 10, 2021 at 1:59 AM huangxuesen <hxseverything@gmail.com> =
wrote:
>>>=20
>>> From: huangxuesen <huangxuesen@kuaishou.com>
>>>=20
>>> bpf_skb_adjust_room sets the inner_protocol as skb->protocol for =
packets
>>> encapsulation. But that is not appropriate when pushing Ethernet =
header.
>>>=20
>>> Add an option to further specify encap L2 type and set the =
inner_protocol
>>> as ETH_P_TEB.
>>>=20
>>> Suggested-by: Willem de Bruijn <willemb@google.com>
>>> Signed-off-by: huangxuesen <huangxuesen@kuaishou.com>
>>> Signed-off-by: chengzhiyong <chengzhiyong@kuaishou.com>
>>> Signed-off-by: wangli <wangli09@kuaishou.com>
>> Thanks, this is exactly what I meant.
>> Acked-by: Willem de Bruijn <willemb@google.com>
>> One small point regarding Signed-off-by: It is customary to =
capitalize
>> family and given names.
>=20
> +1, huangxuesen, would be great if you could resubmit with capitalized =
names in
> your SoB as well as =46rom (both seem affected).
>=20
> Thanks,
> Daniel