Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7475369pxb; Thu, 18 Feb 2021 11:01:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrMHizap1XzsqUPwYicXW6HdF/iDTioa+Qnyn+NWNFjLtCiqaexkzpzhTpHyJZ9lR3dvFw X-Received: by 2002:a17:907:b08:: with SMTP id h8mr5400670ejl.165.1613674869920; Thu, 18 Feb 2021 11:01:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613674869; cv=none; d=google.com; s=arc-20160816; b=U8RiJgCZSdJyUlWDDufvuXjz09AL3J22u1A3OfCTnlzjw6YFeRpTr5Bj8NPJGGUrFx 7OVqqJfj9a+D3E9KsvYG2xh6XmRbftOz73WnqNHpLtR1hfgVKoRcOHuzWLpzD56rkB4Q 8kjN3fCby7ZGlPkneIVF4VhumwGHaD1S0T12JQsv8BsU2rg2yv+HYO7wS+0M8fUbwg0O mDTcIG3Lhn6rStp5eFXDMJnE308RgYZjkhhA+Wwc3mn/KiKaiR4lyf7wFzlXoKBGPC/B +xueUjzn4ATQclUv9UTE6nXSvjfT0ITTbSpLT81ubSQ6Th43yJnzEbtsPDN+jIHFeWmi 6mIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=X79/FL7O601ZV52yVZ6z02kzQq2OSMITFkO3ohwlxz0=; b=AKFT/I3STncqCw21v5IpYHOzklV3sLNzYWWw+YlTaxT3ipQZm6a+w7lgWRPsH3ekpG 7ysRYWJQkpnnLGz4i3j2zM/mAvT+PgF9+/ljiq9tXUoTLcV2qR/4m8Vdo53kK0v4rd99 uzAooIFIWMTE1eh/KmrVmzKud3iLqfMbOfiaQ5pt4CLN+l1Qw9mL+IixT4xrYtmPV2tz npXr62JZaTc3c4duYK06Rg7RY7rfxCyfUUDDvRHNKR8jgXZhNcGvti99DpqPh1IiggT3 xAkRuhtYqm7usbxQo0K4a+zilqBAicWxmxU8uaIOpYmHJsrCVDn7wuQg74JGFksidRRg n99w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B3uIqaD2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q3si4880062ejb.681.2021.02.18.11.00.43; Thu, 18 Feb 2021 11:01:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B3uIqaD2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbhBRS7i (ORCPT + 99 others); Thu, 18 Feb 2021 13:59:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233966AbhBRRR4 (ORCPT ); Thu, 18 Feb 2021 12:17:56 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78336C061786 for ; Thu, 18 Feb 2021 09:17:03 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id o16so1772932ljj.11 for ; Thu, 18 Feb 2021 09:17:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=X79/FL7O601ZV52yVZ6z02kzQq2OSMITFkO3ohwlxz0=; b=B3uIqaD28vR4iHEhLwxCN3xwylIe+uY6SaHqX0Xdf8ay4gUV0Q+4H/RYxHe+zkVTRs bZGMD0afv+Hw8bnFjOMBVYwmPKZqAEoQLP2bx9VA0bYA7hbaO5jZ+Gjupt/6GIOV7ZTD LHWbKey4NLZu3qI2vFvUOUVa9oRrcPfFQmmfybgE5anEWhygFtOcPWTkM5haWTR3IavM /dQnMD9Z7YeJDMB0M7c1TilPx7AOOJlh3QPRetB69WvT6VpTs/76CgsHuzuDNimKVguk 4SfaiSDk27mvwW0RK7gicuEm6Br5LKlBeUn7u+v4CSk7KA97CDOmZHP2Cxgq3SnYsQy4 sEpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=X79/FL7O601ZV52yVZ6z02kzQq2OSMITFkO3ohwlxz0=; b=ConW+7x9gOxAspeul4rk51GQmluCBLYuRAKrcZvZ/N3WV7djljUS6QVQCTut5dF2l4 S0u/i9XMRjQhKyLQn1hFWdKh9lL2Gwb2LErObuYsmDA+VdhWHQhgCL1odronleqLcBBc yBc/Sb3kXHFSnSbb84jAooajBdsDWrQm7nUl1oMZ4W/VrtSSAEOuCfHCeeFh4QNn9Sra 9cRh/BjIdgB5Ak37zTKnMRORahoR4hgEERyqMLJrQNTkYKqFzYE6R+nzf8VygLzbQe+D ORsNB6wCDuI+wSCRSrl80HfBDTfKAESRPvgrZ7fjrkGitsPaFLaytD/71tU/mCmq00LR GF1g== X-Gm-Message-State: AOAM530lDivrmRiblsglvpcs6zyPuHcyOrw4v9gYEpumxcLAcCWDKUjV 51QaKF29ghMMv3g/hW3MaKHfUQ== X-Received: by 2002:a05:6512:3607:: with SMTP id f7mr2813954lfs.245.1613668621899; Thu, 18 Feb 2021 09:17:01 -0800 (PST) Received: from localhost.localdomain ([85.249.43.69]) by smtp.googlemail.com with ESMTPSA id l19sm650670ljj.107.2021.02.18.09.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 09:17:01 -0800 (PST) From: Andrey Konovalov To: junak.pub@gmail.com, robert.foss@linaro.org, sakari.ailus@linux.intel.com Cc: todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org, laurent.pinchart@ideasonboard.com, jacopo@jmondi.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH v2.1 1/3] v4l: common: v4l2_get_link_freq: add printing a warning Date: Thu, 18 Feb 2021 20:16:40 +0300 Message-Id: <20210218171640.18764-1-andrey.konovalov@linaro.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Print a warning if V4L2_CID_LINK_FREQ control is not implemented. Signed-off-by: Andrey Konovalov Reviewed-by: Jacopo Mondi --- drivers/media/v4l2-core/v4l2-common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index 133d20e40f82..04af03285a20 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -469,6 +469,11 @@ s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul, return -ENOENT; freq = div_u64(v4l2_ctrl_g_ctrl_int64(ctrl) * mul, div); + + pr_warn("%s: Link frequency estimated using pixel rate: result might be inaccurate\n", + __func__); + pr_warn("%s: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver\n", + __func__); } return freq > 0 ? freq : -EINVAL; -- 2.17.1