Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        Davidlohr Bueso <dbueso@suse.de>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Oscar Salvador <osalvador@suse.de>,
        Joao Martins <joao.m.martins@oracle.com>,
        <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct
 assumption
Date:   Thu, 18 Feb 2021 12:27:58 -0500
Message-ID: <19612088-4856-4BE9-A731-BB903511F352@nvidia.com>
In-Reply-To: <20210218172500.GA4718@ziepe.ca>
References: <20210217184926.33567-1-mike.kravetz@oracle.com>
 <20210217110252.185c7f5cd5a87c3f7b0c0144@linux-foundation.org>
 <20210218144554.GS2858050@casper.infradead.org>
 <20210218172500.GA4718@ziepe.ca>
MIME-Version: 1.0
Content-Type: multipart/signed;
        boundary="=_MailMate_558FA73B-66C7-4EF3-8577-3AD3907969DF_=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk

--=_MailMate_558FA73B-66C7-4EF3-8577-3AD3907969DF_=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 18 Feb 2021, at 12:25, Jason Gunthorpe wrote:

> On Thu, Feb 18, 2021 at 02:45:54PM +0000, Matthew Wilcox wrote:
>> On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote:
>>> On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz <mike.kravetz@oracle.=
com> wrote:
>>>> page structs are not guaranteed to be contiguous for gigantic pages.=
  The
>>>
>>> June 2014.  That's a long lurk time for a bug.  I wonder if some late=
r
>>> commit revealed it.
>>
>> I would suggest that gigantic pages have not seen much use.  Certainly=

>> performance with Intel CPUs on benchmarks that I've been involved with=

>> showed lower performance with 1GB pages than with 2MB pages until quit=
e
>> recently.
>
> I suggested in another thread that maybe it is time to consider
> dropping this "feature"

You mean dropping gigantic page support in hugetlb?

>
> If it has been slightly broken for 7 years it seems a good bet it
> isn't actually being used.
>
> The cost to fix GUP to be compatible with this will hurt normal
> GUP performance - and again, that nobody has hit this bug in GUP
> further suggests the feature isn't used..

A easy fix might be to make gigantic hugetlb page depends on
CONFIG_SPARSEMEM_VMEMMAP, which guarantee all struct pages are contiguous=
=2E


=E2=80=94
Best Regards,
Yan Zi

--=_MailMate_558FA73B-66C7-4EF3-8577-3AD3907969DF_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmAuo54PHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqK/24QALC+b77e4YBi0DHXfoLMxqHcTGx4G5nnkWoH
jke0UQcm48KZ1zsNRUGaHLo7USjCjbwysuQEqfwOciYE5DwH5bHANtzqdu+MLd83
uilXzQzBuSG1ePUnFFKJSoEV8j8JQDaz+7wFpvn0ZlHgi7HSVHgMup+/s+uGxluO
5FiiYcwRuBjY3wApNCTc+UT908QwAGwKdY5RIDM6CWrVkYIsq7nobQA9F8JIeQ38
bSsdz043bLAMdd5Z/XZoNEBOhk++XGuzs+2C1WY0ptC0vgH/dCE0Vvoo8KV92u3O
MqKOBx518zeWjgRfvA7NuCn63wqHvhMHwSLiosg5Wa9dJ9Na70U0hX9065WvqU72
294yb7wv6GqidGNl0T97hSlagtmBER1zIYm3nZxsKNL9qCnHljTYvyQv+NFYuZcW
Y1tN5INvJwm5qrVju2YEGvC+8lo9RWKUlf8w6mpY55m6Ru/ERRmj6DesPNRr3pSY
ajbRJmCxaOZg3f3Vhy8l4E0WpJpWHJOH8LCvQ2EAFwhDiELmYB3ZXIqje2Cvzikn
MsD1fCzPKFb4UdcvFLhSt2ry8FboJ/LxLa2nXKWBFsONJe67yEa6TzZdkuBELcMN
pFfaOKb64PlNcarGmpTBkxolKP6/W+1oiZFNRnJoPvln+UArPFL0uu0NqK5B03Lc
aGUrtfH4
=mXEE
-----END PGP SIGNATURE-----

--=_MailMate_558FA73B-66C7-4EF3-8577-3AD3907969DF_=--