Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7497396pxb; Thu, 18 Feb 2021 11:36:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBk7YmxFBFXycafjryvbCBOIfksAjH937VdB8TN4KiPB9ZAIMGQ0dyctHNC4zPXyhdNnoH X-Received: by 2002:a17:906:1956:: with SMTP id b22mr5751784eje.114.1613677010074; Thu, 18 Feb 2021 11:36:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613677010; cv=none; d=google.com; s=arc-20160816; b=YJ6eeBGKbaE/R3nBt8edkykeoswRljep9kdkq0mPngOQkl8AdpoIhiFUX3t2qFKsZ/ iYZh8ak+mATRcJt/KWxppdTJfW3uVI4nip0tkzhsZy1eS38MSiVkJ4m7K9k/D0a3mK8+ 1Y6n52JdoT1RVtSDZ//n1gAr6yqb1YpFFanneHpvRlrDcoMMZ0kIzQ/6b8JDsFJ3TFDR PrvAZqwYNyhpYzMr/m6sW/zU3BTJHuvcNE0pMZGYx4vh6h1hzej6eoWt8Aoqv6g34jQU De/hfcjEQa2jVyKGNKXFgD9wu7YAePwDdIWuVIabof7UGb694vAN2fccFsDXMZWozH5Y I1sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from; bh=0us17+03ZS8bPo6AR4pvthgtsjOz0bajlkbM6Oz0K3U=; b=P8ASxuQbTAgAzakjeTmQajv1tvfhLHIyv8aS1pNYYH5VwpWQ64P+EzJw1EQIYgAYEp eHjOsYpsEnrJEFa/LjfnJ3H9qLW12HF/8h8paKKp0OfWM38LxO1RpDJqXInk9EMeMfYi p3dbjE5QxH1b6sbDuCbO0Em0JOiLJhrsxibWoCDiApCPbilxonwXevzcFQLPNgBHu1zV hcBbfJP2NhUgpXTPT2/fSZGzcnrF78xvEGOo9XmIZSIB1YT0fJuCCT3QeNiOfn595S60 sCQ4KaCONeVvheStKBCpt8v4okATIl8rZsX0Zg+BlWzjMKR+OFPnkpS1J8dZhy0HLT7V 2Ndg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x12si4315932ejf.85.2021.02.18.11.36.17; Thu, 18 Feb 2021 11:36:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232304AbhBRTdH (ORCPT + 99 others); Thu, 18 Feb 2021 14:33:07 -0500 Received: from foss.arm.com ([217.140.110.172]:54422 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233380AbhBRSwY (ORCPT ); Thu, 18 Feb 2021 13:52:24 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D7A21FB; Thu, 18 Feb 2021 10:51:37 -0800 (PST) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3957A3F694; Thu, 18 Feb 2021 10:51:36 -0800 (PST) From: Valentin Schneider To: Lingutla Chandrasekhar , linux-kernel@vger.kernel.org Cc: juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, pkondeti@codeaurora.org, peterz@infradead.org, mingo@kernel.org, Lingutla Chandrasekhar Subject: Re: [PATCH] sched/fair: Ignore percpu threads for imbalance pulls In-Reply-To: References: <20210217120854.1280-1-clingutla@codeaurora.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Thu, 18 Feb 2021 18:51:24 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/21 14:50, Valentin Schneider wrote: > @@ -7539,6 +7539,9 @@ int can_migrate_task(struct task_struct *p, struct lb_env *env) > if (throttled_lb_pair(task_group(p), env->src_cpu, env->dst_cpu)) > return 0; > > + if (kthread_is_per_cpu(p)) > + return 0; > + That's missing a (p->flags & PF_KTHREAD), but you get the idea...