Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7498183pxb; Thu, 18 Feb 2021 11:38:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMFEg5UbIHjbrroWhg8pB6kwNP860wrArBv0XIiWEiZld2X15o/3M5V4gSy//MoXLwa/sT X-Received: by 2002:a17:906:a090:: with SMTP id q16mr5480986ejy.236.1613677094338; Thu, 18 Feb 2021 11:38:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613677094; cv=none; d=google.com; s=arc-20160816; b=JrBwf46p9ugHibEXpgNNZvA7OgrFd/suvDbbOjoNbiP3ytprMs3Tv+x9quzE+yy73i Iqn9DKTdijWVzwjagYvlMzZYr/E197XGs6xKk4Xb4BsTr689zcxBj1MlulGP0ZbH7/1g OAHag8fmYoNB+w9dPwK/413NMR/VaUWIyc+SREDe2zbafRkwuU0RkvwwQBt7cG+3a468 En8RIGL0pvFUWS7QwPTa3h8ppEZ/b+SVnc706RhGcVlAS5DHec2qpbw+tsuSYcYX8RSy z1iKp0JhgiFgHP1Y5l/LpuUZsDpREhe1iGTuwRA29A4TLHMd8MxJVui5tiqK94eW5Wga EOxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=aScLxSMFu1zxbkIxPJ5NHuxrpAnb7rCOhFBPsUlhO4Y=; b=lg6IDs73nc7IJvmuV5TW7NckbHbB5dcQtxEc130q4I1idVU/GoDWQtG/RoA4K9ksyr V5YrRA7mx6SmEEdu6z1Tl7HA/xn+abCdFTk0iJ0UUIAVwwoiQbBrF5bopkpQA5HK6dz7 5unPHRPur+27PfXw20HH62A7kKU7iQidNTRCz0Rsj35RtmMSU8GjIijJuc/ftorzEGA1 FBbs2P1/0uMVvLFm0MRFh42rMz7rfQ7S1ftYqzkjk/V/siZ13LQSRklAQqS3YUY9KVAP GKhiz9nHqywy9sp4fheb7GCFcnBs9C/e3AIgwkKyxyOXW14a7lJHA+1SdF4FTU2Mt6+C mcaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=eChp5Wyz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qt10si3405711ejb.336.2021.02.18.11.37.50; Thu, 18 Feb 2021 11:38:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=eChp5Wyz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231248AbhBRThO (ORCPT + 99 others); Thu, 18 Feb 2021 14:37:14 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:37768 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233720AbhBRTFk (ORCPT ); Thu, 18 Feb 2021 14:05:40 -0500 Received: from mailhost.synopsys.com (mdc-mailhost2.synopsys.com [10.225.0.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 30A4DC00A1; Thu, 18 Feb 2021 19:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1613675068; bh=ihJyBFKL01a29YggVG9CNl6OEXj0a5ndJ0t7B8pMh6E=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=eChp5WyzOT8V2jTilL6b6lJSrYtZvYbu/bQATUyfGn2p4yZaPYo7Ke5qlz1k4zb2y 8VjiCxT1wua8W13RK3wQ5TFWh7CpcidCzqrEI4GXRvVkMOnNp9FXXeR/BcprN6R9h7 SyVSVWY4O3BD89O0sRpyTAi8p6XqSg6e/3dcpMecPLx4HkZ9wKBdziYNI/CxSpiO21 4Aln58kQ858QaPdheFpWjNfmd3dB4h/Aj8HZcdWSxsAWjxpHCdowKWlVydYhDRPhPe Y3UC1PI230q9yRL3mDANBbwok02JYHHMC6RVUMbVgIZA6QEtX6iHmAVfj9ulcbxpGQ tLksauah8vZLQ== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 02010A0063; Thu, 18 Feb 2021 19:04:27 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , Dan Williams , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Lukas Wunner , Gustavo Pimentel Subject: [PATCH v7 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver Date: Thu, 18 Feb 2021 20:04:06 +0100 Message-Id: <4aa850c035cf7ee488f1d3fb6dee0e37be0dce0a.1613674948.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c index bc94c8d..a26d0d5 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -986,22 +986,21 @@ int dw_edma_remove(struct dw_edma_chip *chip) /* Power management */ pm_runtime_disable(dev); + /* Deregister eDMA device */ + dma_async_device_unregister(&dw->wr_edma); list_for_each_entry_safe(chan, _chan, &dw->wr_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } + dma_async_device_unregister(&dw->rd_edma); list_for_each_entry_safe(chan, _chan, &dw->rd_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } - /* Deregister eDMA device */ - dma_async_device_unregister(&dw->wr_edma); - dma_async_device_unregister(&dw->rd_edma); - /* Turn debugfs off */ dw_edma_v0_core_debugfs_off(chip); -- 2.7.4