Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND v5] tpm: fix reference counting for struct tpm_chip
To:     Jarkko Sakkinen <jarkko@kernel.org>
Cc:     peterhuewe@gmx.de, jgg@ziepe.ca, stefanb@linux.vnet.ibm.com,
        James.Bottomley@hansenpartnership.com, David.Laight@aculab.com,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        stable@vger.kernel.org
References: <1613505191-4602-1-git-send-email-LinoSanfilippo@gmx.de>
 <1613505191-4602-2-git-send-email-LinoSanfilippo@gmx.de>
 <YC2WRJfNbY22yIOn@kernel.org>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <5d0f7222-a9ef-809b-cd9a-86bbacb03790@gmx.de>
Date:   Thu, 18 Feb 2021 20:13:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YC2WRJfNbY22yIOn@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


Hi,

On 17.02.21 at 23:18, Jarkko Sakkinen wrote:

>> +
>
> /*
>  * Please describe what the heck the function does. No need for full on
>  * kdoc.
>  */

Ok.

>> +int tpm2_add_device(struct tpm_chip *chip)
>
> Please, rename as tpm_devs_add for coherency sake.
>

Sorry I confused this and renamed it wrongly. I will fix it in the next
patch version.

>> +{
>> +	int rc;
>> +
>> +	device_initialize(&chip->devs);
>> +	chip->devs.parent =3D chip->dev.parent;
>> +	chip->devs.class =3D tpmrm_class;
>
> Empty line. Cannot recall, if I stated before.
>> +	/* +	 * get extra reference on main device to hold on behalf of devs.
>> +	 * This holds the chip structure while cdevs is in use. The
>> +	 * corresponding put is in the tpm_devs_release.
>> +	 */
>> +	get_device(&chip->dev);
>> +	chip->devs.release =3D tpm_devs_release;
>> +	chip->devs.devt =3D MKDEV(MAJOR(tpm_devt),
>> +					chip->dev_num + TPM_NUM_DEVICES);
>
> NAK, same comment as before.
>

Thx for the review, I will fix these issues.

Regards,
Lino