Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7531990pxb; Thu, 18 Feb 2021 12:37:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQ+iJPU8HP9VmYEOfLBRRHBN+A8TI4vIyH450Ys+mHQ7qj+ubGtze2glZtoHW3OpYQILDY X-Received: by 2002:a17:906:660b:: with SMTP id b11mr6076689ejp.458.1613680662321; Thu, 18 Feb 2021 12:37:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613680662; cv=none; d=google.com; s=arc-20160816; b=nTnb+pleJH38v+wa+jaxEUj4u+IAaPeX7Xkow5sIlhX4WQ+fhzwKNGNpR586wkTWfC VbpT4VYupRRNOuoM0BPE9y5G/ELhskXLgZO+bRNn6eYbQUHCXIhGf/D3jwrTX/33DFYN zaSOHBPFQNnwYJMFRj4Rpin8RotKxhkILhia2li11/PHNF1dTCppmn77qD49UZdCzHQy zSaR064+PgC6/Y+/b9w5CZYWkXNf5cSAgopTT5qWGGCqw/84wVazhGt1G8Erk+q0gUCR wI/fDEvVXTtmx1NfNEgrDG5FopBdv8wtkuPRTd6xITh/My8p5r8Q4c87DiYUfFmsEk0q E4/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6GkVg6oPaCbOjN9yHtUy6WgUiMIl+iIxU5q/YySdGqo=; b=nXH0OgJ368XiqA1DsrAbLb6gt4FcHyXgxFjk6zNAsV4i3OqAxZU0EiGb8smxD85NB4 dZla8MFwKc++gJsarnY9myMwH0Zh7uS2zb8MCH07divLnIze/hzf586O8vZ+KpJ67zlY 0bLO7CgZUNLc+fE2O0ZoSluFr0n4JTuKC34Ys1TM2iwslKir5tfSJ15qtgTREck8pjmO t6f0jnA88B7W+cApvhefnbZQ3AD+RrtATaHGZiQP/FtJsCx/LwY6+w2iEZB+sjuuZxMf 67eNKBYD16ZYKpixm1LHalk07rBzXWGPlCJheClwt8PiJoNpVVw1/6umY/XS/jLAWJM3 VesA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HWrUIFsI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si4288590edx.173.2021.02.18.12.37.18; Thu, 18 Feb 2021 12:37:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HWrUIFsI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230234AbhBRUfC (ORCPT + 99 others); Thu, 18 Feb 2021 15:35:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbhBRUeT (ORCPT ); Thu, 18 Feb 2021 15:34:19 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FCCCC061574 for ; Thu, 18 Feb 2021 12:33:37 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id t2so2260613pjq.2 for ; Thu, 18 Feb 2021 12:33:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6GkVg6oPaCbOjN9yHtUy6WgUiMIl+iIxU5q/YySdGqo=; b=HWrUIFsIBt63vXlTx9Fi+lqtHfKHvSqunnCmQIjmO0fDJL7GSWvmZlm0BRMwCnJPc3 gbo6xFLqUPzMMWqkoks6inG87DuOSa9iGf15R8guNkFY5qwVM3JI1b2FqVFPb9ve5TWq bJnAFpEzsyLjDChFEZHC8GccBzFB8VDJJpf+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6GkVg6oPaCbOjN9yHtUy6WgUiMIl+iIxU5q/YySdGqo=; b=TT+Pmf5XsqIuAIx13kipQ4o5uLp4+NK2s0IUv5aWwDXY7yyO8YAO0WGIZF29c1dEjg vOD2pSMMkueVkZGIHoFtaGTQlvwSGJl+sVP5NfYl/1TWnTxkgM/2pv49+46LcrT590Xo oOZcPvFg12UyqlnoOkxGzhv9u1F2WUqAiIId3V6oWlj0QpFI2LDgsM32ahkfOJJeONAl iKk6/YFqytjec8RtPoZ9tQhpKnUoQ9wbUhM/2VYbGC96XdF9uCN8ymtqJq8iE80D5y+T pJXiKYnhnJup+ottnljXpUTAVkO++0VkY3eRlQPUV+0bQotB+HroiGoQE6Gx7RCbembR d2eA== X-Gm-Message-State: AOAM532G5A8Du0pC5ZIFAwODvHpKH++72L3joaeDuztw4QA9Cz5rwuqI bHc6lwa7QL8qIhF+W2bULTfbiw== X-Received: by 2002:a17:90b:806:: with SMTP id bk6mr5614183pjb.16.1613680416959; Thu, 18 Feb 2021 12:33:36 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x20sm6993759pfi.115.2021.02.18.12.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 12:33:36 -0800 (PST) From: Kees Cook To: Tony Luck , Anton Vorontsov , Jiri Bohac , Colin Cross Cc: Kees Cook , Matteo Croce , stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: pstore: fix compression Date: Thu, 18 Feb 2021 12:30:03 -0800 Message-Id: <161368019685.305632.7880211837303066992.b4-ty@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210218111547.johvp5klpv3xrpnn@dwarf.suse.cz> References: <20210218111547.johvp5klpv3xrpnn@dwarf.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Feb 2021 12:15:47 +0100, Jiri Bohac wrote: > pstore_compress() and decompress_record() use a mistyped config option > name ("PSTORE_COMPRESSION" instead of "PSTORE_COMPRESS"). > As a result compression and decompressionm of pstore records is always > disabled. > > Use the correct config option name. Eek; thanks for the catch! Applied to for-next/pstore, thanks! [1/1] pstore: Fix typo in compression option name https://git.kernel.org/kees/c/19d8e9149c27 -- Kees Cook