Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: PXxltUC+nCXRkRD1ZCphu12L69b3/n52ZTBck7gMEGcnktVhzESg30ztCmseTu1xpneGEwEceH
 faW212by7VvQ==
IronPort-SDR: 3BbPWGw4358jO5fcFIuyRFXScJbK8dak/QttUQN57kkvj4q5/TFgX+DSB1kIA+Gfcj+TSIDEP+
 AEXLQJWBYdbA==
Date:   Thu, 18 Feb 2021 14:48:48 -0800
From:   mark gross <mgross@linux.intel.com>
To:     Mario Limonciello <mario.limonciello@dell.com>
Cc:     Hans De Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        platform-driver-x86@vger.kernel.org,
        Divya Bharathi <Divya.Bharathi@Dell.com>,
        Alexander Naumann <alexandernaumann@gmx.de>
Subject: Re: [PATCH] platform/x86: dell-wmi-sysman: correct an initialization
 failure
Message-ID: <20210218224848.GB134379@linux.intel.com>
Reply-To: mgross@linux.intel.com
References: <20210218191723.20030-1-mario.limonciello@dell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210218191723.20030-1-mario.limonciello@dell.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Thu, Feb 18, 2021 at 01:17:23PM -0600, Mario Limonciello wrote:
> On Dell systems that don't support this interface the module is
> mistakingly returning error code "0", when it should be returning
> -ENODEV.  Correct a logic error to guarantee the correct return code.
> 
> Cc: Divya Bharathi <Divya_Bharathi@Dell.com>
> Reported-by: Alexander Naumann <alexandernaumann@gmx.de>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> ---
>  drivers/platform/x86/dell-wmi-sysman/biosattr-interface.c     | 4 +++-
>  drivers/platform/x86/dell-wmi-sysman/passwordattr-interface.c | 4 +++-
>  drivers/platform/x86/dell-wmi-sysman/sysman.c                 | 4 ++--
>  3 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell-wmi-sysman/biosattr-interface.c b/drivers/platform/x86/dell-wmi-sysman/biosattr-interface.c
> index f95d8ddace5a..8d59f81f9db4 100644
> --- a/drivers/platform/x86/dell-wmi-sysman/biosattr-interface.c
> +++ b/drivers/platform/x86/dell-wmi-sysman/biosattr-interface.c
> @@ -175,7 +175,9 @@ static struct wmi_driver bios_attr_set_interface_driver = {
>  
>  int init_bios_attr_set_interface(void)
>  {
> -	return wmi_driver_register(&bios_attr_set_interface_driver);
> +	int ret = wmi_driver_register(&bios_attr_set_interface_driver);
I have to ask if the propper fix should be in wmi_driver_register
> +
> +	return wmi_priv.bios_attr_wdev ? ret : -ENODEV;
Also, is there any point to call wmi_driver_register if returning -ENODEV?
i.e. should the call to driver register be wrapped in a test for
bios_atter_wdev?


>  }
>  
>  void exit_bios_attr_set_interface(void)
> diff --git a/drivers/platform/x86/dell-wmi-sysman/passwordattr-interface.c b/drivers/platform/x86/dell-wmi-sysman/passwordattr-interface.c
> index 5780b4d94759..bf449dc5ff47 100644
> --- a/drivers/platform/x86/dell-wmi-sysman/passwordattr-interface.c
> +++ b/drivers/platform/x86/dell-wmi-sysman/passwordattr-interface.c
> @@ -142,7 +142,9 @@ static struct wmi_driver bios_attr_pass_interface_driver = {
>  
>  int init_bios_attr_pass_interface(void)
>  {
> -	return wmi_driver_register(&bios_attr_pass_interface_driver);
> +	int ret = wmi_driver_register(&bios_attr_pass_interface_driver);
> +
> +	return wmi_priv.password_attr_wdev ? ret : -ENODEV;
same comments as above only for password_atter_wdev.

--mark

>  }
>  
>  void exit_bios_attr_pass_interface(void)
> diff --git a/drivers/platform/x86/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell-wmi-sysman/sysman.c
> index cb81010ba1a2..d9ad0e83b66f 100644
> --- a/drivers/platform/x86/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell-wmi-sysman/sysman.c
> @@ -513,13 +513,13 @@ static int __init sysman_init(void)
>  	}
>  
>  	ret = init_bios_attr_set_interface();
> -	if (ret || !wmi_priv.bios_attr_wdev) {
> +	if (ret) {
>  		pr_debug("failed to initialize set interface\n");
>  		goto fail_set_interface;
>  	}
>  
>  	ret = init_bios_attr_pass_interface();
> -	if (ret || !wmi_priv.password_attr_wdev) {
> +	if (ret) {
>  		pr_debug("failed to initialize pass interface\n");
>  		goto fail_pass_interface;
>  	}
> -- 
> 2.25.1
>