Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 3/5] mm proc/task_mmu.c: add soft dirty pte checks for
 hugetlb
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-s390@vger.kernel.org, shu wang <malate_wangshu@hotmail.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Matthew Wilcox <willy@infradead.org>,
        Michel Lespinasse <walken@google.com>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20210211000322.159437-1-mike.kravetz@oracle.com>
 <20210211000322.159437-4-mike.kravetz@oracle.com>
 <20210217193550.GC6519@xz-x1>
From:   Mike Kravetz <mike.kravetz@oracle.com>
Message-ID: <008f5ebc-6547-9244-24e0-710e3fe82b5e@oracle.com>
Date:   Thu, 18 Feb 2021 15:59:49 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
In-Reply-To: <20210217193550.GC6519@xz-x1>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.2.112] (50.38.35.18) by MWHPR21CA0032.namprd21.prod.outlook.com (2603:10b6:300:129::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.2 via Frontend Transport; Thu, 18 Feb 2021 23:59:51 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f58f721-2036-41d3-5063-08d8d469482c
X-MS-TrafficTypeDiagnostic: SJ0PR10MB4512:
X-Microsoft-Antispam-PRVS: <SJ0PR10MB451277E51BB0A87E7C9436C9E2859@SJ0PR10MB4512.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: U9Qlfusefdpx4qlfks94/LysCDzv2B5Va65TMSVE4o9W9mbh4d37mN0AOwW85yX10nVkHpycTV55J7j7Os/owJbYpTDx/+e36Rp7bBfFvinqSBkY1DAQ5YxD+mDuT2JkfgGiixwnKJ4dWmVfefVJUsHtI9jXzScsYehNMbWZidDlrTnIgPHVff4ug7L1sfb4VzH2VbN24rwaYq1pSuGshyq75rvs7C8+Np2BD4Ip3ic44KYh8hFaPLTB8WzIBmPRmpnVb3WwauzsQaVR5rm1xuGrMGefDI4AtGR87hF+Bs0z26pfZq6rY8Uq8+btRPZjJYJXrZzBPvGUPe1PT8iozf7WKkv1dm0QvjNjmJ/h82kRM4XHvTctcLXoMfyfUYspiaGZYp0N+2dYmkq8jvkQxKqmxP3/0PyWxH7NuSLgAHMhvydQp9qKF1IZbG2ilz638wcnN42IKVcofuq//ZRMScdKEX0+M7mWvKMZswSH48LWu1YR1HRipKxcou9Ur/fg399+clrn/LjbezxnTl+kDddJdTnKC3XedDKo5O+H/GOq3UtlN1ZiTgtT9XKSzdDRuLD4Oh1EY03XEhXtCG1ccxbt+wx9cQfITv169CgZIwn0tBr4Qvh/tt4elQeiJXgI
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(346002)(39860400002)(396003)(136003)(6916009)(8936002)(26005)(478600001)(31696002)(36756003)(8676002)(186003)(316002)(2906002)(16576012)(52116002)(6486002)(956004)(5660300002)(53546011)(4326008)(86362001)(16526019)(44832011)(54906003)(31686004)(7416002)(66476007)(2616005)(66946007)(66556008)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dGdnTVJiRGRYZlFrZmNvUnlucEs4bEh2bWMySVExWnByMm5McjJjUjJxd3Iy?=
 =?utf-8?B?d0JYZlphREYxbXpWSnBvS2hEaVBORXJIQWRkWU1WeTBqTmJkVDlFNkc0WnZ0?=
 =?utf-8?B?OEVnNlpLTTAvOHQ5cC8zdkdVd1N4N2JpbForNFNIZEJjM0xwdklwR2FPbTl4?=
 =?utf-8?B?dXFlU0NWajlaVi81L2NNT0gvTFVhRWtnMm9CYlltZDJvT0FLT1JkWGdVS0RT?=
 =?utf-8?B?SmxhejZDbERZc0dmV2FuUThxYUkyUXlERzV1TVNTeDlUa29RZmhTc3lwUFhE?=
 =?utf-8?B?emVqV0p5Z2ZKVVlRd3lOd3NUWnV2MmE5V25xV1VnM2w3Vy9ZLzRNeUpPcVZr?=
 =?utf-8?B?ZWRPWXFLK2duUVY5MDR2bU1OelJIeFRhb2p6NjE0TDNNeVQvMlErc2hGSVJo?=
 =?utf-8?B?QWhBWFJPdnY0N2xHeU5JdkJsd1g0R2J6SXFnc2xIb2tRSVVKMEZQQlU0UVQ1?=
 =?utf-8?B?Vkkya1BoRnhxeVYvTkdwS3BnSW9JMUE2b3haZHBERy96UStLZllsWDlCUWda?=
 =?utf-8?B?a3AzeWc0dTFYcXVlT0d5LzFsR3BTcFNGYmcwVkhFb3NGVXFUNEphRnpFaVNr?=
 =?utf-8?B?dWR6UXJVM3U2ekQrS3NwU2lLMGQ3eVRxYUJqa0NMVmljYS93Q2p2UzdnMXlx?=
 =?utf-8?B?TkpXVkkyaGFNNE42Y3JmZ2k0Y2ZvazZ6UnQ0aUhVdWhpMVhkWElnUVBNczMz?=
 =?utf-8?B?ZjdIYmY5eE5hWEVpaENPSDdFd0FRZ2tDS3VhazVSaHg0Q1YvTVg5TTY1RElH?=
 =?utf-8?B?c3d0aDJIdnFaL0hJWkw5cEZrUTlMcjE3Ri91SXJXdjNOMWlITUxjdExYOEli?=
 =?utf-8?B?cWFUZGJHMFF0cVJZcCtSMzF4aW1FNVUycWdRSUtIckFmZHltbzA0VmFIbjJr?=
 =?utf-8?B?NElydkFDcmNUQWdEZk1KQU4wYXgxSTBIRmlPcEI5UVNLLzJQR2xEWS91UUNy?=
 =?utf-8?B?WVZqcGhNOHlIUFNFcWZSbVJSOE8wTVZ2Zm95cWZkcWtjbGNBTmw3TDZSWFZw?=
 =?utf-8?B?bmF5VGZuTkdNb1pyUFNtSTJLLzhJN1ZaZUxneWcwSm41anM1UHc1bnRLMW15?=
 =?utf-8?B?dkIwbUtLV0VKellOYlhBZVFTeXpuMDFJR3hNVnMvdWRrYm9nN1JRRGNWYUoy?=
 =?utf-8?B?SWEvMC9Vb2JZWXJYUkh1ZU1vaTZ5SWdWTlNXTkF5OFhsZWZIUjdpTWw0Z3U0?=
 =?utf-8?B?QnZFOTE4NGs0cmVYQ2VxbXNxQUdZK0p0SGJ4TnFqOHVkTU1EQStIK09FUVp5?=
 =?utf-8?B?YWxCcFYyNE01NGgrSURtWEFDamdEVEhrc3liWW5hbTZDSHpLSVFvWFE4OWIw?=
 =?utf-8?B?OGhmam52N3ZDcmRCczZOd2RuUUdLUTJHb3pjRFRlY0tHZGROeUh2UDFHb3dX?=
 =?utf-8?B?VWJBQ3RhWk9Vb3FzajBYSFBXZVpvT25LRGdiVWhkczRJb2pCd2wyL0xxdFRl?=
 =?utf-8?B?UWIxYTBVWmRCVDdZTHZoY2FRc0paRmg1SlpzZC9lQmlyMk5FSnVlMmJxZzdL?=
 =?utf-8?B?aG11d3F1UGJ1SVZSczJMMjlKTHlia2QwTUVwR3ZJemxJTXQrY1NEZ1lNWWR1?=
 =?utf-8?B?bUhFVEtxaFcxUjlYekNMRzlsNWVWbk82MUx4Q0djS1BvWnJEZUJjWi9EZHNs?=
 =?utf-8?B?N3hYWU1aRDNkKzRYY28yN1dEbE1FYWlmMDZOUVcvSkJNZDltU2hkQm9yaXhQ?=
 =?utf-8?B?MTJ0RHhxbWlFWkszd2d3WTJVZ0JMajZDQUZaQUN3azNLS2N1YXNkRVBiZ0d6?=
 =?utf-8?Q?gE0zp+fheIxMvnelYglRWlYYkYAcpaZXVRaE/ob?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f58f721-2036-41d3-5063-08d8d469482c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2021 23:59:52.3430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7poFz4EpDySX/rMgUwIIJnPMKEk07AsJrkDw4rKUbpMWjJsbYphyvZjECHzoA+FIqSXlHFjUrrvpcyRGbBdu2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4512
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0
 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102180203
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0
 priorityscore=1501 lowpriorityscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102180202
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/17/21 11:35 AM, Peter Xu wrote:
> On Wed, Feb 10, 2021 at 04:03:20PM -0800, Mike Kravetz wrote:
>> Pagemap was only using the vma flag PM_SOFT_DIRTY for hugetlb vmas.
>> This is insufficient.  Check the individual pte entries.
>>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>> ---
>>  fs/proc/task_mmu.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
>> index 602e3a52884d..829b35016aaa 100644
>> --- a/fs/proc/task_mmu.c
>> +++ b/fs/proc/task_mmu.c
>> @@ -1507,6 +1507,10 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask,
>>  		flags |= PM_SOFT_DIRTY;
>>  
>>  	pte = huge_ptep_get(ptep);
>> +
>> +	if (huge_pte_soft_dirty(pte))
>> +		flags |= PM_SOFT_DIRTY;
> 
> Should this be put into pte_present() chunk below?  Since I feel like we'd need
> huge_pte_swp_soft_dirty() for !pte_present().  Say, _PAGE_SOFT_DIRTY and
> _PAGE_SWP_SOFT_DIRTY can be different.
> 

Yes this should be moved below, and it should check for both.

Thanks,
-- 
Mike Kravetz

>> +
>>  	if (pte_present(pte)) {
>>  		struct page *page = pte_page(pte);
>>  
>> -- 
>> 2.29.2
>>
>