Subject: Re: [PATCH 2/2] serio: lockdep annotation for ps2dev->cmd_mutex
	and serio->lock
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@osdl.org>, Arjan van de Ven <arjan@infradead.org>,
       Dave Jones <davej@redhat.com>, Ingo Molnar <mingo@elte.hu>
In-Reply-To: <Pine.LNX.4.64.0609261520280.3938@twin.jikos.cz>
References: <20060926113150.294656000@chello.nl>
	 <20060926113748.833215000@chello.nl>
	 <Pine.LNX.4.64.0609261520280.3938@twin.jikos.cz>
Content-Type: text/plain
Date: Tue, 26 Sep 2006 15:36:38 +0200
Message-Id: <1159277799.5038.22.camel@lappy>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1071
Lines: 28

On Tue, 2006-09-26 at 15:21 +0200, Jiri Kosina wrote:

> the lockdep part of the patch (1/2) is OK. The second part, specifically 
> the libps2.c changes, are not complete - the originally (wrongly) 
> introduced mutex_lock_nested() has to be changed back to mutex_lock(), 
> otherwise we will get spurious warning from lockdep about ps2_mutex_key.

Ah, missed that that part was actually in the tree ;-)

> Below is the fixed version of the patch. I confirm that this (together 
> with Peter's original changes in lockdep, already acked by Ingo) fixes the 
> synpatics passthrough port lockdep warnings.
> 
> So, as long as you, Dmitry, seem to be convenient with this approach, 
> please apply. Thanks.
> 
> Signed-off-by: Jiri Kosina <jikos@jikos.cz>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

Thanks for testing


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/