Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     Cornelia Huck <cohuck@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Pavel Tatashin <pasha.tatashin@soleen.com>,
        Steven Sistare <steven.sistare@oracle.com>,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] vfio/type1: batch page pinning
In-Reply-To: <20210218120153.4023ae85@omen.home.shazbot.org>
References: <20210203204756.125734-1-daniel.m.jordan@oracle.com>
 <20210203204756.125734-4-daniel.m.jordan@oracle.com>
 <20210218120153.4023ae85@omen.home.shazbot.org>
Date:   Thu, 18 Feb 2021 20:50:08 -0500
Message-ID: <87mtw0x1v3.fsf@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from parnassus (98.229.125.203) by MN2PR03CA0002.namprd03.prod.outlook.com (2603:10b6:208:23a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27 via Frontend Transport; Fri, 19 Feb 2021 01:50:22 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d2e43920-fdfe-4d46-ead6-08d8d478b8a7
X-MS-TrafficTypeDiagnostic: CO1PR10MB4468:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB44686FC1352B946AE6942E7FD9849@CO1PR10MB4468.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: d7ktVdIjOztRHh8iqLG/XT53iZKHOmS2eDbQhe464ulQ+Qp0PyGXAJgZw0WbqkC1CXns7KGUqvsq/+ZM8vhEKaHpJONKQCyIkXm6PZbrU6BZgngWuGC4HHMthW9g/qeoqj1UeHS0q/xAdN3Dp/UtNijNCwvSq/8p19VzzAO3u67Z/gi60Ww8tGdAPJecLAFnGK5xl8ZU7gaqB3iyW59UskpICVjRNQe+p5E+pZ3fLvMSetrVL41d5c2GhUttoiPEZN4UsMvSb5K6f1YShhEz7y01xlQ9bjG2oUgelVNOx5k3KIP6w0fnFRNL4sXJVfMF3b+g/BSC6QFlAcknNPAMB3dTbihjX0UGmVmdQ6k9gLb3NWAuPw0VTyQHWreL5/RJ51Z87JuhJRPFswLmQGNDlEnJhpYOz4atsbmiYQdsMLPoR/OzNmtF71yTRUU1VO+Xhntn0eNY1UF/l0CLSY0KReafX1Q3Zrsd80N0DVgMf0D6fpNfonOG4xCLA8KlW52HeFlyLRbXDRVyk6IbbZk0NA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1774.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(376002)(39860400002)(396003)(346002)(66476007)(2616005)(66946007)(6486002)(6666004)(558084003)(6496006)(36756003)(26005)(5660300002)(4326008)(186003)(6916009)(956004)(54906003)(2906002)(8936002)(316002)(16526019)(86362001)(66556008)(8676002)(52116002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?tSmIU6as9tenNCqfytWTJhk8EpO4E9gme2YmHJPkiWjUXSO9QMoWa1ee1Ysz?=
 =?us-ascii?Q?MqfEaPKI1cLwONtK65nef09JrVT1tGWgDSBcgcVibOyx+EwqplhECw5xu7MM?=
 =?us-ascii?Q?acnGUU3Da8zrbUtYiDSv867FfqBd7y785swMjKILNVyK8T4rsysYQYpXwsLE?=
 =?us-ascii?Q?zjd2HyBK6yWdiDTaStPRQeopHXX23LFBeIeY5m7ycph78MKMXxS4Igmoqguv?=
 =?us-ascii?Q?AwcBn6eb9gmH2+SWA0B1kDshbU3kgSpLCMu62+DE7QMC8IRl1sPzueyZY/qq?=
 =?us-ascii?Q?fL0hHzdnf3HwE75K6oaRg/uzm32K6O5WUDq48zB56mXMmg+P68j6JXxpZ5kj?=
 =?us-ascii?Q?vAUrAs3OQMgbT3NiDT9Y2FXMe4ZaXxjt/8IAMVIT7jPNzTUhONQS1Z8a9ujt?=
 =?us-ascii?Q?W3fSSkQLKIycb2ygjQ6dpBYc9yX0YkrjN3zjMrNeZOyjKzdJCkHQeAEFj9Zs?=
 =?us-ascii?Q?nJv3WZueNg1TiA0McoNAkeXB82mDPy8d4FyJY9v6+hrLG7lkPsKOWPyH6Ybw?=
 =?us-ascii?Q?e3CjgR6k7Wr9hOkp57fmJktH91kOGXX1pZOJwy9jKTOKC0HORxeH08Z+Ieee?=
 =?us-ascii?Q?4aMlIsz3CIaZvtnyt5zg390PcJODXXsl0qWjso6OnZtqOSOwz6/LIccx1n89?=
 =?us-ascii?Q?J6APamCng6wlfCmiythhKXdFosF7If0dAmaRRgbCdsJpgJHbF9qktFmGa2ZO?=
 =?us-ascii?Q?EOhBJwoT1efzrzqdDutCA0m87CIAQg8dIY+xrMIN1JU8LI6+Ng6ntdZ0ICTc?=
 =?us-ascii?Q?iMen9qT0KAZXYDFQ9jArtuTiQpgc1x3MujGQd8SSmFCrLcfPmeCz/jSPoh71?=
 =?us-ascii?Q?i+9Nlf+jN2r9b8XFCqVDNuLqJp0Oq6UV8LXSlSzxfqA63Vy4Gpr3s2ruQI4p?=
 =?us-ascii?Q?Z2i5c+lsWA9X0EOF5Z2Cw7oZ6lLmObh9ESphPY9xrg+QMYkWqHqDBpQyxm7Q?=
 =?us-ascii?Q?xlywZ9Hapjpot+DYsAwX1aJ33bOup1H12JdegY6RLQ54g6Fr3hCsVgEvtiRY?=
 =?us-ascii?Q?3jdLZj6HdiAt6Hh2EvfeK64fcroWhPh23E44vav0fhHjDqiZDd4KKyP+S7Ub?=
 =?us-ascii?Q?y8pr6Y0xEQwmtofOq3CQMFwVSoxMdzbQJGu1azHMiEaAukHExyVlCFQdsLcS?=
 =?us-ascii?Q?r0JLLm1WxiXn3gLY84NH1uB1vnkOVS4nqYbM5PnoXDX/qeXDgM34N0JMjXZv?=
 =?us-ascii?Q?J13+GzL4b73HxCORzjhel3Ge4wIRvDrDfzRXmkUk4HDUEEbdmZj1wTIvPPnv?=
 =?us-ascii?Q?bMJ5IumilF9vFghHMyQVS724Xw90SPzmvR+fyEBAJVWbh82KArDW/ZPMwgb/?=
 =?us-ascii?Q?k6o7iqO/WqmTOQbyvD1rzcF3?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2e43920-fdfe-4d46-ead6-08d8d478b8a7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1774.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2021 01:50:23.5090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MukJ1h3dJvjUJpw5sa7JVETxEFRm3Kqqe1mR4yL8tJtSwSsoBAE8Mz9PdSYwcjkaphOHG9Dy58U6o7gXI5G/DJWhvPsMwDjHD+TlEoUavbI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4468
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 phishscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102190008
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 suspectscore=0
 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 mlxscore=0
 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102190008
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alex Williamson <alex.williamson@redhat.com> writes:
> This might not be the first batch we fill, I think this needs to unwind
> rather than direct return.

So it does, well spotted.  And it's the same thing with the ENODEV case
farther up.

> Series looks good otherwise.

Thanks for going through it!