Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7798134pxb; Thu, 18 Feb 2021 22:22:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyANynRWzUrG8ajphX1fVXrUcGXttuU63kT4clSOdGPlbLJH72AxBondLeH6poTVRgzKfgm X-Received: by 2002:a17:907:16a2:: with SMTP id hc34mr7258884ejc.479.1613715773010; Thu, 18 Feb 2021 22:22:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613715773; cv=none; d=google.com; s=arc-20160816; b=ltrCbraF8sjjc6FP7yw2K2ROdFLIinsWyJm+ga1b+1HTy3K8TGae5SAoaINKKz/P/q Cfu1gLVwWKA1Rabq4ayzkQeEPUk4IFNBPxxxb3/wAj+r4nB8U6jtF1maAO9UkxqWO6j7 Bf3qTI8QuGKZpjYkTdCElJMjwowEn/RvqKBWMStu//9TVDbH/PlD7o9UrZ2Cz42OCmCy ZpjuBeHSSYK+Jl9mtZVzlylsQcbZdMuntPPw49Iy54ScdTqnUX1T9GjNSPdsEy7PJUkv 8c/zEdJ38uAXZI8gkF1tk+FX2ncGJLZYLZRRFbr63UPNysvrQs1tEouID3FyKtgZf6OV Bukw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HbVoplUF8i/dklAUTFworr6aXVkDiO2xrSyPRyOtGoY=; b=KwxnsJpHSG5b6Tar7QiLYOgGgShUFOYChxNBzmgpH8D0yNMz3aD56wjI6uRTviNk5J sPIn5K3YT+fgbWTbTUkT5/MfcihmLJ/jNVXt49cK4dMkTohaYFCgNCcyD4eLTjayQ2HX 4YCjYc/puf70t7/AjSUgr2WTJa4fYcJqd98Mwdka8mRANp6ARWZaVJyuY2GvLvIZNgZk mqjYz/AF8A1DycEr/WXeWPI105HVQvFqirgwTmLtii0c+m/jyYgOtuYuDn0PVKpPYkqi 5D+FvPGQiBWEsCvq6V3rkGmCnYvWSdOFEcuAq03wgb+7hUh4HgmJCvn99JH8LsEsr7+G hV7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gus+0Z73; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si5092232edn.428.2021.02.18.22.22.30; Thu, 18 Feb 2021 22:22:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gus+0Z73; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbhBSGWB (ORCPT + 99 others); Fri, 19 Feb 2021 01:22:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:57506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbhBSGV6 (ORCPT ); Fri, 19 Feb 2021 01:21:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 887B064EC0; Fri, 19 Feb 2021 06:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613715677; bh=h3tseLehzsIKBNkS/hC8AI0YOI2QV+D0PG4f72kEZAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gus+0Z73eMJkwwPTaT5qMZFzGQWGL7AebpV+mEPFEU53PhlTUJJa4rSQnR3BqN2t6 yA/0uw3N2BJynAuBRk84kmUPFjNs1pErofcDpXsQqyZpBWfZODjhvn3VuCY4h5f+tu joChh/mOcik/mF4PWQhMw7EvbVrYeGsV18fosH80= Date: Fri, 19 Feb 2021 07:21:13 +0100 From: Greg Kroah-Hartman To: karthik alapati Cc: Lee Jones , Johannes Berg , Arnd Bergmann , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: i2400m: use explicit host byte-order types in comparison Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2021 at 06:00:47AM +0530, karthik alapati wrote: > convert le32 types to host byte-order types before > comparison That says what you did, but not _why_ you did it. Please fix up and resend. thanks, greg k-h