Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7798652pxb; Thu, 18 Feb 2021 22:24:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2nidTDS/dOwmcnOeuKcGFaesmgmVyuX1eZRaUzUF3f3GZj5IWLZ7Ut6frTAO62y6Qtu4r X-Received: by 2002:a17:907:1629:: with SMTP id hb41mr7200838ejc.197.1613715850618; Thu, 18 Feb 2021 22:24:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613715850; cv=none; d=google.com; s=arc-20160816; b=AeCz8zUHIg/0x+u1QeXixT7rDDmMKATfN3A4gp8R4lD7Brc0zlzIFYzXUpd7ausD9S eA54scWk1wLo4RnVNrny10i9NhARZVU4jXjSe8oBrVuNm5Y7xnhtFK1Mqk4Tyh+WAjmo oZtv06HmEW0FBMVbvcZrPfOboCwRNl8IxJXWemkHfdL3shaNsph2aRuzoeaCHTWmCgGP WGcJiDsQccFCD7TGN1fP6ADWxDCx6Ar/rp0cfwNvQv8SK7KBpF7Gx0OVbJw3ajvR9SvC GKQtIClmAWYAOBKMD+V8qADb/jRtJlMxcxlz0G4F4FKU0Gd+vXCr1DamcfNQvWoG+BEo lw1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=IG1SJ18qF/O97/Shox4tWOiHoASqmjasns5Bom2oH04=; b=vM+H0cNEyvRBnBlLXvJHNa/vLeEQiOijLir48SIpcI+mew+SRc4T4ypwFbEeGK1yPC hIsNwxffdGSaWWnUUDSzhEKABJ8WzALJOOKT3rmz9OGMdywOjozuZgLAvi0hTL/sxYts MRyb/ch23RwbNjQCVUFpyEtE99clDNU1WS7Jn1Bnk87WLTNMbh7OH/5L3+ARHmYAzDvz N4y8A/zef5qO2+g9lJTGBQi64Cg20DgLTDmJ8wfd8Z5SRr9eOl9rWAjzDJ2VwztdkbCz vQyiNqsLumU7CCrH2TsvqW4OwSKrMmVpZwrdVI6ljY/xVbyn6mt/p6oPjHNhzc5jP3S5 /ztw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si5236490ejj.506.2021.02.18.22.23.47; Thu, 18 Feb 2021 22:24:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbhBSGT7 (ORCPT + 99 others); Fri, 19 Feb 2021 01:19:59 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:54970 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhBSGTz (ORCPT ); Fri, 19 Feb 2021 01:19:55 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UOwxvus_1613715546; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UOwxvus_1613715546) by smtp.aliyun-inc.com(127.0.0.1); Fri, 19 Feb 2021 14:19:11 +0800 From: Jiapeng Chong To: clm@fb.com Cc: josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] btrfs: Remove unused variable ret Date: Fri, 19 Feb 2021 14:18:58 +0800 Message-Id: <1613715538-90761-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./fs/btrfs/disk-io.c:4403:5-8: Unneeded variable: "ret". Return "0" on line 4411. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/btrfs/disk-io.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 07a2b4f..78ac205 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -52,7 +52,7 @@ static void end_workqueue_fn(struct btrfs_work *work); static void btrfs_destroy_ordered_extents(struct btrfs_root *root); -static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, +static void btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, struct btrfs_fs_info *fs_info); static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root); static int btrfs_destroy_marked_extents(struct btrfs_fs_info *fs_info, @@ -4394,13 +4394,12 @@ static void btrfs_destroy_all_ordered_extents(struct btrfs_fs_info *fs_info) btrfs_wait_ordered_roots(fs_info, U64_MAX, 0, (u64)-1); } -static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, +static void btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, struct btrfs_fs_info *fs_info) { struct rb_node *node; struct btrfs_delayed_ref_root *delayed_refs; struct btrfs_delayed_ref_node *ref; - int ret = 0; delayed_refs = &trans->delayed_refs; @@ -4408,7 +4407,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, if (atomic_read(&delayed_refs->num_entries) == 0) { spin_unlock(&delayed_refs->lock); btrfs_debug(fs_info, "delayed_refs has NO entry"); - return ret; + return; } while ((node = rb_first_cached(&delayed_refs->href_root)) != NULL) { @@ -4474,7 +4473,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, spin_unlock(&delayed_refs->lock); - return ret; + return; } static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root) -- 1.8.3.1