Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp7816515pxb; Thu, 18 Feb 2021 23:05:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJwstS1lQOPRlxYiSAJrJ2JLwuIs3sifiJPiB7JdfGMuhOMiBly1psSzfyWhjDb8aiJIG1fC X-Received: by 2002:a17:906:5e0e:: with SMTP id n14mr5599099eju.115.1613718349433; Thu, 18 Feb 2021 23:05:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613718349; cv=none; d=google.com; s=arc-20160816; b=ucQWL6RfxqHrIu/0ZawYQL1ISoV7i5OqpYWgYoOerrnvrOnR+ENpype6PI9crTS85F 4crMfyF8gXjw9UGf0yJ0fQv4zfHMwOMcMaPmoz6N8FeO3KFA/KW+q7N1EzY5E417PMhW DjT2ZcVEpleg9pDnXNXBUUmYCOgTyw/abRsebdqLH21fBxHTRS2QOoENgsHEgK9sG38i ja1irDc1OvwFfbzVvY2ED8UJZ8l6QJK4L7Ueqe4+OO4zA5DgFYAB8j1lWRJvf1VcPP4G ABFHrfSbULanqKeSB41Sdyg+wj+Uw1eYk/eD0/5R/Va3C/kCvo8hrcmrlQo+DiceJbSn W6FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1ceI6DD+xmiJ0cdTdA9pJd22cFRKfq1rVJZSzsVyRBM=; b=UQCsKy8TO6HYk0CyCRToBu0WLpUj1kabrRiJY/YQxsrj0zMhbgj8/zLdeVWQmG64im mhfqtEzPVcXCPGYucIGrj4j+vdwCUSaOncG9F3HJJr/bIsvBnF03nySkfts933xL7/mP G1/R0+evvQbLDQqLjarH8lIedlhAXzulj3LnWqyAGq90SON+milHPGr5AAEOHEbir/90 Xu7H/9Lp4Y3qCEzmjF+XsSDoSSbxzmRuw86aMYjpsgEE4W54ugsl8Z06XVwvRDEown6N Isuk2dbCZIDjx/xwo+NULpLE2AUpU+cnWpSX/3HVbbeZvrjuJRJ2yPYyiFPh1grd96KE r6Bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=yODk4U5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ot7si5281836ejb.453.2021.02.18.23.05.21; Thu, 18 Feb 2021 23:05:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=yODk4U5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbhBSHCo (ORCPT + 99 others); Fri, 19 Feb 2021 02:02:44 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:35522 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhBSHCn (ORCPT ); Fri, 19 Feb 2021 02:02:43 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11J701uF003546; Fri, 19 Feb 2021 07:01:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=1ceI6DD+xmiJ0cdTdA9pJd22cFRKfq1rVJZSzsVyRBM=; b=yODk4U5fd2Dp0rMAh+wgA7J/TgiTGoNjFTli0nVuEc4B63rN9sreO+Jrr2lfO6plv+ck hSv7cnAYw5tslmpg51HbO7WSvlR1NhcxEMALWfkHhC9htNfdgUbgwOj7Krry6VrWx8/Z HGC8qdxH8kZxHF4TBbk1s3FXgyu8a8CeUhPzjOgLJp8QiVkbGvUv+4ROSgTfWYF5kt50 jTUjwmEDaZfHR+1GROG54O00eKwvkskKV8KcJVxEkuJ7OHSRrmE5h9O/hIP+eZGmROIf L0sh/zSQ/y3WUbYCCGFDDAfl4VZu7Qd92J8cCL2BgUTC2z53zhv0UrDsifB8uDJzhPVO 8Q== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 36pd9afyeh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Feb 2021 07:01:51 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11J70NKl061495; Fri, 19 Feb 2021 07:01:49 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 36prp2jk1p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Feb 2021 07:01:49 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 11J71mdE014345; Fri, 19 Feb 2021 07:01:48 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 18 Feb 2021 23:01:48 -0800 Date: Fri, 19 Feb 2021 10:01:40 +0300 From: Dan Carpenter To: Kurt Manucredo Cc: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, straube.linux@gmail.com, d.straghkov@ispras.ru, tiwai@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform Message-ID: <20210219070139.GP2222@kadam> References: <20210218194830.8-1-fuzzybritches@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218194830.8-1-fuzzybritches@protonmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102190051 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 impostorscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102190051 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 07:50:27PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > The preferred coding style is: > if (!StaAddr) > return; Above the Signed-off-by line. Also indenting is wrong. And it's hard to understand what you're saying. > > thank you mr. dan carpenter You're welcome. (These sorts of comments do go below the --- cut off line so that's fine.) regards, dan carpenter