Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] staging: wlan-ng: Fixed incorrect type warning in
 p80211netdev.c
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20210217154255.112115-1-pritthijit.nath@icloud.com>
Cc:     devel@driverdev.osuosl.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Pritthijit Nath <pritthijit.nath@icloud.com>
From:   Ivan Safonov <insafonov@gmail.com>
Message-ID: <71a79d2e-6f03-c2c6-738a-8b862f52e48f@gmail.com>
Date:   Fri, 19 Feb 2021 10:37:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210217154255.112115-1-pritthijit.nath@icloud.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/17/21 6:42 PM, pritthijit.nath at icloud.com (Pritthijit Nath) wrote:
> This change fixes a sparse warning "incorrect type in argument 1
> (different address spaces)".
> 
> Signed-off-by: Pritthijit Nath <pritthijit.nath at icloud.com>
> ---
>   drivers/staging/wlan-ng/p80211netdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
> index 6f9666dc0277..70570e8a5ad2 100644
> --- a/drivers/staging/wlan-ng/p80211netdev.c
> +++ b/drivers/staging/wlan-ng/p80211netdev.c
> @@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
>                  goto bail;
>          }
>   
> -       msgbuf = memdup_user(req->data, req->len);
> +       msgbuf = memdup_user((void __user *)req->data, req->len);
>          if (IS_ERR(msgbuf)) {
>                  result = PTR_ERR(msgbuf);
>                  goto bail;
> 

Reviewed-by: Ivan Safonov <insafonov@gmail.com>