Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210218100243.32187-1-badhri@google.com> <YC489HGT/yVHykAs@kroah.com>
 <CAPTae5+qhE9uo2s20oEQd0x+nW21zGE3S7QWkR=oqqVX-3uHmg@mail.gmail.com> <YC5EpqqNM+gnD6Zg@kroah.com>
In-Reply-To: <YC5EpqqNM+gnD6Zg@kroah.com>
From:   Badhri Jagan Sridharan <badhri@google.com>
Date:   Fri, 19 Feb 2021 01:06:24 -0800
Message-ID: <CAPTae5LuxPw+4DKt4_NFmBnZxgvM7nTDFtXJsTiqsevi4krLjQ@mail.gmail.com>
Subject: Re: [PATCH v1] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V
 before toggling
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Kyle Tso <kyletso@google.com>, USB <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Done. Just sent out the following patch and CCed stable@vger.kernel.org as well.

[PATCH v2] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling

Thanks,
Badhri


On Thu, Feb 18, 2021 at 2:42 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Feb 18, 2021 at 02:38:45AM -0800, Badhri Jagan Sridharan wrote:
> > Hi Greg,
> >
> > This patch is a bug fix for the following patch which was introduced in 5.11.
> >
> > commit f321a02caebdd0c56e167610cda2fa148cd96e8b
> > Author: Badhri Jagan Sridharan <badhri@google.com>
> > Date:   Wed Oct 28 23:31:35 2020 -0700
> >
> >     usb: typec: tcpm: Implement enabling Auto Discharge disconnect support
> >
> >     TCPCI spec allows TCPC hardware to autonomously discharge the vbus
> >     capacitance upon disconnect. The expectation is that the TCPM enables
> >     AutoDischargeDisconnect while entering SNK/SRC_ATTACHED states. Hardware
> >     then automously discharges vbus when the vbus falls below a certain
> >     threshold i.e. VBUS_SINK_DISCONNECT_THRESHOLD.
> >
> >     Apart from enabling the vbus discharge circuit, AutoDischargeDisconnect
> >     is also used a flag to move TCPCI based TCPC implementations into
> >     Attached.Snk/Attached.Src state as mentioned in
> >     Figure 4-15. TCPC State Diagram before a Connection of the
> >     USB Type-C Port Controller Interface Specification.
> >     In such TCPC implementations, setting AutoDischargeDisconnect would
> >     prevent TCPC into entering "Connection_Invalid" state as well.
> >
> >     Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> >     Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >     Link: https://lore.kernel.org/r/20201029063138.1429760-8-badhri@google.com
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Great, then can you resend the patch and add a proper Fixes: tag, along
> with a cc: stable as well?
>
> thanks,
>
> greg k-h