Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Feb 2021 17:42:33 +0530
From:   Prakash Dubey <prakashdubey1999@gmail.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fwserial: Fix alignment of function parameters
Message-ID: <20210219121233.GA16568@gmail.com>
References: <20210218102851.GA20810@gmail.com>
 <YC9zNVWX7R9kD0Rq@kroah.com>
 <CALVjNJP=iXH+u2zUB93UZo+1+Ly0g23k5JtPXFbx=vaO+5-0Gw@mail.gmail.com>
 <YC+VX4NpOWX1z3+V@kroah.com>
 <20210219115221.GW2087@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210219115221.GW2087@kadam>
Precedence: bulk

On Fri, Feb 19, 2021 at 02:52:21PM +0300, Dan Carpenter wrote:
> On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote:
> > On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote:
> > > I was unable to align it right below the opening parenthesis, just by using
> > > tabs. And when I did that with spaces, the checkpatch yelled at me for
> > > using spaces. Any suggestions how to do this without using spaces? I am
> > > using vim, I will try to find a workaround meanwhile.
> > 
> 
> Your comment hasn't made it to the list yet.  Sometimes there is a delay
> or maybe it was blocked for some reason (html email?).
> 
> You are allowed to use spaces but you can't have 8 consecutive spaces
> and spaces are not allowed before a tab character.  The way to align it
> is:
> 
> 		ret = wait_event_interruptible_timeout(port->wait_tx,
> 						       !test_bit(IN_TX, &port->flags),
> 						       10);
> 
> [tab x6][space x7]!test_bit(IN_TX, &port->flags)
> 
> regards,
> dan carpenter

Thank you Dan, I figured that out after a few failed attempts to align properly. 

I was replying through Gmail web client, as I am new to mutt. I am getting the hang of it.

-- 
Regards,
Prakash