Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Flavio Suligoi <f.suligoi@asem.it>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
CC:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: R: [PATCH v1] watchdog: wdat: add param. to start wdog on module
 insertion
Thread-Topic: [PATCH v1] watchdog: wdat: add param. to start wdog on module
 insertion
Thread-Index: AQHXBhOZhCefmAy4X0yS/T4Cg8tbv6pfPluAgAAygZA=
Date:   Fri, 19 Feb 2021 14:01:56 +0000
Message-ID: <bf4e89bd11964f2e9f621f949adc338b@asem.it>
References: <20210218163200.1154812-1-f.suligoi@asem.it>
 <20210219105447.GI2542@lahna.fi.intel.com>
In-Reply-To: <20210219105447.GI2542@lahna.fi.intel.com>
Accept-Language: it-IT, en-US
Content-Language: it-IT
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

Hi Mika,

> >  	 const struct wdat_instruction *instr, u32 *value)
> >  {
> > @@ -437,6 +443,8 @@ static int wdat_wdt_probe(struct platform_device
> *pdev)
> >  	}
> >
> >  	wdat_wdt_boot_status(wdat);
> > +	if (start_enabled)
> > +		wdat_wdt_start(&wdat->wdd);
> 
> No objections to this if it is really needed. However, I think it is
> better start the watchdog after devm_watchdog_register_device() has been
> called so we have everything initialized.

Yes, it is needed. We need this feature to enable the watchdog
as soon as possible and this is essential for unmanned applications,
such as routers, water pumping stations, climate data collections,
etc.  

Right, ok for the correct positioning of the wdat_wdt_start function
at the end of the watchdog device initialization. Thanks!

> 
> >  	wdat_wdt_set_running(wdat);
> >
> >  	ret = wdat_wdt_enable_reboot(wdat);
> > --
> > 2.25.1

Regards,
Flavio