Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp8075908pxb; Fri, 19 Feb 2021 06:53:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJz+P48O36I2F1QFc7TjQOzm+RNGCSiW66YQDmlWB2pk7gHLS9IGzB31pq6ONGjlYunzbtI6 X-Received: by 2002:a05:6402:94f:: with SMTP id h15mr9881623edz.199.1613746414820; Fri, 19 Feb 2021 06:53:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613746414; cv=none; d=google.com; s=arc-20160816; b=lN1vfKtp5VsIn2VqNg+64Ulu8XidFVv0S/IFWTrGqbA/FsSJ9IcEklX9T9gVNQSLPw eUDcp2MeNkJB0zva1O22iOkKUWU4HY0afkDl99+WFAt09YLWXwjnc4atP7fL8GEYp+WQ pxZdmwRNWnZ9KxE3RVkOlcrc7H5iWSZrViPQLEGZigS3w0H/Td2g3FzleIGG60hoGmjL ivuSnSXXMitHV2S0gd1H8tnUcwdqwfI1w62r3FjhihaVOy9vAj46Mx2MyhxZec9BOcLP jIvo65/httesbp4gFsBC7RRiT0sna4NY8jM4d8y3bu33Mtf5/kGmxsuOzdV/CRg81NW8 9gTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=BPO44djbjU0U7U6CEqbJq2ajIOB5c8MQDyfxlplmIpc=; b=b85hTUi5LF1gv+6YtyL1K4Bbp5QIpW0Bs/PRdJuhckdJjJKQ/A1sL0EzWiBeLUZP8m ELse0fUG8BgbeTc0xEzz4cQZW3yqqnBApclzI/NGEHG7NjktEmHw4YZUroeLdzLCYc0i M6srBz0FotL8yjdzzmah4w2hsq393wG1H0QJwMPoAJ7BSf7KvnUgHzBrz8wEOaiFZ2sl rfEM4rkwpsAVdt0ILgBFj1B5vhwKoDLdRA56kVNX/YlAIfmyq2usNp+cTdV4a0D8Y1lQ nlgb4dCaFjXG2+Sd2bSipbZFJugnYTA4mLwtuAuqSdVNbY87gE2SkkJcE8YjWpZ7uuPa 7IAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=oYt0Dqgk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rn4si4028671ejb.666.2021.02.19.06.53.10; Fri, 19 Feb 2021 06:53:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=oYt0Dqgk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbhBSOwM (ORCPT + 99 others); Fri, 19 Feb 2021 09:52:12 -0500 Received: from mail1.protonmail.ch ([185.70.40.18]:23226 "EHLO mail1.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbhBSOvl (ORCPT ); Fri, 19 Feb 2021 09:51:41 -0500 Date: Fri, 19 Feb 2021 14:50:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1613746257; bh=BPO44djbjU0U7U6CEqbJq2ajIOB5c8MQDyfxlplmIpc=; h=Date:To:From:Cc:Reply-To:Subject:From; b=oYt0Dqgk921QTN0pFeha7YcVP6aMTM35WJcTfqKwfgOHfZUJPs9TAfoIktFeJIwBF s9V/6gmAQNCbKO99j4LHNG1e7W0nkz2W70AM1u6VisUbcKbeLlwr6ZdwooKqhZMnLb dF+/vluEMBerPq1PYtxmV4DtebDAmTwDWZm/PSOk= To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, straube.linux@gmail.com, dan.carpenter@oracle.com, d.straghkov@ispras.ru, tiwai@suse.de From: Kurt Manucredo Cc: Kurt Manucredo , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Reply-To: Kurt Manucredo Subject: [PATCH v2] staging: rtl8723bs: fix code style comparison warning Message-ID: <20210219144928.8-1-fuzzybritches@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org changes since previous version: - change Subject line - change commit message - change commit message position to above signed-off-by checkpatch gives the following WARNING: WARNING: Comparisons should place the constant on the right side of the tes= t this patch fixes the coding style warning. Signed-off-by: Kurt Manucredo --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 975f2830e29e..96feced698ac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcu= r_dot11txpn, u8 *StaAddr) =09struct security_priv *psecpriv =3D &padapter->securitypriv; =20 =09memset(pcur_dot11txpn, 0, 8); -=09if (NULL =3D=3D StaAddr) +=09if (!StaAddr) =09=09return; =09psta =3D rtw_get_stainfo(&padapter->stapriv, StaAddr); =09DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", --=20 2.20.1