Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp8076214pxb; Fri, 19 Feb 2021 06:54:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGd2a4/8sgpjT/TgOFor0cRP56JnLhv8aATTgOfVetayyz7z3iFnIh0Mdgw+kMWfEAlvM4 X-Received: by 2002:aa7:c7c3:: with SMTP id o3mr9762458eds.8.1613746448998; Fri, 19 Feb 2021 06:54:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613746448; cv=none; d=google.com; s=arc-20160816; b=KPX04e38goyCWLnQSX/FddPLDpYusJugyBqUZyRNJd0vwKHi5nbzWZ9Pcby95TjBG6 1zd2ITcCNJUSVM+hXOcfT6/RQlPKcCvZcJH+1vnAp0qP6XrBr62att7noEPfPHVL6zQ4 2niQlKookz6cvQ6rNgMnrBt90xveHiby9J+3jiG0rWVh0PXhBGz2pURIDTFW0kVDAuFJ /l75KiLEuKtI/3zLEk2QU4R8B6rMEiqj1feoA3cscSPblScCUv4e4UnslHAO38/grBCd mhopEGUYsu0kVRT3C5/ANVvDbJ+TRX2xzVh4PbC0fqhu+ve6GNjir/6wYjVO6ptLMcgZ Be3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZQhqhbBuUl+TFjcNk0V6WabrkpzvFO7tbPRu8Yc3cZk=; b=XFg9662aVgX3eHXFogbIvNIwxcVl9/yUFkRBirK4MZP/1tfbfnEPwBTYUCkhLG/ZoB ujCA266Xe9E181yeezqLJ/mhRym9Mnhb1UK2HhsP9ledUKrXrKCweDJrlYOp0kV5WXdS tHFBuYt17P/J5yDblJAsEOVrGGqqwSJiCjNmmUCqi2L9hoU2KEVS692AQMxP2GgdpfS8 tqfa8ZWJvqSZsjUOilSvE3fzApNTV+CtenkafH5uBR0sGRu7rHWIVkIZTcPxwkzA7fOU hvWyCeNP2PXGdcojh6AM6t+F55HSg2OQw0Zry90OqlcacHpISJEXQm2EXo/AnrKvUAJY K8+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=We+JJYLy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t21si4696650edq.109.2021.02.19.06.53.45; Fri, 19 Feb 2021 06:54:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=We+JJYLy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229765AbhBSOtY (ORCPT + 99 others); Fri, 19 Feb 2021 09:49:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:35498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbhBSOsq (ORCPT ); Fri, 19 Feb 2021 09:48:46 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 74C9B64DA8; Fri, 19 Feb 2021 14:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613746085; bh=Kzw8IGCLSSobTf8Sdkya+7Ssi9f530ZsrCQ+iE4rq0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=We+JJYLypeo/RFwLeiuKqd8vSG7hGAp+M6rkI6LWRHl0KSzvNYSo4p3IdqZYf3SlN 2ufM2BVTr+Sg5tTE4xIi5LMcEaUqURy1fVoEice2gMDC7lCDVPVZyECpO+d2c+Y0Z2 zK1AAAxA38J77G1YmuJHuPd41WRP9gYocE516xa6tv6d45Km2wLlY+Sm2zbg/18+m2 faC/eZpXPkHRPWw4BGj6CRCEvDM5o/VKf0Y2DBqkgB3CUHT/Mdv3qAWJK1MdXawNcV 12UCske9OcXDG68ASyox6lZyPmCp/rCy77Sn5wxvBkoDg0TkNxoGNgzYOHxVTJ1OAu T9Dhlq4OUQFcg== Date: Fri, 19 Feb 2021 15:48:00 +0100 From: Robert Richter To: Dejin Zheng Cc: corbet@lwn.net, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] PCI: Introduce pcim_alloc_irq_vectors() Message-ID: References: <20210218150458.798347-1-zhengdejin5@gmail.com> <20210218150458.798347-2-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.02.21 15:40:11, Robert Richter wrote: > static inline int pcim_alloc_irq_vectors(struct pci_dev *dev, > unsigned int min_vecs, unsigned int max_vecs, unsigned int flags) > { > if (!pci_is_managed(dev, min_vecs, max_vecs, flags)) Obiously this is meant here: if (!pci_is_managed(dev)) > return -EINVAL; > > return pci_alloc_irq_vectors(dev, min_vecs, max_vecs, flags); > }