Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp8130733pxb; Fri, 19 Feb 2021 08:07:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyOWukEVLwTdeR/Bm3FXS8BocwvUtCqvF6n5GayK19JXMMaYmHX3SqeJtZtDjT1YMIEwtwh X-Received: by 2002:aa7:de0f:: with SMTP id h15mr2562697edv.140.1613750870575; Fri, 19 Feb 2021 08:07:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613750870; cv=none; d=google.com; s=arc-20160816; b=sUTFb2/bXSy/gv7FpeBuVLI9y2Him9GGnZlnHCFQ/CsKUMFmnrbEVf0augmMmNO7Ss YKnukh1GXFVDi8JDGCclBCGFElsy8QnnG/zm1jdNfElX2JEdO9cuRt0Sml7JPTEZ3FT8 X2WakQZR2hqDc+d+WeoMmiJZy6JTRwZvTZQJsNtNwBynIoRqo1SGhFQej8671QX7vHSl 75ZVQeMpLux5vNp1PaixyhqiCl+3GQwjRj2I1X5qr6Ua6MLWqDI9QlQjsnGDD/3pl97l 8IbbLKKJvKhVZ764W06wKB1SeSQZV0bXFLbslsGI1uslMYFWqDmVOrldLBTj7BvKwAX+ r94Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=tNd2Hdlnc+MvZAS16cdxpREmkvo/B1m96YJi6kpZEGg=; b=B6/bd89LcTUUoovK3YuQWLVVpUwLfcgpxxlrexZbPKFTF97HGqpW6FsXErkHEq8HNh gdBIj6i+rF7X6aazcrG2uFJ9GCWCecVkK0EtWktR8+xtrk7hqc7xw9UjBOM/ATifY8I0 53YXJ4xyw52kkiHIWRWHr6t9AJeVE4jJfioOeYMA4Md/fnJHN7Qj8p8jUhlxkX78l9qI D+DSci3XsXIDlDAPyoICmxXcFSn6B2dg5OFKLPtDw7l7pNO9qH58ldNR00AdaTHqe1Mv ThlrhruVjpMAcpIs23GzFh8J2LE7NOH+V3pP4lJfFO0e6Atq88k2hBfhmaS8ZmDy7Fgn QrSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v4si7477752edj.37.2021.02.19.08.07.16; Fri, 19 Feb 2021 08:07:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230124AbhBSQDm (ORCPT + 99 others); Fri, 19 Feb 2021 11:03:42 -0500 Received: from inva021.nxp.com ([92.121.34.21]:55742 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229862AbhBSQBv (ORCPT ); Fri, 19 Feb 2021 11:01:51 -0500 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 30002200113; Fri, 19 Feb 2021 17:01:02 +0100 (CET) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 1FBA52001B3; Fri, 19 Feb 2021 17:01:02 +0100 (CET) Received: from fsr-ub1664-175.ea.freescale.net (fsr-ub1664-175.ea.freescale.net [10.171.82.40]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 807ED2042F; Fri, 19 Feb 2021 17:01:01 +0100 (CET) From: Abel Vesa To: Rob Herring , Shawn Guo , Sascha Hauer , Lucas Stach , Fabio Estevam , Chanwoo Choi , Georgi Djakov , Dong Aisheng , Peng Fan , Martin Kepplinger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Linux Kernel Mailing List Cc: NXP Linux Team , Abel Vesa Subject: [RFC 07/19] devfreq: imx8m-ddrc: Add late system sleep PM ops Date: Fri, 19 Feb 2021 18:00:04 +0200 Message-Id: <1613750416-11901-8-git-send-email-abel.vesa@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1613750416-11901-1-git-send-email-abel.vesa@nxp.com> References: <1613750416-11901-1-git-send-email-abel.vesa@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seems that, in order to be able to resume from suspend, the dram rate needs to be the highest one available. Therefore, add the late system suspend/resume PM ops which set the highest rate on suspend and the latest one used before suspending on resume. Signed-off-by: Abel Vesa --- drivers/devfreq/imx8m-ddrc.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c index 33de83acfd8b..04347dee781b 100644 --- a/drivers/devfreq/imx8m-ddrc.c +++ b/drivers/devfreq/imx8m-ddrc.c @@ -72,6 +72,8 @@ struct imx8m_ddrc { struct clk *dram_alt; struct clk *dram_apb; + unsigned long suspend_rate; + unsigned long resume_rate; int freq_count; struct imx8m_ddrc_freq freq_table[IMX8M_DDRC_MAX_FREQ_COUNT]; }; @@ -271,6 +273,22 @@ static int imx8m_ddrc_target(struct device *dev, unsigned long *freq, u32 flags) return ret; } +static int imx8m_ddrc_suspend(struct device *dev) +{ + struct imx8m_ddrc *priv = dev_get_drvdata(dev); + + priv->resume_rate = clk_get_rate(priv->dram_core); + + return imx8m_ddrc_target(dev, &priv->suspend_rate, 0); +} + +static int imx8m_ddrc_resume(struct device *dev) +{ + struct imx8m_ddrc *priv = dev_get_drvdata(dev); + + return imx8m_ddrc_target(dev, &priv->resume_rate, 0); +} + static int imx8m_ddrc_get_cur_freq(struct device *dev, unsigned long *freq) { struct imx8m_ddrc *priv = dev_get_drvdata(dev); @@ -336,6 +354,9 @@ static int imx8m_ddrc_init_freq_info(struct device *dev) if (dev_pm_opp_add(dev, freq->rate * 250000, 0)) return -ENODEV; + + if (index == 0) + priv->suspend_rate = freq->rate * 250000; } return 0; @@ -412,10 +433,15 @@ static const struct of_device_id imx8m_ddrc_of_match[] = { }; MODULE_DEVICE_TABLE(of, imx8m_ddrc_of_match); +static const struct dev_pm_ops imx8m_ddrc_pm_ops = { + SET_LATE_SYSTEM_SLEEP_PM_OPS(imx8m_ddrc_suspend, imx8m_ddrc_resume) +}; + static struct platform_driver imx8m_ddrc_platdrv = { .probe = imx8m_ddrc_probe, .driver = { .name = "imx8m-ddrc-devfreq", + .pm = &imx8m_ddrc_pm_ops, .of_match_table = of_match_ptr(imx8m_ddrc_of_match), }, }; -- 2.29.2