Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp8225927pxb;
        Fri, 19 Feb 2021 10:24:17 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzELg402Aj2T+Iw98nLaCpS2BKMf+Pq6ZRKFNc9f9fmr9EMqJ28rd+vHY77VH7rFzcy4HnL
X-Received: by 2002:a05:6402:34d2:: with SMTP id w18mr10885131edc.102.1613759057132;
        Fri, 19 Feb 2021 10:24:17 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1613759057; cv=none;
        d=google.com; s=arc-20160816;
        b=v4aNMD+fFsTJMjRSRioICIsECPlRnnwtoBKFseJ/BiyjN/z3tkQoB4s3fB8iTF9ZeA
         q8/YsbX6+GU3h4ZD1Ar0nH+GP7xbUjWzLBl/VdDkWHyr/G6zbIW818LQuKSZMtx3jzG8
         e84KDmJ2sdnnSMrdeOIj6bZ3I8iUCEaEpZUUqrXlHVbFPHqtOA64wYYfFEQsOLoZawMX
         SzQMFf/b1pCMIK9rO95B84fEX+D6BIWu6dcYzbHFsf+T6+9EZvs350DgWt2vvqHwmI3w
         7O673F2Lr7Z1l7vETAOrp+OCNn34VjXn+asK2xg7ZeGB5EYTUxQDSUpu1zUqLlhW+Ccr
         QhxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=CTg2Lqg1Ed4/R0vELszvo30Qx+QCqKu4gpEbpNR5neM=;
        b=gNcZLvy8Ng/UtElqHwzmQusvPG7e+38CrXzx/Gf7LMraz7Pe8wa3PTENZD69EYmST3
         DAibnp5ByiRddc4lBqocjD3L9UgUIhbjKrwhIHSdzybkH1Optd6m2sWqpOaZBSiMA0Gh
         TJfAOkceon+K4Ou2N+fUBfGe++YnyDEBakTquQ8t1VTvGf8PJnM5ZgQgCRdMyT5JejdE
         B0y4nyD+3Qv6cXrsr/CAzdqwwUs+PTwKIFQMsErQv3tb/J+ulIr2PMHUftGkMk/sy4za
         OCH6KmuVWqLysEUVo6SnHea+kQKpQvNZASh2YersGtCwzjctUJG0sJNMbvC0HLisLkid
         TrHg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nyFNGPJF;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id y10si6207640eds.328.2021.02.19.10.23.53;
        Fri, 19 Feb 2021 10:24:17 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nyFNGPJF;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229845AbhBSSXU (ORCPT <rfc822;lphwiki@gmail.com> + 99 others);
        Fri, 19 Feb 2021 13:23:20 -0500
Received: from mail.kernel.org ([198.145.29.99]:45730 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229765AbhBSSXT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 Feb 2021 13:23:19 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id D7AEB64E4B;
        Fri, 19 Feb 2021 18:22:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1613758959;
        bh=lvf63DGkJR2fWgH6f/qu5f+xu+b9akz5C3bLJxhEu40=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=nyFNGPJFF/UKMapeJ9gM+Z3f++3DBwk6oyXh940tLUDw7DoyhMvbp9NW3PRSMdgr7
         uGwOaYD/2NqbPXkc6lkbKiAqwOLHfQNoGBfWK+KkSyk9tmAyGUwz6dtIhpiB/SAPQd
         fj6Y0CIBe+R1aQ0B+gGI8SRkJXTt+hO5xg3tupGNGMDz/t2fR9MubKtOce1c8UpooB
         NOgyartMYwQZtEdaQd88qzZK9fq6RL7HLv+iuy3hZRXstzn8DIWzfCvFNqBzZ22u6f
         oTaCnAJTg+QBJlYFdoFHP/MAIC0Uv7z5zJQYKp8qyPdZPwvClB2whlcyn3t1O1SDBK
         9R1eU0cKhx59A==
Date:   Fri, 19 Feb 2021 10:22:37 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Hayes Wang <hayeswang@realtek.com>
Cc:     <netdev@vger.kernel.org>, <nic_swsd@realtek.com>,
        <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH net] r8152: move r8153_mac_clk_spd
Message-ID: <20210219102237.024917a2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <1394712342-15778-346-Taiwan-albertk@realtek.com>
References: <1394712342-15778-346-Taiwan-albertk@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 19 Feb 2021 17:38:03 +0800 Hayes Wang wrote:
> Move calling r8153_mac_clk_spd() from r8153_first_init() to rtl8153_up(),
> and from r8153_enter_oob() to rtl8153_down().
> 
> r8153_mac_clk_spd() is used for RTL8153A. However, RTL8153B use
> r8153_first_init() and r8153_enter_oob(), too. Therefore,
> r8153_mac_clk_spd() needs to be moved.
> 
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>

Any word on what user-visible misbehavior this causes?

Can you provide a Fixes tag?