Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp8228401pxb; Fri, 19 Feb 2021 10:27:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUQ65foVTM/harZN5af8huZCHXBeMd8xhqBC2AK1JycAaGUXu2LHKxF3OskAory024mgLy X-Received: by 2002:a17:906:544b:: with SMTP id d11mr10150909ejp.167.1613759278281; Fri, 19 Feb 2021 10:27:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613759278; cv=none; d=google.com; s=arc-20160816; b=hwMZZ9YYnhPQbJd5MBxprI5zLLrCYDx+CgMW0fqCFE3ddWMhuHNvsse7B/QwHwZHXe U4k9VSKe4LvWsyRSnpOoZ2sdgFQL0POvac8xVBntQLmoDtVYvPmaZ7CerUgsUfrSkuMA ciLyzVlFoXu2F/gvw9ovtSlt9+5zRcOIJa+YmsYMmLztGQ9exvi68yrfztrph+/9GJ8N Hemkm2uiwwFQStqAw1l6JUlVDtegWm6R7S3O4mvJXem1nYopSfxCCMJZc0yMsB+oc34t 7IEhDpMP6UwDswClc3qXXICNlQ//92iGVAgXKAKmLBMHLa/whjug757a83Hg0C7YuEgF D1BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=INaW8+67y2Qr+AIhL2pM7hrEvl532xeKD+BY3hq66KE=; b=N4+WZ6TGIzqKGkmPvgl92tELBB94NJnUahn8gHgo3KA2SHZclqJGNaiOAn6/mqSIka Z5qEsPRBgxpQ8qQEMLrtyXD9jtJl4toNkOIulcDpf5SG5fbGFVoQve9xXK7+b0XjeUMe uPKtdXpLpVZsomZdX2QmBBxq8IMpRxa6WsO0E+WlOfdo/hRpoIIfBZ+KqgyvHTDxHwSp O8HBLK60j09qCM9Alz2mhxcdooQXeBqi08Tg+QgCNnXZTX8W/4SAAkTBJdQJ/SggYFy3 3nDCHdtaqp+0N9qUSfiahu/XpcHoSnIIlMLbuPGy9HIzkA+j0pEu6RJItl39bUEPW0is VhWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=ZeIXOuhZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l14si4370540ejq.503.2021.02.19.10.27.34; Fri, 19 Feb 2021 10:27:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail header.b=ZeIXOuhZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbhBSSYp (ORCPT + 99 others); Fri, 19 Feb 2021 13:24:45 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:15204 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhBSSYo (ORCPT ); Fri, 19 Feb 2021 13:24:44 -0500 Date: Fri, 19 Feb 2021 18:23:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1613759038; bh=INaW8+67y2Qr+AIhL2pM7hrEvl532xeKD+BY3hq66KE=; h=Date:To:From:Cc:Reply-To:Subject:From; b=ZeIXOuhZLe2y1vN9M39L7Bs8Vnq3W5g3wQeoAHeKPcVy5k4zNwxfUav5KXrBBHBSN UPTAbLBTbY5ni3uOkGp1CDe3o2CnQPXTL/npHxLfhwtIt+bJ91j86J9Jmjh61C4ISF 32boGRavG0K//mFdcGin2L/kPcaOrQtL5S/O9X+g= To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, straube.linux@gmail.com, dan.carpenter@oracle.com, d.straghkov@ispras.ru, tiwai@suse.de From: Kurt Manucredo Cc: Kurt Manucredo , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Reply-To: Kurt Manucredo Subject: [PATCH v3] staging: rtl8723bs: fix code style comparison warning Message-ID: <20210219182331.8-1-fuzzybritches@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org checkpatch gives the following WARNING: WARNING: Comparisons should place the constant on the right side of the tes= t this patch fixes the coding style warning. Signed-off-by: Kurt Manucredo --- changes since previous version: - put version chatter below the --- cut off line. thank you very much for your help Mr. Dan Carpenter. drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 975f2830e29e..96feced698ac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcu= r_dot11txpn, u8 *StaAddr) =09struct security_priv *psecpriv =3D &padapter->securitypriv; =20 =09memset(pcur_dot11txpn, 0, 8); -=09if (NULL =3D=3D StaAddr) +=09if (!StaAddr) =09=09return; =09psta =3D rtw_get_stainfo(&padapter->stapriv, StaAddr); =09DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", --=20 2.20.1