Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Feb 2021 20:11:14 -0500
From:   Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To:     Ben Widawsky <ben.widawsky@intel.com>
Cc:     linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
        linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
        Chris Browy <cbrowy@avery-design.com>,
        Christoph Hellwig <hch@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Jon Masters <jcm@jonmasters.org>,
        Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "John Groves (jgroves)" <jgroves@micron.com>,
        "Kelley, Sean V" <sean.v.kelley@intel.com>
Subject: Re: [PATCH v5 6/9] cxl/mem: Enable commands via CEL
Message-ID: <YDBhsntkwy249RYn@Konrads-MacBook-Pro.local>
References: <20210217040958.1354670-1-ben.widawsky@intel.com>
 <20210217040958.1354670-7-ben.widawsky@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210217040958.1354670-7-ben.widawsky@intel.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from Konrads-MacBook-Pro.local (209.6.208.110) by SA0PR11CA0163.namprd11.prod.outlook.com (2603:10b6:806:1bb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27 via Frontend Transport; Sat, 20 Feb 2021 01:11:17 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fc56d7a7-95fa-41e6-b32d-08d8d53c6e04
X-MS-TrafficTypeDiagnostic: BYAPR10MB3687:
X-Microsoft-Antispam-PRVS: <BYAPR10MB36876665CDA13FF7BCCBE90A89839@BYAPR10MB3687.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: F8pYeTKel57B5fhxrrMbnLvecEB0K9E6SaUFUHehDMFpTsxyvSjttatPeBzNtnJftXw7LQvRVFEv2BjUpWo7iyb6ULfqSP6lFFKDcSKFdV0Wyt7NJhLQuu6fW5tV9VyQsK6RlHBp+jWuTu+Q3iH90en+XxiGzq/ipSaG/me6Ya+6asp6QKeg0vm+KeU5dUD9cTdxwJ5ERetpA0K7ZDBI0q73rZXELa2LOaexZ9lPRRAcgqwSQuNpxcYRIcgw+lcH2IsEd17EAlEF4KCwCGarq2Qp3aLmrXTYbpU3ojgE1a9A40IVqAmoAPbTB50ae1+SjSq2duJRMQAmrGI5HNAsLTDLZpI9pJgxx/pdMqrBgAzhPV8UFp0mrn1hzJn7KOHZIAuU30Q8xTggFQYYkz6y9R+X1pPI4vk7bIP0TT5PzF3fWeG9vs05ZNdnYh/k6Z2sN7dZYnJ3Iu+GqpNab1E9Z0AJkOjgWB5UOYQqL7y5F33jTrY+sYN5B2hve02C2Vg9qBxlOx6o8zdSa35ByRDETg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(396003)(366004)(376002)(346002)(54906003)(66946007)(478600001)(5660300002)(66476007)(55016002)(4326008)(4744005)(66556008)(7416002)(956004)(86362001)(7696005)(6506007)(26005)(2906002)(9686003)(316002)(8676002)(186003)(6666004)(16526019)(52116002)(6916009)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?g568jt9AhGBZewf8RylOzJWZ43K2ePxHODBJ2/NNotmLmXnoDuQtP0LMNl5C?=
 =?us-ascii?Q?eKQWvK5Af1ypp7Lv2sLpt+WLicmifl1NxvgYvPGylJj+X/GFpG1vLI+vEvjs?=
 =?us-ascii?Q?mSOUFV7oEW8sNANS+VZ7YZAkV7OGqjeq750CbFvX26+BZzFtghUKms/0yQXr?=
 =?us-ascii?Q?IAgR4/xiNHl9blvtQHnsxA/0icFg9w5zWD2CumRKit99Mo3Y2INcn7P14Wqs?=
 =?us-ascii?Q?zYp7bD+6jhXAH4NzNHD8vffaSp7Ty3CKaThgjmxeYsFpAubxUrMj3xLgnh2J?=
 =?us-ascii?Q?wcP9JLHjrQvue6Q+7F8Cz2AVWHEPRnjVzE38LYCny2UAWd2poTVfbCV9OGJa?=
 =?us-ascii?Q?gOinsGGuM5yTMRSlItIZfMJtaL8+677KPBCWXc0ADfoXUiJIqztms2QS0S6R?=
 =?us-ascii?Q?WTKWAu9SPejCiioIcb4UM8bJfDcPnD4LlcKTdLsUqmw9ikwEspIn30cRjx+q?=
 =?us-ascii?Q?RYPePgOqn8IPF3USKI0BOddSnBJkvSIVj1Oh53q8qmLQCcpu4inUgYAZ31KU?=
 =?us-ascii?Q?UjnTCNQXgdJb+kJUwdziB1a5FzD4XbBpKMIxef6/ClKaSNFSj/b7bK1M1ROT?=
 =?us-ascii?Q?FcUTOK2vYMCKo8fOu5uyO6ocWaJjFamxl2BaBq5iMHc6di8z5de7gW419RZs?=
 =?us-ascii?Q?iZT/qo4H5r30WlqpMrEDueaPpevxDnTBZ7GP7Sj3ED3fLtaPddOELTs9UFp1?=
 =?us-ascii?Q?n8UaTbUMPuh0sJooj2GhM8dMWqxybeXm7F9Rg7uB8m78PyressikQ9D8oWcL?=
 =?us-ascii?Q?ABwjwxjePiYnSn/ZiOQbxWCE5BT207MHFpSt8TLDqku+rig0dXqCV7ykvLjE?=
 =?us-ascii?Q?uZx70mdFQiBDAu0Dg/aOMCtZQJr0VVga4ogEHFg6rv1bRve8wGAi0M+WtCWe?=
 =?us-ascii?Q?8CqPsvldkQIsdbVZhFs7EbyrElbTmrjsyXad0ARZ3teE9M0gn9fshZvy2ict?=
 =?us-ascii?Q?tuozxm2bX7TmCJ6lrADELfZPkk5l7FIRUqKo8tLMRKFL82JlHB3RH9J+tDVe?=
 =?us-ascii?Q?i4BTuwOiuw7wZTZOKLvoP8znWNgLBpEG9RWgu7QhwtNC7je7z2yOpTVKw429?=
 =?us-ascii?Q?0V3wqxfCpUvGJF8lnZAv4+7TJPioOywFaT23uxoyto9Irs6bzcxRnTavyO/Z?=
 =?us-ascii?Q?CNU82Z8aC/bocWH1xs8MlkVqotLWCA+DK7EylDLjP7nE9wZgRuJQdnaX6Hrb?=
 =?us-ascii?Q?QvuBeEtQPTJMrJFrJ1/oRbjK6hnVacQF5yxRFjapW/L+csFEZOJHxoiQYNlx?=
 =?us-ascii?Q?uQexD2luL+pPp/EHgRaogVig1xaJisZHg1q8yh4BiuYnwQykPecNTxVKyVhG?=
 =?us-ascii?Q?fz9V1GonRE1O2RLdrYlgw1nm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc56d7a7-95fa-41e6-b32d-08d8d53c6e04
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2021 01:11:19.5040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GCsod83ZHd5AKIAS0Fx7FLwsGcCmsB4cDJJFYHbMdDQSY/iKrnfs+hpZdTlKWgeTCcMigzLSxEJPJYruVvIr2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3687
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9900 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 spamscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102200005
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9900 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0
 priorityscore=1501 lowpriorityscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102200005
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +static inline struct cxl_mem_command *cxl_mem_find_command(u16 opcode)
> +{
> +	struct cxl_mem_command *c;
> +
> +	cxl_for_each_cmd(c)

Would you be amenable to adding {
> +		if (c->opcode == opcode)
> +			return c;
> +
and } here

(and in the code below as well where cxl_for_each_cmd is used?)

Regardless of that:

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>