Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Feb 2021 20:12:07 -0500
From:   Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To:     Ben Widawsky <ben.widawsky@intel.com>
Cc:     linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
        linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
        Chris Browy <cbrowy@avery-design.com>,
        Christoph Hellwig <hch@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Jon Masters <jcm@jonmasters.org>,
        Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "John Groves (jgroves)" <jgroves@micron.com>,
        "Kelley, Sean V" <sean.v.kelley@intel.com>
Subject: Re: [PATCH v5 7/9] cxl/mem: Add set of informational commands
Message-ID: <YDBh5+NfeN+rI1VA@Konrads-MacBook-Pro.local>
References: <20210217040958.1354670-1-ben.widawsky@intel.com>
 <20210217040958.1354670-8-ben.widawsky@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210217040958.1354670-8-ben.widawsky@intel.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from Konrads-MacBook-Pro.local (209.6.208.110) by SN7PR04CA0011.namprd04.prod.outlook.com (2603:10b6:806:f2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Sat, 20 Feb 2021 01:12:10 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ed1b8b82-d009-42f1-f03b-08d8d53c8dca
X-MS-TrafficTypeDiagnostic: BYAPR10MB3687:
X-Microsoft-Antispam-PRVS: <BYAPR10MB3687D71BA804161E97267A9A89839@BYAPR10MB3687.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:281;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1gCDsORCne9zfZgS4on8TWtYsbndy6iB6hZmE1er4906BF7XX6YzAk9Pa1vFCExmgw0Wg0jEGDgCqaUVBUnSpvO878t6hC6noPn+YaXnV6XIDZrOLml33FcV04ixjVolw4jzm24yEyvwERtowuG+DKCO1/yLv/S65tPV5eF/dKG68F9oSVJybX8r1+pHwGHRwU6crF+9Bfkr1wiYsMoDvQqXv1xcOEiqhnlBerde/7QEhB6bIlFewtVpK8+/nMwodLd64PRtGgs8nWBkrxfn0uKWom0jCSwNbHe8gX8bnoPaQKGA92zf8scJOXBr8XZU2h/chrT2BafDAOdIPe16+jN6p7snMQWujq2SnJREIURvyFfF3voKpz475azBWk28KjZ5VCB9y1nCKL+2/UISMptgAPySr68PxUeUZasgtnwtHo5VBpwXzIYzTqbe4LhkdRzzlAzIeKxVbZ6fiSAylPx1bY4jWLn0Tr+bvxV1MSPQBe+oPr++wKfjF8S8/o8cKVCQvfaUrEzhIQfw13rzrg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(396003)(366004)(376002)(346002)(54906003)(66946007)(478600001)(5660300002)(66476007)(55016002)(4326008)(66556008)(7416002)(956004)(86362001)(7696005)(6506007)(26005)(2906002)(9686003)(316002)(8676002)(186003)(6666004)(16526019)(52116002)(6916009)(83380400001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?/MJVIfpZabD1Eq5rIF6PXMUnM/+MNueyWFvx0BN7y5uWBdo0wv01Y2BF26kK?=
 =?us-ascii?Q?pUhEGw6QMG0JOhi7r18IpaQeH7U1QtppUKId6Uq6E6bcpVAjNaDy1DGcVbLf?=
 =?us-ascii?Q?yutfLMOMmgVslD3oxYmvqLeswUHtWD/3SDLYZKFguxmpxpSsY7O2sGKz3Swz?=
 =?us-ascii?Q?FWK6qtKw6fB+UHprug8SvNK0jxSWidCvJ1j4N0lhiF5qa0HQOqcqIDyqLw8F?=
 =?us-ascii?Q?l+pUSqJIkI3zAeH19c+ZfBN9AdjudbJadk4wPPMjKM3thLVdH5AUjoau0PGg?=
 =?us-ascii?Q?usu2P1K2k70Ggn6fNLCk2K3U9hHDMb6b/N3QH+8/h7tAzL01chKVZtGa81nd?=
 =?us-ascii?Q?MYRxg2gmRXaSPRj03qY4VNFoL5WDFzGa/TNxuRPxpgXNPNdQaRZlLe5OlFq0?=
 =?us-ascii?Q?pJcgsX111Gwjyb4/OABToZ7l9n8JQbMrFV0qSErxaoCRzlCX1nCsuaEMe5KD?=
 =?us-ascii?Q?qeHpkrLAF+bv+1VXGnaKQjCPmyflVO8JfctA0SbZ0XB36Ju/XpbIf1k5ido2?=
 =?us-ascii?Q?Akg1NBWmi2y+SF7zYXeDG1rNPsYu2gS0yI7r//OmuBMzGAvTIupF16WSglz1?=
 =?us-ascii?Q?x6ycIaZ8r1MZrFeGY3DnwA7wET6tF5qb8Ow3RMF8ThymihdWYBVfArzFinuy?=
 =?us-ascii?Q?kth2h20Fv9ttsHuggxsf1lxxk9al+t4IrGkv999ZFWPjXVir5puHoxsexFsh?=
 =?us-ascii?Q?y2tPEQXkB6/Ca5WRJ9fgg+XtumWK8ugbEaZlrFWmoPyTLcDMHMeAZDAxZ2zb?=
 =?us-ascii?Q?aZU5lnYFhLQaxbhEDJoVhgD0CCCvFL4HN4IbWMCd7PRCADx6eWPCzFGkM++T?=
 =?us-ascii?Q?8TH1ZonIu7CV2Pp5l2BMHFA0QaLpbQauJcMYmsQ6juqdsLuuZVDpmjGj1ayB?=
 =?us-ascii?Q?XDq7qKN3ZJAPT5eop/SiQfgfkOYU6beXcSXdwfJhKcOKhOOrmdK7dDHHQCnT?=
 =?us-ascii?Q?7mwCALvFk1JA+hQC9ufuLfCY9h3Srz9IXDM35PiQlhsU/jITevFDiZWOXGFu?=
 =?us-ascii?Q?PEMGHyU4Y0bOBFDmIA779JAwuCwpTYv5P3utUVafsgSU4IPw0oF9VFdaxZKg?=
 =?us-ascii?Q?e7ba8dnh+1M3rMFLbXHFmf2kbe9Gugjp3Jyv4xGbY2l/982NpP+YE6CxPW4K?=
 =?us-ascii?Q?nhpuyUtHab4ZBAepwi+hTKT5oc4NSxzaBO09NMu3MVU/XhjNuyf2qLKQZ0Hy?=
 =?us-ascii?Q?0N5lJ9Mhqq5N01SGPU/ElpwAUEYxhBCmO+RV4JxlKCnEEGKgpNHxl4e/vBBq?=
 =?us-ascii?Q?aRdoPuCTbNk3RJlTXDymzrm+4EuMJ7TyLFD5HEf+lQLMx6TW1EnWs18SocVn?=
 =?us-ascii?Q?5GWBNROuHUtGgN7p4EfAG/9l?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed1b8b82-d009-42f1-f03b-08d8d53c8dca
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2021 01:12:12.8365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8OMb/mwQYyf3LcCtUyWyzx27/92v1R2TIchaLYZO05MGyOcAdJPwBijdV+p79UazJFxfODFndCye8KPb5m5evQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3687
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9900 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxscore=0
 mlxlogscore=999 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102200005
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9900 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 impostorscore=0
 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0
 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102200005
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 16, 2021 at 08:09:56PM -0800, Ben Widawsky wrote:
> Add initial set of formal commands beyond basic identify and command
> enumeration.
> 
> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> (v2)
> ---
>  drivers/cxl/mem.c            | 9 +++++++++
>  include/uapi/linux/cxl_mem.h | 5 +++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c
> index e31b3045e231..6d7d3870b5da 100644
> --- a/drivers/cxl/mem.c
> +++ b/drivers/cxl/mem.c
> @@ -45,12 +45,16 @@
>  enum opcode {
>  	CXL_MBOX_OP_INVALID		= 0x0000,
>  	CXL_MBOX_OP_RAW			= CXL_MBOX_OP_INVALID,
> +	CXL_MBOX_OP_GET_FW_INFO		= 0x0200,
>  	CXL_MBOX_OP_ACTIVATE_FW		= 0x0202,
>  	CXL_MBOX_OP_GET_SUPPORTED_LOGS	= 0x0400,
>  	CXL_MBOX_OP_GET_LOG		= 0x0401,
>  	CXL_MBOX_OP_IDENTIFY		= 0x4000,
> +	CXL_MBOX_OP_GET_PARTITION_INFO	= 0x4100,
>  	CXL_MBOX_OP_SET_PARTITION_INFO	= 0x4101,
> +	CXL_MBOX_OP_GET_LSA		= 0x4102,
>  	CXL_MBOX_OP_SET_LSA		= 0x4103,
> +	CXL_MBOX_OP_GET_HEALTH_INFO	= 0x4200,
>  	CXL_MBOX_OP_SET_SHUTDOWN_STATE	= 0x4204,
>  	CXL_MBOX_OP_SCAN_MEDIA		= 0x4304,
>  	CXL_MBOX_OP_GET_SCAN_MEDIA	= 0x4305,
> @@ -171,6 +175,11 @@ static struct cxl_mem_command mem_commands[] = {
>  	CXL_CMD(RAW, ~0, ~0, 0),
>  #endif
>  	CXL_CMD(GET_SUPPORTED_LOGS, 0, ~0, CXL_CMD_FLAG_FORCE_ENABLE),
> +	CXL_CMD(GET_FW_INFO, 0, 0x50, 0),
> +	CXL_CMD(GET_PARTITION_INFO, 0, 0x20, 0),
> +	CXL_CMD(GET_LSA, 0x8, ~0, 0),
> +	CXL_CMD(GET_HEALTH_INFO, 0, 0x12, 0),
> +	CXL_CMD(GET_LOG, 0x18, ~0, CXL_CMD_FLAG_FORCE_ENABLE),
>  };
>  
>  /*
> diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
> index 59227f82a4c1..3155382dfc9b 100644
> --- a/include/uapi/linux/cxl_mem.h
> +++ b/include/uapi/linux/cxl_mem.h
> @@ -24,6 +24,11 @@
>  	___C(IDENTIFY, "Identify Command"),                               \
>  	___C(RAW, "Raw device command"),                                  \
>  	___C(GET_SUPPORTED_LOGS, "Get Supported Logs"),                   \
> +	___C(GET_FW_INFO, "Get FW Info"),                                 \
> +	___C(GET_PARTITION_INFO, "Get Partition Information"),            \
> +	___C(GET_LSA, "Get Label Storage Area"),                          \
> +	___C(GET_HEALTH_INFO, "Get Health Info"),                         \
> +	___C(GET_LOG, "Get Log"),                                         \
>  	___C(MAX, "invalid / last command")
>  
>  #define ___C(a, b) CXL_MEM_COMMAND_ID_##a
> -- 
> 2.30.1
>