Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp214680pxb; Sat, 20 Feb 2021 00:59:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5PiBX+I61cgkMhIB51Co/SZSW96NBI7CLgvUzDr+hPX9X1Y1HxERkKKcLPEswsCYkC+z9 X-Received: by 2002:a17:906:2747:: with SMTP id a7mr12813480ejd.250.1613811551623; Sat, 20 Feb 2021 00:59:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613811551; cv=none; d=google.com; s=arc-20160816; b=u4lTgal3nkKQ3dbt+cgYr1HzSKe4MO+uPwhCbFabc0ZvzSYF3MSV/innOXNo5yZu+G NCiyNIkzR7hYA5S9TXwKYQ+Hk/MV7k1FH8CrmR1G24LTNBwwzMyTV6zjL7ngxn1njnsX ZnQTxo9fWj20FUoKppLBSAwyjcD32xtaG3EpjwZDVYs74E9aWf6W9TSJJB3gVGY3ftYa z7rHKh4ZWtzDhjCPH66r48vYvN1SyXBufZ1L9zz3mqORTeGEmPfkAkBbXKckjuFt8Lrl 8Tfn9DF7w0gayyrzngUmo2RPCevlY/LNb/uZnKf/1mMUdhLYEaiUjtd7i3090pqRFgyu F1oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=VhuwPJmiUg69jPY6JTvEhj7E7UAQVgmwqKai2wNE4Yg=; b=bM5lXQl+FNhAhp/jTIz4Yn2EO03hUHxn+TCWc9EbCrbVU9ZEhOMeTGVIx97ap17+S7 O1S7YiFVWTgwYTkRSUwMn8CBSHx8VlG1t/BiylWA6u71UOFXiONUOrlDnv1+h+yo4YQN ILPsaB9L4WFhx/sHeMs21i+Hof5geHIobDfXteXDqliWUI124ohAInCEdB2PaixPcLSB xbVQfRGXIx4Q3QvYOA8snt5zrFVJ2jxCpFwUP57MlpJhPi5ycl7yDcQOzF7q2DXqpIgS lpxQSU8PuBOjnD7yUiigIaVJgeRSa+Bbjop3iPz4CADxDO8tDRYSma7GOT0Wm4eTY0q1 MKjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h27si8647860ejd.660.2021.02.20.00.58.47; Sat, 20 Feb 2021 00:59:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbhBTI6V (ORCPT + 99 others); Sat, 20 Feb 2021 03:58:21 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:36284 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbhBTI6U (ORCPT ); Sat, 20 Feb 2021 03:58:20 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UP0IAvR_1613811457; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UP0IAvR_1613811457) by smtp.aliyun-inc.com(127.0.0.1); Sat, 20 Feb 2021 16:57:37 +0800 From: Yang Li To: mpe@ellerman.id.au Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] powerpc/sstep: Use bitwise instead of arithmetic operator for flags Date: Sat, 20 Feb 2021 16:57:35 +0800 Message-Id: <1613811455-2457-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccinelle warnings: ./arch/powerpc/lib/sstep.c:1090:20-21: WARNING: sum of probable bitmasks, consider | ./arch/powerpc/lib/sstep.c:1115:20-21: WARNING: sum of probable bitmasks, consider | ./arch/powerpc/lib/sstep.c:1134:20-21: WARNING: sum of probable bitmasks, consider | Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/powerpc/lib/sstep.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c index ede093e..e568cc5 100644 --- a/arch/powerpc/lib/sstep.c +++ b/arch/powerpc/lib/sstep.c @@ -1087,7 +1087,7 @@ static nokprobe_inline void add_with_carry(const struct pt_regs *regs, if (carry_in) ++val; - op->type = COMPUTE + SETREG + SETXER; + op->type = COMPUTE | SETREG | SETXER; op->reg = rd; op->val = val; #ifdef __powerpc64__ @@ -1112,7 +1112,7 @@ static nokprobe_inline void do_cmp_signed(const struct pt_regs *regs, { unsigned int crval, shift; - op->type = COMPUTE + SETCC; + op->type = COMPUTE | SETCC; crval = (regs->xer >> 31) & 1; /* get SO bit */ if (v1 < v2) crval |= 8; @@ -1131,7 +1131,7 @@ static nokprobe_inline void do_cmp_unsigned(const struct pt_regs *regs, { unsigned int crval, shift; - op->type = COMPUTE + SETCC; + op->type = COMPUTE | SETCC; crval = (regs->xer >> 31) & 1; /* get SO bit */ if (v1 < v2) crval |= 8; -- 1.8.3.1