Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: lFj1AzefuRA5ACqTegbYsNQqx8EwJlr+RDD2JB3lQLLmBF8M/F9/XMqEWqUSjOPh6qzhgSMDbt
 OpKzNW92946g==
IronPort-SDR: 9adtJopHLObI4Buw1EoCxcKSFXrM6VkDSAQxB4py9rQVCnGk4bB+hKlo2vcqMwfKTEZH4ybIjp
 cRDL7Ap/sFWA==
Date:   Sat, 20 Feb 2021 17:48:42 +0800
From:   Shuo A Liu <shuo.a.liu@intel.com>
To:     Yejune Deng <yejune.deng@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virt: acrn: Use vfs_poll() instead of f_op->poll()
Message-ID: <20210220094842.GB30008@shuo-intel.sh.intel.com>
References: <20210219092612.7533-1-yejune.deng@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20210219092612.7533-1-yejune.deng@gmail.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Precedence: bulk

Thanks for the patch.

On Fri 19.Feb'21 at 17:26:12 +0800, Yejune Deng wrote:
>In acrn_irqfd_assign(), use vfs_poll() is a more advanced function,
>as the same time, modify the definition of events.
>
>Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
>---
> drivers/virt/acrn/irqfd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
>index a8766d528e29..19890396e174 100644
>--- a/drivers/virt/acrn/irqfd.c
>+++ b/drivers/virt/acrn/irqfd.c
>@@ -112,9 +112,9 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, struct acrn_irqfd *args)
> {
> 	struct eventfd_ctx *eventfd = NULL;
> 	struct hsm_irqfd *irqfd, *tmp;
>-	unsigned int events;
> 	struct fd f;
> 	int ret = 0;
>+	__poll_t events;

Can you keep variable declarations is reverse fir tree order which this
driver follows?

>
> 	irqfd = kzalloc(sizeof(*irqfd), GFP_KERNEL);
> 	if (!irqfd)
>@@ -158,7 +158,7 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, struct acrn_irqfd *args)
> 	mutex_unlock(&vm->irqfds_lock);
>
> 	/* Check the pending event in this stage */
>-	events = f.file->f_op->poll(f.file, &irqfd->pt);
>+	events = vfs_poll(f.file, &irqfd->pt);
>
> 	if (events & POLLIN)
> 		acrn_irqfd_inject(irqfd);
>-- 
>2.29.0
>