Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210219092612.7533-1-yejune.deng@gmail.com> <20210220094842.GB30008@shuo-intel.sh.intel.com>
In-Reply-To: <20210220094842.GB30008@shuo-intel.sh.intel.com>
From:   Yejune Deng <yejune.deng@gmail.com>
Date:   Sat, 20 Feb 2021 19:00:10 +0800
Message-ID: <CABWKuGXT25bZQT3Ct7eEHsQYrWcfq3kuB6stWh5-MDgDRWNFTw@mail.gmail.com>
Subject: Re: [PATCH] virt: acrn: Use vfs_poll() instead of f_op->poll()
To:     Shuo A Liu <shuo.a.liu@intel.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

OK=EF=BC=8CI will adopt it and resubmit.


On Sat, Feb 20, 2021 at 5:48 PM Shuo A Liu <shuo.a.liu@intel.com> wrote:
>
> Thanks for the patch.
>
> On Fri 19.Feb'21 at 17:26:12 +0800, Yejune Deng wrote:
> >In acrn_irqfd_assign(), use vfs_poll() is a more advanced function,
> >as the same time, modify the definition of events.
> >
> >Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> >---
> > drivers/virt/acrn/irqfd.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
> >index a8766d528e29..19890396e174 100644
> >--- a/drivers/virt/acrn/irqfd.c
> >+++ b/drivers/virt/acrn/irqfd.c
> >@@ -112,9 +112,9 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, str=
uct acrn_irqfd *args)
> > {
> >       struct eventfd_ctx *eventfd =3D NULL;
> >       struct hsm_irqfd *irqfd, *tmp;
> >-      unsigned int events;
> >       struct fd f;
> >       int ret =3D 0;
> >+      __poll_t events;
>
> Can you keep variable declarations is reverse fir tree order which this
> driver follows?
>
> >
> >       irqfd =3D kzalloc(sizeof(*irqfd), GFP_KERNEL);
> >       if (!irqfd)
> >@@ -158,7 +158,7 @@ static int acrn_irqfd_assign(struct acrn_vm *vm, str=
uct acrn_irqfd *args)
> >       mutex_unlock(&vm->irqfds_lock);
> >
> >       /* Check the pending event in this stage */
> >-      events =3D f.file->f_op->poll(f.file, &irqfd->pt);
> >+      events =3D vfs_poll(f.file, &irqfd->pt);
> >
> >       if (events & POLLIN)
> >               acrn_irqfd_inject(irqfd);
> >--
> >2.29.0
> >