Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp527763pxb; Sat, 20 Feb 2021 11:45:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIc7BGL9pjpIKgH2HFZHJFAcaQzPYkAleKJxoEmePUj+Nme5eneBO3Ma9rTyXqlpuXPnOj X-Received: by 2002:a17:906:380c:: with SMTP id v12mr14073805ejc.65.1613850331939; Sat, 20 Feb 2021 11:45:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613850331; cv=none; d=google.com; s=arc-20160816; b=TcLXWzzsXi+qtGx7yo5xIMNoOWBOvODQKgJQn3oFTfWyzxcMLHpxSWrYJD6kRSLBIv Ld+zf5OWa7G1W+4U7qFkOP0PprLkRrqHSLox/61g5SO/r6eLDkbT9/rBwAvUb9r+ReBy 14uaqzS6j2kJo5CaX16u9l4Zsk/N561PYCl7/392UOo3xq1v1qdp+N70dX+Sd7VkcA0C qEhzdD84Duc/4fCz5ty6tw+l6LSO+e9Q+mh3ao89R6ElcdTd00Egk3M387BqMvFgToib og0iCB51QOI/F1IrHbm4sn38Eqg65aD29R5SCRcNP/L62Lqoz78XRyXCZZvymzwR07F9 8rTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=bbl0U1BqP+74XymO/Vt2V4DaA6lRJDs9m/sWTk8oKBM=; b=YV6nqgmBzmgkEjwTMjigGfvDDtbjDz67NJjzxt1HjfSIEVJxVIOLLqkU2Maj13MMID 6303TID5SXet9gLND7KfV1wQog3GW3g9y4OwVVzz6NN/MiM5n9ReIYcj76bSRNgwgth3 WcrtgbPGgXUIgoU5o+6LLpHyDMH7QekBEuUmRztUkA7kx+HgT9AF2Ef1jd9u1HHztCbz X3Sq8vWMkmDM0OCy3+gSLoJ68i4ZvD3Kdymir+q8a9FmRmJjoUTdzv4mTRZ3/4IdzrHc 0JDftRzqWM8LdIapzW28mXGcYnj8OUTsOZAGsTz3fsH9EnYjfrJ1MrfnWC3YNlCVrxZ/ 28gQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v5si10290073edi.63.2021.02.20.11.45.09; Sat, 20 Feb 2021 11:45:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbhBTTli (ORCPT + 99 others); Sat, 20 Feb 2021 14:41:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229828AbhBTTlf (ORCPT ); Sat, 20 Feb 2021 14:41:35 -0500 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF183C061574 for ; Sat, 20 Feb 2021 11:40:54 -0800 (PST) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lDY7V-00GPdn-Ie; Sat, 20 Feb 2021 19:40:49 +0000 Date: Sat, 20 Feb 2021 19:40:49 +0000 From: Al Viro To: Linus Torvalds Cc: syzbot , Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, snovitoll@gmail.com, syzkaller-bugs@googlegroups.com Subject: Re: WARNING in iov_iter_revert (2) Message-ID: References: <0000000000001fb73f05bb767334@google.com> <0000000000000ca18b05bbc556d6@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 20, 2021 at 07:29:57PM +0000, Al Viro wrote: > And then you notice that it has reports > successful write of amount other than what you'd passed and tries > to pull back. Sorry, half-edited sentence has escaped ;-/ Should be "And there the caller notices that callback has reported a successful write, but the amount apparently written is not the same as the amount it had asked to write. It interprets that as a short write and tries to pull back. Only it's actually _forward_, since we'd asked to write 0 bytes and got a small positive number from the callback."