Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp681204pxb; Sat, 20 Feb 2021 18:44:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJyHiY4mbYn7L5y14X8rUjrAW653H++ofBbIVeaaNxCWmCAzcGiyVt7MrgmzKsCC+NsR5JCt X-Received: by 2002:a17:906:4e1a:: with SMTP id z26mr14966116eju.349.1613875454307; Sat, 20 Feb 2021 18:44:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613875454; cv=none; d=google.com; s=arc-20160816; b=Ul2GXowOT/IqzKTlNXz2CciudESIfsJHiR3FfXHUW9w3amkEnGYPzTFgTHwphywcJd kuymy0siT7kHNETmCs1GgGUy9TI/8QEWuS4VUtfOqw95Q0FbGVDrftIhK76Irgvpl+/1 Xmuii/knSYA0LLAVkLrxgBckKWFoZ2va4RWX+5y+lzqTRDZpBd/UI5i+d0KdI/uMKZX7 NX4q/IL8UdIJwzQ/8F/rxvQPhdh/o8bhMTmiCvYOHtigp9hYFQ794vtn8UuI7hl8bRkS zKtzZVYH41C/lj1YU6z/xLeOt7zkGj4m1XPpnDLmCQP+3yA+meQcY8C0kYNlpQPe2P/v WQhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=9DSCLn/PrHDgQxuXaE9iO1VKgiKTdkzQgivDM+i6TiI=; b=PiBIlQ0hn5qVFWv8NjoK+nCcDRSA9NbuDqJv5m4SWM5huI2/uDedrkDg4Z00JUI+b0 uFu1NTioCrcxSovPPY0jOacT2+9JXimMucTqJ5miqvnOD1j+VqH7XoR6D/VlZTvrgXq5 vrrLWFmRA6kXt1QsV7bZioa2VbJnGuEwJUeB1rFk0oyfm40AXWnJ/pzBqWyBghZU98CF Xb9ZBevv06jmwzti568tuwKFtmxccfp1SG3tNVYyRx56e3N+QZefSqIsE16ZeyjOR8Dc BRgVlmc9Y9gjdkmFUEgdE/LLdheRKSf3hj+MRqSqRmuoLeOrw4eWc2k8YaURglfmpwQt cGuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pAsC6+Nu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jz9si8616296ejb.510.2021.02.20.18.43.51; Sat, 20 Feb 2021 18:44:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pAsC6+Nu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbhBUCfI (ORCPT + 99 others); Sat, 20 Feb 2021 21:35:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhBUCfI (ORCPT ); Sat, 20 Feb 2021 21:35:08 -0500 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFDD1C061786; Sat, 20 Feb 2021 18:34:27 -0800 (PST) Received: by mail-il1-x136.google.com with SMTP id p15so7910140ilq.8; Sat, 20 Feb 2021 18:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9DSCLn/PrHDgQxuXaE9iO1VKgiKTdkzQgivDM+i6TiI=; b=pAsC6+Nu9a+OFTwOmiQl0T1fUtPEtgE0JiOVylivL1IqigBvp6aXavQiufg+QSz60K 5XeHZFu0+pKNTdenU/SWYmuan+YW6/Xc7VARY86ABYThRCUtkTDaDDHVxZHPE/R6lyMe U9OxWYGtfZN/i9NOGm8dWxMd1siFxMiRiNy6yPxHYwzz7dBcFETxWYHCRtyb8erBAvdt 5mpFsoxFPkgF41+3cKLval8A45uasutmCShKNtViBCWbnSo8tTFj2fzcyrfAs8xxatMQ t+4JIbFD7i9QcpJpyBZfSIzqkNGu2XL4/oVcFiFnpyN9Ye/wid7m8okgBmAYomS3AfFU CRgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9DSCLn/PrHDgQxuXaE9iO1VKgiKTdkzQgivDM+i6TiI=; b=AeXCLH4RSJwhJ23uv7Y1Plj79M4OBrHS/pIESVXF8yUJJAfSdI9FKr4SI59v3piKas x+lkSD0MPflC/IDsaHxGJSYLUyTy+RBeESywa4RyXpn15UleGZ7fKqDt52MSAJQWGLvX spodMkJNjIbfIPSHdpWcR5P+BrZHbmhlxjsP5OFGvw3cGVOrtV2UOprTXZbWCHTOFReJ AssvKAKvBIA7/auWB+glxZouhCL2c+r39wA/o2mo6D26lEJv/GRu1CYTDUiW9lEJseYM JHUkvoL6K402YUcnIbbe0dmo+Y7py13uF7z0vy2NtwxNN3sQyhGpx1T4NnPempI1gadK acpQ== X-Gm-Message-State: AOAM532lueYUv+GwW5fZYK4YZG1i+PqBEYb4W+5nNCdUwPavI4KRfuHF FpjzZy48whR50EXuA/fdUcRVcg2RMKlpmKkhHEj5ii02oh0= X-Received: by 2002:a05:6e02:1bad:: with SMTP id n13mr9438794ili.260.1613874867390; Sat, 20 Feb 2021 18:34:27 -0800 (PST) MIME-Version: 1.0 References: <20210221000024.358772-1-ztong0001@gmail.com> <6b35b3b2-a746-9524-3a19-82ee73427ead@infradead.org> In-Reply-To: <6b35b3b2-a746-9524-3a19-82ee73427ead@infradead.org> From: Tong Zhang Date: Sat, 20 Feb 2021 21:34:16 -0500 Message-ID: Subject: Re: [PATCH v2] video: fbdev: pm2fb: avoid stall on fb_sync To: Randy Dunlap Cc: "Gustavo A. R. Silva" , Sam Ravnborg , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 20, 2021 at 7:36 PM Randy Dunlap wrote: > I suppose the rest of the patch is OK since it works for you. > > I don't know any of this code. It would be nice to know what some > of those pm2_RD(par, SOME_REG) mean so that I could sort of > understand what it is doing, but don't go spending time on it > just for me. It's not worth doing that IMO. > > > -- > ~Randy Thank you Randy. I have sent another revision. I am also curious about those registers -- but it is hard to accurately figure it out without datasheet -- my speculation is that it calls the device to do some sort of frame buffer synchronizations here Thanks, - Tong