Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp689360pxb; Sat, 20 Feb 2021 19:08:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJy33aYaoIf1Va34WyF8j8mqx5ovCKIgratx8ncPylm3RVuWsu5TRt5eiIKaadE89KgcEMyl X-Received: by 2002:a05:6402:46:: with SMTP id f6mr16272379edu.163.1613876891969; Sat, 20 Feb 2021 19:08:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613876891; cv=none; d=google.com; s=arc-20160816; b=EtYnLPv83Goot2+57ScikLzjLlFaNmygLZBQr2Wjpz+s+EFCVI4qFiG68idUuqLoyV 5ap46zQz3u/YERbKgaVZViqryb7BnQ60gAPO+O6HN3SrEw/qNcdlwcq+pbffN83Oy484 XT0kw5NbKCCMaHJEfssMdIqmgJ0M4nuok0AHAHYc6K5n6TD0L6B+CiXjOj1EAC85GYCa Msc0sF0H9tJtOsjsxSx6OLAZ0fzRDaf/eKOjxJt7tVjarB33N3eXWvGM+I6sq95U/A8D RdGnxUWe2+x9orHhySxqM4DunHV++FJt2+iun1CD31EqlNhyGEySlxbtBS4dn73i8P9d iCCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=c8Vh/CMGdauKvDE5IxHi7LeTYq5PA+l1Z+DZV3n9wnE=; b=iLws51Q+YKqea2HMQY6kQWd+hakCWAx0h7oSVR9l1H0p+jYYn54caPRRKunTD68JK6 a+uon3qECVH3jijJ/5jokGpHhwtpjkLLsicKLJq5HaI5tFtNobUuKMG9J9gHdmj+PsQV ptrrjX6ZvEUaHVl7MAU/qm3I5ZdzPD2YKmayQeSap3aURELzIfJC8mxvwaCX4W21RBDL 1Fi1SmL86maqZRXhyh9/tBV/LA1BlLF/E9wyrA8tVfuCOheeuQdNfSqOS1GkzxhJYi6F C/s+xAeHdX2ipntA27dvRKc6RfOjTm925FvXuqeADkR3+8Xr8jSoI5PsHOTq1WXipdzY 7uPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a18si3080087edy.522.2021.02.20.19.07.47; Sat, 20 Feb 2021 19:08:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231140AbhBUDHS (ORCPT + 99 others); Sat, 20 Feb 2021 22:07:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbhBUDHN (ORCPT ); Sat, 20 Feb 2021 22:07:13 -0500 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4661CC061574; Sat, 20 Feb 2021 19:06:32 -0800 (PST) Received: by angie.orcam.me.uk (Postfix, from userid 500) id CC4BD92009C; Sun, 21 Feb 2021 04:06:30 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id BCFAC92009B; Sun, 21 Feb 2021 04:06:30 +0100 (CET) Date: Sun, 21 Feb 2021 04:06:30 +0100 (CET) From: "Maciej W. Rozycki" To: Christoph Hellwig cc: Thomas Bogendoerfer , Greg Kroah-Hartman , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH 1/6] MIPS/malta: simplify plat_setup_iocoherency In-Reply-To: <20210210095641.23856-2-hch@lst.de> Message-ID: References: <20210210095641.23856-1-hch@lst.de> <20210210095641.23856-2-hch@lst.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Feb 2021, Christoph Hellwig wrote: > Given that plat_mem_setup runs before earlyparams are handled and malta > selects CONFIG_DMA_MAYBE_COHERENT, coherentio can only be set to > IO_COHERENCE_DEFAULT at this point. So remove the checking for other > options and merge plat_enable_iocoherency into plat_setup_iocoherency > to simplify the code a bit. Tested-by: Maciej W. Rozycki FWIW, Maciej