Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp743094pxb; Sat, 20 Feb 2021 21:50:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwIQfJKOrXNGAlxVsSp7xzIE7ycHoX77GUcwt+YePooU0FmLOxqsTlV0jz3nMG3irSZhakv X-Received: by 2002:a17:906:e0cb:: with SMTP id gl11mr3498240ejb.87.1613886622760; Sat, 20 Feb 2021 21:50:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613886622; cv=none; d=google.com; s=arc-20160816; b=kJ3T0af6u8PlToslL15exEz/KBJFlZGZvSUgNdUFJt55I84TGBTOO8z+gtT/OCZR9n 9rK6iHs45LIeW439QkME/h2rqtcZ6eBXtOZ4ixeKNn0vIpYnPFrl8hPkq+oOxOksKVy0 BsKKkA1xxOUfMu8h8ceefYi/sL1e2SChXJUdNiW5d5I3AjDKpIzGXt/LPU4i9Fh3+9Tv tg+R4Mm3ShlmqoecCIzEdI4FqUZI6oz8GhzuWiqci0Adc2nPeHKcZ+kngkym0ek1rsgF UxJebBPdJClNODjMHlGaXZJTfJBCIJngRn+/MdXJY2A/Lxx9nJf+GCz/GAv5ePF/opWy bwgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=1354vbHcihXn5w3wnkDoBZJpp8giNWoaYwTVJOta+Fo=; b=fLkADIbudmJB+kc3ya6H2hegyTmPVW76f3cyPI7ix1TH9JW38yU4FNVtucfDkbcA1d GWn9zSx5j831w/k8P4P9T2Pl6QTGifaR4tvS8YfPqb0KxDo3fN22y0SgmjTWRLMiC9QX 5Bzr9N7yzFICkNYK+kSVWida+rLAWOfiHWzTA1CdbQL+L0bwG34YnoU1g/u114q8MAHY ED1LnA59PuG19HmnZ3cRv2k3gvhtNcEhl9F7N7sCrANdHtfE699dm97rOfBxKonLN3eA UMHqrRRBxiAJbJXstb9WK3IqpHa8qlj/mqVYyQzywRdWoI2vUXzsU85vYx68E2k4DJp3 VLaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=MERMUPBe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg13si11181864ejc.669.2021.02.20.21.49.58; Sat, 20 Feb 2021 21:50:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=MERMUPBe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbhBUFrL (ORCPT + 99 others); Sun, 21 Feb 2021 00:47:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:42766 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230398AbhBUFqr (ORCPT ); Sun, 21 Feb 2021 00:46:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1613886356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1354vbHcihXn5w3wnkDoBZJpp8giNWoaYwTVJOta+Fo=; b=MERMUPBeOe3MMFVoRNaKasQsJkF5zwUrL+ZkGfq9KzA+woi5PXMQncytdSBS504Mtg9zfe 2KYd37koTkXw4Bdyjbyc2L7eDubUCcvsTOjvEK6UTDXNpWNr/pUI/TP4jKFoVPhgbgP3pc LaIITMDX3KhYDeJFXJMbMP78GQsih78= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7EDA1ACF6; Sun, 21 Feb 2021 05:45:56 +0000 (UTC) Subject: Re: [RFC][PATCH 6/6] objtool,x86: Rewrite retpoline thunk calls To: Peter Zijlstra , Borislav Petkov Cc: Josh Poimboeuf , x86@kernel.org, pjt@google.com, mbenes@suze.cz, linux-kernel@vger.kernel.org References: <20210219204300.749932493@infradead.org> <20210219210535.492733466@infradead.org> <20210219215530.ivzzv3oavhuip6un@treble> <20210219220158.GD59023@worktop.programming.kicks-ass.net> <20210220003920.GG26778@zn.tnic> <20210220174101.GA29905@zn.tnic> <20210220223221.GB4746@worktop.programming.kicks-ass.net> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <1e498602-5319-6f12-b33e-d40a7735d316@suse.com> Date: Sun, 21 Feb 2021 06:45:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210220223221.GB4746@worktop.programming.kicks-ass.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fW28Sdb2KVnsxmWS9MMe4PQtQ0t3VYbD0" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fW28Sdb2KVnsxmWS9MMe4PQtQ0t3VYbD0 Content-Type: multipart/mixed; boundary="E9OptFnF0YGvFx890cbyciagq5XJ7yxWx"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Peter Zijlstra , Borislav Petkov Cc: Josh Poimboeuf , x86@kernel.org, pjt@google.com, mbenes@suze.cz, linux-kernel@vger.kernel.org Message-ID: <1e498602-5319-6f12-b33e-d40a7735d316@suse.com> Subject: Re: [RFC][PATCH 6/6] objtool,x86: Rewrite retpoline thunk calls References: <20210219204300.749932493@infradead.org> <20210219210535.492733466@infradead.org> <20210219215530.ivzzv3oavhuip6un@treble> <20210219220158.GD59023@worktop.programming.kicks-ass.net> <20210220003920.GG26778@zn.tnic> <20210220174101.GA29905@zn.tnic> <20210220223221.GB4746@worktop.programming.kicks-ass.net> In-Reply-To: <20210220223221.GB4746@worktop.programming.kicks-ass.net> --E9OptFnF0YGvFx890cbyciagq5XJ7yxWx Content-Type: multipart/mixed; boundary="------------B05963FF1BCA70598F619504" Content-Language: en-US This is a multi-part message in MIME format. --------------B05963FF1BCA70598F619504 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 20.02.21 23:32, Peter Zijlstra wrote: > On Sat, Feb 20, 2021 at 06:41:01PM +0100, Borislav Petkov wrote: >>> - if we had negative alternatives objtool doesn't need to actually >>> rewrite code in this case. It could simply emit alternative entri= es >>> and call it a day. >> >> I don't mind the negative alt per se - I mind the implementation I saw= =2E >> I'm sure we can come up with something nicer, like, for example, struc= t >> alt_instr.flags to denote that this feature is a NOT feature. >=20 > So you don't like the ~ or - on cpuid? ISTR we talked about > alt_instr::flags before, but Google isn't playing ball today so I can't= > seem to find it. If you want I can cook up a patch and include it in my paravirt cleanup series. Juergen --------------B05963FF1BCA70598F619504 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------B05963FF1BCA70598F619504-- --E9OptFnF0YGvFx890cbyciagq5XJ7yxWx-- --fW28Sdb2KVnsxmWS9MMe4PQtQ0t3VYbD0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmAx85IFAwAAAAAACgkQsN6d1ii/Ey8Q xAf/Q07ew4hbCJPBVS+YfWgDZqQf+u7wEkki8cFLv0e+Xo9Mt3LcZ0C8MZLSL7lIEykyWNmHOvIF dIYTVtaU6Jb6JoL7zcVu/i7iFJDe0wbojBPR4/r8lydADMEmr3mDsNDIRq+vxgs6UhoqsdK18Sqs h56bVjLBCR488zu2BgsYFkAudOFyqx0dSUYxOYnUI1y9J/mCirJfnEwpJNPs7+ahSgSd2snmHtVR t45I598H+lui+txf/nc3kNsh312fkX70h4tcJfgqPR0LT12l+IhW0Dn4lyDQ5ohuFf9dBv1WFlgn l/yKUkQrgGfZimQ6chZVhzK91aPu3JwYpze23h+qBg== =gpEX -----END PGP SIGNATURE----- --fW28Sdb2KVnsxmWS9MMe4PQtQ0t3VYbD0--