Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210215181511.2840674-1-mic@digikod.net> <20210215181511.2840674-2-mic@digikod.net>
In-Reply-To: <20210215181511.2840674-2-mic@digikod.net>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun, 21 Feb 2021 17:52:23 +0900
Message-ID: <CAK7LNAR+vDUg-_9LiasvpuJi2BqkNOz+ufNFErHL-nQrFTixeg@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] kconfig: Remove duplicate call to sym_get_string_value()
To:     =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@digikod.net>
Cc:     James Morris <jmorris@namei.org>,
        "Serge E . Hallyn" <serge@hallyn.com>,
        Casey Schaufler <casey@schaufler-ca.com>,
        Nicolas Iooss <nicolas.iooss@m4x.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@linux.microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Feb 16, 2021 at 3:15 AM Micka=C3=ABl Sala=C3=BCn <mic@digikod.net> =
wrote:
>
> From: Micka=C3=ABl Sala=C3=BCn <mic@linux.microsoft.com>
>
> Use the saved returned value of sym_get_string_value() instead of
> calling it twice.
>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Micka=C3=ABl Sala=C3=BCn <mic@linux.microsoft.com>
> Link: https://lore.kernel.org/r/20210215181511.2840674-2-mic@digikod.net
> ---


Applied to linux-kbuild. Thanks.


>  scripts/kconfig/conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> index db03e2f45de4..18a233d27a8d 100644
> --- a/scripts/kconfig/conf.c
> +++ b/scripts/kconfig/conf.c
> @@ -137,7 +137,7 @@ static int conf_string(struct menu *menu)
>                 printf("%*s%s ", indent - 1, "", menu->prompt->text);
>                 printf("(%s) ", sym->name);
>                 def =3D sym_get_string_value(sym);
> -               if (sym_get_string_value(sym))
> +               if (def)
>                         printf("[%s] ", def);
>                 if (!conf_askvalue(sym, def))
>                         return 0;
> --
> 2.30.0
>


--=20
Best Regards
Masahiro Yamada