Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp875443pxb; Sun, 21 Feb 2021 03:27:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHNykd6Xq913ZDbEetsEGfufc+mya3T05zRnEHcLdIBQIPxb/l+w2Ng1elreQdzYRncuu/ X-Received: by 2002:aa7:c78e:: with SMTP id n14mr17493697eds.31.1613906874558; Sun, 21 Feb 2021 03:27:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613906874; cv=none; d=google.com; s=arc-20160816; b=pwzJfg7P8lCU7/+n/vWbEH1GfOLMjDQDdBh69fmgQqvVwiUvsSAFHRAztI/M7/bcdf t58S5iy9lzaVbfRph6pYMXQAdvHi0rGeCjjFCHxvP/hljWGGrIw2QLo20b9RGwjIRwaT coeSzA+EIwgmgV3XHQ0IIe6+vYKLPZLGgSh0dOVcHX7kSPFZhcJI2WaKzcL2LDLVhi03 Joal4lFGnU3O5bCSjbwKNuIFkzfQAI12ng1B2JE+avlIGL0t/9SFY1qbD0eW3mSDtrQa c/oVPtaKb4CUTi8Bmhx09PYOMuSkJDhvb9O4m8Dk+ECiihoLI+VNeL0ShLpY3fRmoaLA N5DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ny+r7yYmalJUBD8mDWuRwFvaJ8CBS43p5gZF+DopOdQ=; b=hffLQsLbus1JXOL4avrOBOqnYYAsJ5SDPUtJueq9QlfluTH6WREBCkkMFuguXfsjuM DKkUiQM97p+zPgonJqjgTyEIwC6rHbePFV/LtOF+lLABvnxS5GDbCUiFdMSAoLeNQMfD 5J21vXFXJX1b/tIquZCFELqbQxdY/pT0OjeLbg7zPb3xJfKxwxUDjSm4nGQ4Plgq/Ct/ mRcwlfDEdVzeZE/WBbXeeR+hcQOpgGezfkFtPa5ycDz3seMM0/YyjxHugON76BlxDcXP NgBr4Dnruc0KmnF0TdDqqfJHmD1leClJ+O2wRk8uCQxmDHWEhW0RVb/LHHJlF/KKLh+h awJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nQjYtThi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si8018394ejm.72.2021.02.21.03.27.29; Sun, 21 Feb 2021 03:27:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nQjYtThi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbhBUL1D (ORCPT + 99 others); Sun, 21 Feb 2021 06:27:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:54338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbhBUL1C (ORCPT ); Sun, 21 Feb 2021 06:27:02 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5397164EE6; Sun, 21 Feb 2021 11:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613906781; bh=kkFnXUKm0Rf2iX3RQtP2a5rmUIvBNUgXozmpS/vKma8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nQjYtThi8Z6ofSATMneeTrITirVNKfdpTg78V0XP4ydEoy+MtQJ2NqkQeUVpneT8M zVNZRAr5CPLFQdXTbcfBEyyp/XhN/UTEwfsLc11OJHwKGS34uOh94Hsn+jfXmYU5yS p6pwjzM8lCvkOx9NLXE9NYs/dtKmFVo1LbAKBOcQ= Date: Sun, 21 Feb 2021 12:26:19 +0100 From: Greg Kroah-Hartman To: karthik alapati Cc: Lee Jones , Johannes Berg , Arnd Bergmann , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: wimax/i2400m: fix byte-order type issue Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 20, 2021 at 06:22:31PM +0530, karthik alapati wrote: > fix sparse type warning by converting le32 types to > host byte-order types before comparison > > Signed-off-by: karthik alapati > --- > drivers/staging/wimax/i2400m/fw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c > index 92ea5c101..f09de1810 100644 > --- a/drivers/staging/wimax/i2400m/fw.c > +++ b/drivers/staging/wimax/i2400m/fw.c > @@ -511,7 +511,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode, > opcode, i2400m_brh_get_response(ack)); > goto error_ack_failed; > } > - if (ack_size < ack->data_size + sizeof(*ack)) { > + if (ack_size < le32_to_cpu(ack->data_size) + sizeof(*ack)) { > dev_err(dev, "boot-mode cmd %d: SW BUG " > "driver provided only %zu bytes for %zu bytes " > "of data\n", opcode, ack_size, You sent 3 patches that seem to do the same thing, yet are a bit different? Please make your patches a patch series and provide proper subject lines to make them unique. I have now dropped all of your submitted patches from my review queue. thanks, greg k-h